From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH 0/7] iotests/129: Fix it
Date: Wed, 13 Jan 2021 17:59:24 +0300 [thread overview]
Message-ID: <8a674846-1f78-9fd2-b8ef-e0ef73d736ef@virtuozzo.com> (raw)
In-Reply-To: <20210113143816.GB5928@merkur.fritz.box>
13.01.2021 17:38, Kevin Wolf wrote:
> Am 13.01.2021 um 15:06 hat Max Reitz geschrieben:
>> - pylint and mypy complain.
>> (Running mypy with the options given in 297.)
>> [Patch 4 removes one pylint complaint; patch 7 the rest.]
>
> Should we add it to 297 then to make sure we won't regress?
>
> At some point, I guess we'll want to cover all Python tests, but I
> assume it was too much to change in the same series as for the
> iotests.py cleanup.
>
Related:
anyone knows, what's the difference between pylint and pylint-3?
I know I can do pip3 install pylint, which brings pylint binary.. Also there is pylint fedora package which provides pylint binary and python3-pylint fedora package which provides pylint-3 binary, both package names looks so that they are... the same?
Also. Interesting, but pylint don't check PEP8 code style (or at least not everything of it). For example, pycodestyle has a lot of complains about iotests.py (most of them "E302 expected 2 blank lines, found 1").. So, what about adding pycodestyle (or may be better flake8 which is pycodestyle + some additional things) to 127 iotest?
--
Best regards,
Vladimir
next prev parent reply other threads:[~2021-01-13 15:01 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 14:06 [PATCH 0/7] iotests/129: Fix it Max Reitz
2021-01-13 14:06 ` [PATCH 1/7] iotests: Move try_remove to iotests.py Max Reitz
2021-01-13 14:25 ` Eric Blake
2021-01-13 14:06 ` [PATCH 2/7] iotests/129: Remove test images in tearDown() Max Reitz
2021-01-13 14:34 ` Vladimir Sementsov-Ogievskiy
2021-01-13 14:43 ` Eric Blake
2021-01-13 14:06 ` [PATCH 3/7] iotests/129: Do not check @busy Max Reitz
2021-01-13 14:48 ` Eric Blake
2021-01-13 15:01 ` Vladimir Sementsov-Ogievskiy
2021-01-13 14:06 ` [PATCH 4/7] iotests/129: Use throttle node Max Reitz
2021-01-13 14:10 ` Max Reitz
2021-01-13 14:53 ` Eric Blake
2021-01-13 15:07 ` Vladimir Sementsov-Ogievskiy
2021-01-13 15:15 ` Max Reitz
2021-01-13 16:46 ` Vladimir Sementsov-Ogievskiy
2021-01-13 17:02 ` Max Reitz
2021-01-13 17:05 ` Vladimir Sementsov-Ogievskiy
2021-01-13 14:06 ` [PATCH 5/7] iotests/129: Actually test a commit job Max Reitz
2021-01-13 15:58 ` Eric Blake
2021-01-13 16:52 ` Vladimir Sementsov-Ogievskiy
2021-01-13 14:06 ` [PATCH 6/7] iotests/129: Limit mirror job's buffer size Max Reitz
2021-01-13 16:03 ` Eric Blake
2021-01-13 17:02 ` Vladimir Sementsov-Ogievskiy
2021-01-13 14:06 ` [PATCH 7/7] iotests/129: Clean up pylint and mypy complaints Max Reitz
2021-01-13 16:04 ` Eric Blake
2021-01-13 14:31 ` [PATCH 0/7] iotests/129: Fix it Vladimir Sementsov-Ogievskiy
2021-01-13 15:19 ` Max Reitz
2021-01-13 15:29 ` Vladimir Sementsov-Ogievskiy
2021-01-13 14:38 ` Kevin Wolf
2021-01-13 14:59 ` Vladimir Sementsov-Ogievskiy [this message]
2021-01-13 15:26 ` Max Reitz
2021-01-13 15:43 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a674846-1f78-9fd2-b8ef-e0ef73d736ef@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.