From: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
To: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>,
rust-for-linux@vger.kernel.org
Cc: ojeda@kernel.org
Subject: Re: [PATCH v1] rust: build: Fix grep warning
Date: Thu, 2 Mar 2023 11:21:05 -0300 [thread overview]
Message-ID: <8a6a5f29-e329-5129-9c7f-e40b737de70f@gmail.com> (raw)
In-Reply-To: <20230302132107.210502-1-vincenzopalazzodev@gmail.com>
On 3/2/23 10:21, Vincenzo Palazzo wrote:
> Fix grep warning during the build, with GNU grep 3.8
> with the following command
>
> `grep -v '^\#\|^$$' rust/bindgen_parameters`
>
> I see the following warning
>
> ```
> grep: warning: stray \ before #
>
> --opaque-type xregs_state
> --opaque-type desc_struct
> --opaque-type arch_lbr_state
> --opaque-type local_apic
>
> --opaque-type x86_msi_data
> --opaque-type x86_msi_addr_lo
>
> --opaque-type kunit_try_catch
>
> --opaque-type spinlock
>
> --no-doc-comments
> ```
>
> Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
> ---
> rust/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rust/Makefile b/rust/Makefile
> index f88d108fbef0..41ac8401a8be 100644
> --- a/rust/Makefile
> +++ b/rust/Makefile
> @@ -283,7 +283,7 @@ quiet_cmd_bindgen = BINDGEN $@
> $(bindgen_target_cflags) $(bindgen_target_extra)
>
> $(obj)/bindings/bindings_generated.rs: private bindgen_target_flags = \
> - $(shell grep -v '^\#\|^$$' $(srctree)/$(src)/bindgen_parameters)
> + $(shell grep -v '^#\|^$$' $(srctree)/$(src)/bindgen_parameters)
> $(obj)/bindings/bindings_generated.rs: $(src)/bindings/bindings_helper.h \
> $(src)/bindgen_parameters FORCE
> $(call if_changed_dep,bindgen)
Because this is surrounded by quotes there's no problem to no escape it.
Tested-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
next prev parent reply other threads:[~2023-03-02 14:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 13:21 [PATCH v1] rust: build: Fix grep warning Vincenzo Palazzo
2023-03-02 14:21 ` Martin Rodriguez Reboredo [this message]
2023-04-06 22:50 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a6a5f29-e329-5129-9c7f-e40b737de70f@gmail.com \
--to=yakoyoku@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=vincenzopalazzodev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.