Re: soc_button_array: ignored -EPROBE_DEFER loses the buttons on 68% of boots (Surface Pro 11)

[Hans de Goede <hansg@kernel.org>]

Hi,

On 8-Sep-26 23:46, Hans de Goede wrote:

<snip>

>> Why no patch
>> ------------
>>
>> The comment says -EPROBE_DEFER is discarded because Intel uses "virtual
>> GPIOs" that never materialise, so deferring on them would hang the probe
>> forever. A fix has to tell that case apart from a controller that simply has
>> not probed yet, and I do not know which signal you would want to use for
>> that. Guessing would risk reintroducing the problem the workaround exists
>> for.
>>> Happy to test whatever shape you would prefer - the machine is here and I
>> can build and boot kernels on it.
> 
> Thank you for your detailed bug report. I've just submitted a patch which
> I believe should fix this:
> 
> https://lore.kernel.org/platform-driver-x86/20260908214410.70422-1-johannes.goede@oss.qualcomm.com/
> 
> Please give this a try and confirm if it fixes things.

Shashiko review has lead to a v2 and then a v3 of the fix, please
give v3 a try:

https://lore.kernel.org/linux-input/20260909093934.29411-1-johannes.goede@oss.qualcomm.com/

Regards,
 
Hans