From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75320C71153 for ; Mon, 4 Sep 2023 07:35:21 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2BD8C10E2B9; Mon, 4 Sep 2023 07:35:11 +0000 (UTC) X-Greylist: delayed 431 seconds by postgrey-1.36 at gabe; Mon, 04 Sep 2023 07:35:04 UTC Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0B91410E2B9 for ; Mon, 4 Sep 2023 07:35:02 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id D647BCE0E16; Mon, 4 Sep 2023 07:27:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6242C433C8; Mon, 4 Sep 2023 07:27:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693812468; bh=piU91Jcbu/nw4mkWE2ebzf6Prd/hbd/WAB0XaDvFVKs=; h=Date:From:To:Subject:In-Reply-To:References:Cc:From; b=Zvb1r76GhELMisX9kegFx6hYvKO9a95ROEtrBeUGlMbCGe6dLBS306Urr9gQ7Y4/O RjfMKdnLGbxCogy0Sw7M71edlT+aFPxH+Z52ERTui2cf/2MCtDIQTpRsuO8KUAZ+gj UhPAJAp8xsJEuCC1OEYmDrSYMakSkrxSuqnNWimZfR8AAgUePniokMZ9WDo+KhQPGZ 1UeKp+Y4eulL+A+VxVQ09/eumfPM+kiPlkxnI4wac8PKcm+PMHlHBGwaZScVNLeurG 9bZhX6EBfgW0mneEv6bUiP5l3w/Hi8gz6AGocWmZMqxky1J0imwWFMJ58DF4cHvLj+ 0ZH5AS8zmDoeg== Message-ID: <8a90bc6f4bf16d5aa545e5215f2a5112.mripard@kernel.org> Date: Mon, 04 Sep 2023 07:27:45 +0000 From: "Maxime Ripard" To: "Douglas Anderson" In-Reply-To: <20230901164111.RFT.6.Ie7588ec6e0f93e8bc700e76b265ad1a7ad6b15ad@changeid> References: <20230901164111.RFT.6.Ie7588ec6e0f93e8bc700e76b265ad1a7ad6b15ad@changeid> Content-Transfer-Encoding: 7bit Subject: Re: [Nouveau] [RFT PATCH 06/15] drm/nouveau: Call drm_atomic_helper_shutdown() or equiv at shutdown time X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxime Ripard , nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, bskeggs@redhat.com, daniel@ffwll.ch Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Fri, 1 Sep 2023 16:41:17 -0700, Douglas Anderson wrote: > Based on grepping through the source code this driver appears to be > missing a call to drm_atomic_helper_shutdown() (or > drm_helper_force_disable_all() if not using atomic) at system shutdown > time. Among other things, this means that if a panel is in use that it > won't be cleanly powered off at system shutdown time. > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47529C83F33 for ; Mon, 4 Sep 2023 07:27:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 05A7710E2B2; Mon, 4 Sep 2023 07:27:56 +0000 (UTC) Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by gabe.freedesktop.org (Postfix) with ESMTPS id C036410E2B2 for ; Mon, 4 Sep 2023 07:27:53 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id D647BCE0E16; Mon, 4 Sep 2023 07:27:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6242C433C8; Mon, 4 Sep 2023 07:27:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693812468; bh=piU91Jcbu/nw4mkWE2ebzf6Prd/hbd/WAB0XaDvFVKs=; h=Date:From:To:Subject:In-Reply-To:References:Cc:From; b=Zvb1r76GhELMisX9kegFx6hYvKO9a95ROEtrBeUGlMbCGe6dLBS306Urr9gQ7Y4/O RjfMKdnLGbxCogy0Sw7M71edlT+aFPxH+Z52ERTui2cf/2MCtDIQTpRsuO8KUAZ+gj UhPAJAp8xsJEuCC1OEYmDrSYMakSkrxSuqnNWimZfR8AAgUePniokMZ9WDo+KhQPGZ 1UeKp+Y4eulL+A+VxVQ09/eumfPM+kiPlkxnI4wac8PKcm+PMHlHBGwaZScVNLeurG 9bZhX6EBfgW0mneEv6bUiP5l3w/Hi8gz6AGocWmZMqxky1J0imwWFMJ58DF4cHvLj+ 0ZH5AS8zmDoeg== Message-ID: <8a90bc6f4bf16d5aa545e5215f2a5112.mripard@kernel.org> Date: Mon, 04 Sep 2023 07:27:45 +0000 From: "Maxime Ripard" To: "Douglas Anderson" Subject: Re: [RFT PATCH 06/15] drm/nouveau: Call drm_atomic_helper_shutdown() or equiv at shutdown time In-Reply-To: <20230901164111.RFT.6.Ie7588ec6e0f93e8bc700e76b265ad1a7ad6b15ad@changeid> References: <20230901164111.RFT.6.Ie7588ec6e0f93e8bc700e76b265ad1a7ad6b15ad@changeid> Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxime Ripard , kherbst@redhat.com, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, bskeggs@redhat.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, 1 Sep 2023 16:41:17 -0700, Douglas Anderson wrote: > Based on grepping through the source code this driver appears to be > missing a call to drm_atomic_helper_shutdown() (or > drm_helper_force_disable_all() if not using atomic) at system shutdown > time. Among other things, this means that if a panel is in use that it > won't be cleanly powered off at system shutdown time. > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42414C71153 for ; Mon, 4 Sep 2023 07:27:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345118AbjIDH2A (ORCPT ); Mon, 4 Sep 2023 03:28:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229659AbjIDH1y (ORCPT ); Mon, 4 Sep 2023 03:27:54 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8793ABA for ; Mon, 4 Sep 2023 00:27:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id DFD1DCE0E24 for ; Mon, 4 Sep 2023 07:27:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6242C433C8; Mon, 4 Sep 2023 07:27:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693812468; bh=piU91Jcbu/nw4mkWE2ebzf6Prd/hbd/WAB0XaDvFVKs=; h=Date:From:To:Subject:In-Reply-To:References:Cc:From; b=Zvb1r76GhELMisX9kegFx6hYvKO9a95ROEtrBeUGlMbCGe6dLBS306Urr9gQ7Y4/O RjfMKdnLGbxCogy0Sw7M71edlT+aFPxH+Z52ERTui2cf/2MCtDIQTpRsuO8KUAZ+gj UhPAJAp8xsJEuCC1OEYmDrSYMakSkrxSuqnNWimZfR8AAgUePniokMZ9WDo+KhQPGZ 1UeKp+Y4eulL+A+VxVQ09/eumfPM+kiPlkxnI4wac8PKcm+PMHlHBGwaZScVNLeurG 9bZhX6EBfgW0mneEv6bUiP5l3w/Hi8gz6AGocWmZMqxky1J0imwWFMJ58DF4cHvLj+ 0ZH5AS8zmDoeg== Message-ID: <8a90bc6f4bf16d5aa545e5215f2a5112.mripard@kernel.org> Date: Mon, 04 Sep 2023 07:27:45 +0000 From: "Maxime Ripard" To: "Douglas Anderson" Subject: Re: [RFT PATCH 06/15] drm/nouveau: Call drm_atomic_helper_shutdown() or equiv at shutdown time In-Reply-To: <20230901164111.RFT.6.Ie7588ec6e0f93e8bc700e76b265ad1a7ad6b15ad@changeid> References: <20230901164111.RFT.6.Ie7588ec6e0f93e8bc700e76b265ad1a7ad6b15ad@changeid> Cc: airlied@gmail.com, bskeggs@redhat.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, kherbst@redhat.com, linux-kernel@vger.kernel.org, lyude@redhat.com, nouveau@lists.freedesktop.org, "Maxime Ripard" Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 1 Sep 2023 16:41:17 -0700, Douglas Anderson wrote: > Based on grepping through the source code this driver appears to be > missing a call to drm_atomic_helper_shutdown() (or > drm_helper_force_disable_all() if not using atomic) at system shutdown > time. Among other things, this means that if a panel is in use that it > won't be cleanly powered off at system shutdown time. > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime