From: Gregor Riepl <onitake@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "russianneuromancer @ ya . ru" <russianneuromancer@ya.ru>,
linux-input@vger.kernel.org
Subject: Re: [PATCH 2/4] Input: silead_gsl1680: gpiod_get returning -EBUSY is not an error
Date: Sat, 31 Dec 2016 18:06:59 +0100 [thread overview]
Message-ID: <8aae51ca-34fa-3f75-423a-aacbfb60eef2@gmail.com> (raw)
In-Reply-To: <77a85e17-b47f-8d01-1fe3-53ed07002768@redhat.com>
> We could simply make the gpio completely optional by doing:
>
> Then we don't end up ugly-fying the silead.c code...
I remember vaguely that this will make the driver useless in many cases.
Some DSDTs I've seen have ACPI PM functions that handle the GPIO lines, and I
tried calling them instead of managing the GPIO directly. This did not appear
to work, but maybe I did it wrong.
See here:
https://github.com/onitake/gslx680-acpi/blob/master/gslx680_ts_acpi.c#L571
And this is what's supposed to be called:
https://github.com/onitake/gslx680-acpi/blob/master/acpi/gsl-dsdt.aml#L12
next prev parent reply other threads:[~2016-12-31 17:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 10:35 [PATCH 1/4] input: of_touchscreen: Preserve flags passed into touchscreen_parse_properties Hans de Goede
2016-12-09 10:35 ` [PATCH 2/4] Input: silead_gsl1680: gpiod_get returning -EBUSY is not an error Hans de Goede
2016-12-27 22:14 ` Dmitry Torokhov
2016-12-31 16:45 ` Hans de Goede
2016-12-31 17:06 ` Gregor Riepl [this message]
2016-12-31 18:57 ` Hans de Goede
2016-12-09 10:35 ` [PATCH 3/4] Input: silead_gsl1680: Allow silead_ts_read_props to override default resolution Hans de Goede
2016-12-09 10:35 ` [PATCH 4/4] Input: silead_gsl1680: Add support for setting resolution based on dmi data Hans de Goede
2016-12-27 22:27 ` Dmitry Torokhov
2016-12-31 17:09 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8aae51ca-34fa-3f75-423a-aacbfb60eef2@gmail.com \
--to=onitake@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=russianneuromancer@ya.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.