From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F1A1105A58F for ; Thu, 12 Mar 2026 11:53:35 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1252221.1548975 (Exim 4.92) (envelope-from ) id 1w0ebM-0001GM-Ta; Thu, 12 Mar 2026 11:53:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1252221.1548975; Thu, 12 Mar 2026 11:53:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1w0ebM-0001GF-QP; Thu, 12 Mar 2026 11:53:16 +0000 Received: by outflank-mailman (input) for mailman id 1252221; Thu, 12 Mar 2026 11:53:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1w0ebM-0001G9-7F for xen-devel@lists.xenproject.org; Thu, 12 Mar 2026 11:53:16 +0000 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [2a00:1450:4864:20::336]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0ca57f07-1e0a-11f1-9ccf-f158ae23cfc8; Thu, 12 Mar 2026 12:53:13 +0100 (CET) Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-4853510b4f3so11878155e9.0 for ; Thu, 12 Mar 2026 04:53:13 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4854b66ffe2sm121016715e9.13.2026.03.12.04.53.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Mar 2026 04:53:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0ca57f07-1e0a-11f1-9ccf-f158ae23cfc8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1773316393; x=1773921193; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=m5lp2iKgko+e2S9raenz03hPtnNB0mQ5tKB85rLA/so=; b=GvBh92jht2AaVzs3Fzx4/+5g7ux8jwej4FeH7ZjEeHwTFC/xVyx7c6lIxi6gydQBZh JwTauyujnJ0A9v4wakJcKY0nGOyfp7oY4xN3cmwQg35icRVVZguQv6jsvJD8H/3nwqQZ M5lV6wUsBYyiTviFr8MJtcjRAgk1CnLrZzGU3gML3n309w+fGrkjPUzhYojtLmValuOi X5ykYCVvemhYguVmrs6h8bg7X25AImQHHsD2xTkcmka99U70qMCMkJWknsO8GRoN42Os p/h9RvLk6dPHFsiV6CGD1s77KxhLhHCCgElPBZTQ9Tl7VgbnI4G7ZImUWAkAE1wXZ4Lx o4yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773316393; x=1773921193; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=m5lp2iKgko+e2S9raenz03hPtnNB0mQ5tKB85rLA/so=; b=Wz1CNnX3Yt4rDdCihERM/tAceeigHPCg5hR83o/PPQXQl/W+A+j28jKDtBvVx6EzFb oRs9qO3u5bUsEPnqlnvEASixwJMMT//wm/7HbsPWk7OlOM5r9dukpaqFX/2XbpY4NbjY 90aj2epURySb28vos+p/W+ceNFQCrkJlO+lv6Zdo3+8P5ILSs8P3oNLsMjz31pkRGYXR nWOX0BJNEvUrF4UiKhgX1ws7N4bnTEyTqycc2lfHgVa8Yr+hkRC82ujo+cjvxdk340O+ 0vkNDAZHZtmp0MdeQTgcCr/+inZUpvfoX3be8KERE+G67TgwzJo5SH3sZanyH7QeTk0v CmTA== X-Forwarded-Encrypted: i=1; AJvYcCX4BYMlQ0guy6WzGom8Xksf9XCZmJiHWN9tJ7BiHm8iV37TEPoKsLJnS5+OuVGjhqBpSjSTH4VACRQ=@lists.xenproject.org X-Gm-Message-State: AOJu0YxS+8dTJTiuy7SlhjtD3HSdGQISnGjYPQhLBnWSte7FBdSgdSop xzA44GhMNKCh48cW6Nq7GEteBO6yzo3ViKUk+l4T7hfz7YhznulA004koLhoUP2+WA== X-Gm-Gg: ATEYQzwA4vbk2IPxvuBYbuYAZwyC+RjdE+mbkpSUAzCOpiNCe3FpMWrd2VqI3QPUGBr 98IA0ACM2Au3THkVE7E6x18x/6rx2D7omGJ1I7JmmbaDwCm/jUAk1x/5gAVOtr4fr+gj/s1LUgy NP+Ha1p+qVYZjzS6InHsFstcut/SLZX9AREWAwm47k0uiQ3sPfO4TNn+QL5neYeER6Sh3wCrqHm BB0DtFl/nkH93b6DJYZL4KoP4NhORrYIT7LyAtQrG4yypKXkBVdz6ZFlvew3dgBhBFs4CkBZLA5 ZeQ4P/oPU2WPZWQpiCv0jKx3k6batP58v3w+/QPA1oQ/nmkHvSJwJ1LAbnGV848F+fW1YCMDc2v ZkMzL0wHHWIyoRAEZmpEMX7JFbMBv3CPyMVloARPToLuZbBIMxAVH/2zCskUf32UX/XwiloJ5tu UBEg8mi2Tw3S24y7WMetVjslTQPjzTokTvwrrQ1YQU5FcOtJk95beTkL/rPaEKpwJcZSiCWDLrQ BLrjm2IFKz5c1I= X-Received: by 2002:a05:600c:3544:b0:485:30f7:6e88 with SMTP id 5b1f17b1804b1-4854b12189amr103770855e9.31.1773316393107; Thu, 12 Mar 2026 04:53:13 -0700 (PDT) Message-ID: <8ac5f8a5-456d-45e0-8efa-13cc7050dcb0@suse.com> Date: Thu, 12 Mar 2026 12:53:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/7] x86/dmop: Add XEN_DMOP_{bind,unbind}_pt_msi_irq DM ops From: Jan Beulich To: Julian Vetter Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Anthony PERARD , Michal Orzel , Stefano Stabellini , Juergen Gross , Julien Grall , xen-devel@lists.xenproject.org References: <20260309123055.880050-1-julian.vetter@vates.tech> <20260309123055.880050-5-julian.vetter@vates.tech> <55a65f8d-40df-4841-8e76-200c82f397c5@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <55a65f8d-40df-4841-8e76-200c82f397c5@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11.03.2026 17:04, Jan Beulich wrote: > On 09.03.2026 13:31, Julian Vetter wrote: >> @@ -607,6 +631,83 @@ int dm_op(const struct dmop_args *op_args) >> break; >> } >> >> + case XEN_DMOP_bind_pt_msi_irq: >> + { >> + const struct xen_dm_op_bind_pt_msi_irq *data = >> + &op.u.bind_pt_msi_irq; >> + struct xen_domctl_bind_pt_irq bind = { >> + .machine_irq = data->machine_irq, >> + .irq_type = PT_IRQ_TYPE_MSI, >> + }; >> + int irq; >> + >> + rc = -EINVAL; >> + if ( data->pad0 || data->pad1 ) >> + break; >> + >> + if ( data->flags & ~XEN_DMOP_MSI_FLAG_UNMASKED ) >> + break; >> + >> + irq = domain_pirq_to_irq(d, bind.machine_irq); >> + >> + rc = -EPERM; >> + if ( irq <= 0 || !irq_access_permitted(current->domain, irq) ) >> + break; >> + >> + bind.u.msi.gvec = data->gvec; >> + bind.u.msi.gflags = >> + msi_addr_to_gflags(data->addr, data->data, >> + !(data->flags & XEN_DMOP_MSI_FLAG_UNMASKED)); >> + bind.u.msi.gtable = data->gtable; >> + >> + rc = -ESRCH; >> + if ( is_iommu_enabled(d) ) >> + { >> + pcidevs_lock(); >> + rc = pt_irq_create_bind(d, &bind); >> + pcidevs_unlock(); > > I understand the same locking is used at the other call site, but it's as > questionable there as it is here. We should try hard to avoid use of this > global lock when something lighter-weight would do. I should perhaps have added that I have this on my own list of things to look into, just that I didn't get to it yet. Jan