From: Alexey Budankov <alexey.budankov@linux.intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Andi Kleen <ak@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 02/12] perf record: implement -f,--mmap-flush=<threshold> option
Date: Wed, 13 Mar 2019 18:00:46 +0300 [thread overview]
Message-ID: <8adaa965-8ddd-e67a-975a-495a9cda6e38@linux.intel.com> (raw)
In-Reply-To: <20190313143656.GB6676@krava>
On 13.03.2019 17:36, Jiri Olsa wrote:
> On Tue, Mar 12, 2019 at 08:12:23AM +0300, Alexey Budankov wrote:
>
> SNIP
>
>> record__aio_mmap_read_sync(rec);
>>
>> if (forks) {
>> @@ -1815,6 +1863,7 @@ static struct record record = {
>> .uses_mmap = true,
>> .default_per_cpu = true,
>> },
>> + .mmap_flush = MMAP_FLUSH_DEFAULT,
>> },
>> .tool = {
>> .sample = process_sample_event,
>> @@ -1881,6 +1930,9 @@ static struct option __record_options[] = {
>> OPT_CALLBACK('m', "mmap-pages", &record.opts, "pages[,pages]",
>> "number of mmap data pages and AUX area tracing mmap pages",
>> record__parse_mmap_pages),
>> + OPT_CALLBACK('f', "mmap-flush", &record.opts, "bytes",
>> + "Minimal number of bytes that is extracted from mmap data pages (default: 1)",
>> + record__mmap_flush_parse),
>
> let's not consume the 'f' for this option, just --map-flush
in v8.
~Alexey
>
> jirka
>
next prev parent reply other threads:[~2019-03-13 15:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 4:57 [PATCH v7 00/12] perf: enable compression of record mode trace to save storage space Alexey Budankov
2019-03-12 5:03 ` [PATCH v7 01/12] feature: implement libzstd check, LIBZSTD_DIR and NO_LIBZSTD defines Alexey Budankov
2019-03-12 5:12 ` [PATCH v7 02/12] perf record: implement -f,--mmap-flush=<threshold> option Alexey Budankov
2019-03-13 14:36 ` Jiri Olsa
2019-03-13 15:00 ` Alexey Budankov [this message]
2019-03-12 5:15 ` [PATCH v7 03/12] perf session: define bytes_transferred and bytes_compressed metrics Alexey Budankov
2019-03-12 5:17 ` [PATCH v7 04/12] perf record: implement COMPRESSED event record and its attributes Alexey Budankov
2019-03-12 5:20 ` [PATCH v7 05/12] perf mmap: implement dedicated memory buffer for data compression Alexey Budankov
2019-03-12 5:23 ` [PATCH v7 06/12] perf util: introduce Zstd based streaming compression API Alexey Budankov
2019-03-13 14:37 ` Jiri Olsa
2019-03-13 15:06 ` Alexey Budankov
2019-03-12 5:25 ` [PATCH v7 07/12] perf record: implement compression for serial trace streaming Alexey Budankov
2019-03-12 5:30 ` [PATCH v7 08/12] perf record: implement compression for AIO " Alexey Budankov
2019-03-13 14:36 ` Jiri Olsa
2019-03-13 15:33 ` Alexey Budankov
2019-03-13 14:37 ` Jiri Olsa
2019-03-12 5:32 ` [PATCH v7 09/12] perf record: implement -z,--compression_level=n option Alexey Budankov
2019-03-12 5:36 ` [PATCH v7 10/12] perf report: implement record trace decompression Alexey Budankov
2019-03-13 14:37 ` Jiri Olsa
2019-03-13 15:55 ` Alexey Budankov
2019-03-14 9:01 ` Jiri Olsa
2019-03-12 5:37 ` [PATCH v7 11/12] perf inject: enable COMPRESSED records decompression Alexey Budankov
2019-03-12 5:38 ` [PATCH v7 12/12] perf tests: implement Zstd comp/decomp integration test Alexey Budankov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8adaa965-8ddd-e67a-975a-495a9cda6e38@linux.intel.com \
--to=alexey.budankov@linux.intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.