From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bin Ren <bin.ren@gmail.com>
Subject: Re: [PATCH] Network Checksum Removal
Date: Mon, 23 May 2005 16:31:47 +0100
Message-ID: <8ae7802505052308313bcc4b56@mail.gmail.com>
References: <20050520233015.GA26305@us.ibm.com>
	<7b69de31f49a2b1179da2e52154588a0@cl.cam.ac.uk>
	<3b8c9059967af27880d4144c31f05343@cl.cam.ac.uk>
	<200505231029.14649.habanero@us.ibm.com>
Reply-To: bin.ren@cl.cam.ac.uk
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <200505231029.14649.habanero@us.ibm.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Andrew Theurer <habanero@us.ibm.com>
Cc: Xen-devel@lists.xensource.com, Jon Mason <jdmason@us.ibm.com>
List-Id: xen-devel@lists.xenproject.org

It seems to break the interdomain ssh and nfs on my machine. Digging
for reasons.

- Bin

On 5/23/05, Andrew Theurer <habanero@us.ibm.com> wrote:
> > I've checked in a modified version of your patch that hopefully deals
> > with propagating checksum information in both directions across a
> > virtual bridge or router. I replaced your skb flags with two new ones
> > -- proto_csum_blank and proto_csum_valid.
> >
> > The former indicates that the protocol-level checksum needs filling
> > in. This is not a problem for local processing, but the flag is
> > picked up before sending to a physical interface and fixed up.
> >
> > The latter indicates that the proto-level checksum has been validated
> > since arrival at localhost (*or* that the packet originated from a
> > domU on localhost). This flag survives crossing a bridge/router so we
> > can trust it when deciding if checksum validation is required.
> >
> > I'll push the patch to the bkbits repository just as soon as bkbits
> > rematerialises. :-)
> >
> > If you have any performance or stress tests that you were using to
> > test checksum offloading, it would be great to find out how they
> > perform on the checked-in version!
>=20
> Now that BK is up, I'll run some netperf tests before/after that
> changeset and see what we get.
>=20
> -Andrew
>=20
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>