From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0DFD4C44500 for ; Mon, 6 Jul 2026 17:49:56 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgnRM-00035B-EZ; Mon, 06 Jul 2026 13:49:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgnRK-00034v-Bc; Mon, 06 Jul 2026 13:49:06 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgnRH-00073S-I8; Mon, 06 Jul 2026 13:49:05 -0400 Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666FIMdM962178; Mon, 6 Jul 2026 17:49:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=by/GwV C4Co3ze7+zBdwGKmJyh+Ix7fcTYYWp0U9jyW4=; b=qMXsMr0dphuQu3+6FLMUg4 1/WmYuTIGSoIf/Bu9mL3x726yoe8yhr7Kn9vgoqwn6cRHoNrfFbWGh0UZbo+IeIc XhAN/0otG6sQ6Z8OtqVv6IAYBWqiFTpC396MD7RwLn7dxtlctQLaLmADsZuyhUtl D2qcGLow91y8+3ggplSAgpXH6HdbRDAozx5Xf747l9s9cj5ZHAzSA4UZL+rQ7mu1 bVYxGzJxmcJLhE1Mv7r/gdQg6P9bJoWmXNc1fXelea0b6jc0AoP2EHpolhevhBDo KOwy/kEPYifQYXBzIqKta//yaoUGmP3orN+sviEZmwUCgGgwkwjKwqA2pVa9f3fQ == Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4f6suqjm5s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Jul 2026 17:48:59 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 666HYZ9i018471; Mon, 6 Jul 2026 17:48:59 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 4f7f6xx9t5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Jul 2026 17:48:58 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 666HmtBH16187824 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 6 Jul 2026 17:48:55 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 14E7B20049; Mon, 6 Jul 2026 17:48:55 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D51CB20040; Mon, 6 Jul 2026 17:48:46 +0000 (GMT) Received: from [9.67.146.25] (unknown [9.67.146.25]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 6 Jul 2026 17:48:46 +0000 (GMT) Message-ID: <8ae826c7-775c-4282-a734-9a18357f532c@linux.ibm.com> Date: Mon, 6 Jul 2026 23:18:44 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Nikhil Kumar Singh Subject: Re: [RFC PATCH 18/28] target/ppc: Move sleep & friends to decodetree To: Chinmay Rath , qemu-devel@nongnu.org, qemu-ppc@nongnu.org, npiggin@gmail.com, harshpb@linux.ibm.com, richard.henderson@linaro.org, peter.maydell@linaro.org, stefanha@redhat.com Cc: milesg@linux.ibm.com, vishalc@linux.ibm.com, tshah@linux.ibm.com, shivangu@linux.ibm.com, ojaswin@linux.ibm.com, aboorvad@linux.ibm.com, amachhiw@linux.ibm.com, sv@linux.ibm.com, shivani@linux.ibm.com, mkchauras@gmail.com, uverma@linux.ibm.com References: <20260520160728.2283628-1-rathc@linux.ibm.com> <20260520160728.2283628-19-rathc@linux.ibm.com> Content-Language: en-US In-Reply-To: <20260520160728.2283628-19-rathc@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE4MCBTYWx0ZWRfXz73rICapdM+v TyzfUKQhJq7apqM6Z1t5/bo6kLQCdJCTjU4r5IVGiL8AfDWXnVagw4/7HbUOBhodAJGHwo/A0pi EbHMFFl3AVN9cTVWPvMETNLgpTojR00= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE4MCBTYWx0ZWRfX6qDiHCjjuIZV P2mthHBqWjbAmxFFnanEVMSHIaBpsnlgyCjToZs3FMol8cSRzYPWc8yu+D7crwPRhMzJpS9u6ME jOxIiFKc+BApwz8fsUVpSZKPxQ62+5rAuQESvtbpMc0iSQyYXIUxezyaKjWbE+cR4Wx/a6YwFKg eTe7NIo3U3Nxn7zzKfVVhcnZMUANDK5fTI8woB6nZRKhSMuPbPOBy4Z+g4RgLJqsD5fk0qys4vv 3018bftgs51YLJSxg+5wWwbmNbAzvAdD+lHbL+dRqo7oPnM9g/PEPlDDgUKU8kUrvPyUyb3Cn0A Wihe1j6OUnsTNJf/nKiaR2Pw5VtDv7DYjfcj31DHSUoEDdE77BhA/a7M98zJHyurOaMINOq266H fpZbjJg6r8HZYRJrWNhac1FBUyiHxV8Kfd9BqkQ0jsr4N7xFP8enGhnMKR/pCilyk13VUEAXPFi h7ods+hGSXt3v7+VIRA== X-Proofpoint-GUID: YREb43g-PsaxK2A2XoOso8JeHLuteVfr X-Authority-Analysis: v=2.4 cv=Oot/DS/t c=1 sm=1 tr=0 ts=6a4bea8c cx=c_pps a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=uAbxVGIbfxUO_5tXvNgY:22 a=VnNF1IyMAAAA:8 a=e7tBTSZFkBJBkBhfuwgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 X-Proofpoint-ORIG-GUID: OLgCenoN545TjHnVwiJIl7PhCW6UDKbr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_02,2026-07-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 phishscore=0 malwarescore=0 suspectscore=0 spamscore=0 adultscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060180 Received-SPF: pass client-ip=148.163.156.1; envelope-from=nikhilks@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 20/05/26 21:37, Chinmay Rath wrote: > From: Ojaswin Mujoo > > Convert the following instructions to decode tree specification: > > doze > nap > sleep > rvwinkle > stop > > The functionality was tested by comparing the qemu -D log -d op,in_asm > output as well as single stepping gdb to confirm behavior was not > changed for ISA3.x (stop) as well as ISA206 (doze, nap, sleep, > rvwinkle). > > Signed-off-by: Ojaswin Mujoo > Signed-off-by: Chinmay Rath > --- > target/ppc/insn32.decode | 8 ++ > target/ppc/translate.c | 85 --------------- > .../ppc/translate/processor-ctrl-impl.c.inc | 101 ++++++++++++++++++ > 3 files changed, 109 insertions(+), 85 deletions(-) > > diff --git a/target/ppc/insn32.decode b/target/ppc/insn32.decode > index 2c002f8513..a4454a2292 100644 > --- a/target/ppc/insn32.decode > +++ b/target/ppc/insn32.decode > @@ -913,6 +913,14 @@ VPERMR 000100 ..... ..... ..... ..... 111011 @VA > > VSEL 000100 ..... ..... ..... ..... 101010 @VA > > +## Power Management Instructions > + > +DOZE 010011 ----- ----- ----- 0110010010 - > +NAP 010011 ----- ----- ----- 0110110010 - > +SLEEP 010011 ----- ----- ----- 0111010010 - > +RVWINKLE 010011 ----- ----- ----- 0111110010 - > +STOP 010011 ----- ----- ----- 0101110010 - > + > ## Vector Integer Shift Instruction > > VSLB 000100 ..... ..... ..... 00100000100 @VX > diff --git a/target/ppc/translate.c b/target/ppc/translate.c > index 4a7fa6a6a9..d1e9ab61e9 100644 > --- a/target/ppc/translate.c > +++ b/target/ppc/translate.c > @@ -2728,86 +2728,6 @@ static inline void gen_check_tlb_flush(DisasContext *ctx, bool global) { } > #endif > > #if defined(TARGET_PPC64) > -static void gen_doze(DisasContext *ctx) > -{ > -#if defined(CONFIG_USER_ONLY) > - GEN_PRIV(ctx); > -#else > - TCGv_i32 t; > - > - CHK_HV(ctx); > - translator_io_start(&ctx->base); > - t = tcg_constant_i32(PPC_PM_DOZE); > - gen_helper_pminsn(tcg_env, t); > - /* Stop translation, as the CPU is supposed to sleep from now */ > - gen_exception_nip(ctx, EXCP_HLT, ctx->base.pc_next); > -#endif /* defined(CONFIG_USER_ONLY) */ > -} > - > -static void gen_nap(DisasContext *ctx) > -{ > -#if defined(CONFIG_USER_ONLY) > - GEN_PRIV(ctx); > -#else > - TCGv_i32 t; > - > - CHK_HV(ctx); > - translator_io_start(&ctx->base); > - t = tcg_constant_i32(PPC_PM_NAP); > - gen_helper_pminsn(tcg_env, t); > - /* Stop translation, as the CPU is supposed to sleep from now */ > - gen_exception_nip(ctx, EXCP_HLT, ctx->base.pc_next); > -#endif /* defined(CONFIG_USER_ONLY) */ > -} > - > -static void gen_stop(DisasContext *ctx) > -{ > -#if defined(CONFIG_USER_ONLY) > - GEN_PRIV(ctx); > -#else > - TCGv_i32 t; > - > - CHK_HV(ctx); > - translator_io_start(&ctx->base); > - t = tcg_constant_i32(PPC_PM_STOP); > - gen_helper_pminsn(tcg_env, t); > - /* Stop translation, as the CPU is supposed to sleep from now */ > - gen_exception_nip(ctx, EXCP_HLT, ctx->base.pc_next); > -#endif /* defined(CONFIG_USER_ONLY) */ > -} > - > -static void gen_sleep(DisasContext *ctx) > -{ > -#if defined(CONFIG_USER_ONLY) > - GEN_PRIV(ctx); > -#else > - TCGv_i32 t; > - > - CHK_HV(ctx); > - translator_io_start(&ctx->base); > - t = tcg_constant_i32(PPC_PM_SLEEP); > - gen_helper_pminsn(tcg_env, t); > - /* Stop translation, as the CPU is supposed to sleep from now */ > - gen_exception_nip(ctx, EXCP_HLT, ctx->base.pc_next); > -#endif /* defined(CONFIG_USER_ONLY) */ > -} > - > -static void gen_rvwinkle(DisasContext *ctx) > -{ > -#if defined(CONFIG_USER_ONLY) > - GEN_PRIV(ctx); > -#else > - TCGv_i32 t; > - > - CHK_HV(ctx); > - translator_io_start(&ctx->base); > - t = tcg_constant_i32(PPC_PM_RVWINKLE); > - gen_helper_pminsn(tcg_env, t); > - /* Stop translation, as the CPU is supposed to sleep from now */ > - gen_exception_nip(ctx, EXCP_HLT, ctx->base.pc_next); > -#endif /* defined(CONFIG_USER_ONLY) */ > -} > - > static inline TCGv gen_write_bhrb(TCGv_ptr base, TCGv offset, TCGv mask, TCGv value) > { > TCGv_ptr tmp = tcg_temp_new_ptr(); > @@ -5141,11 +5061,6 @@ GEN_HANDLER_E(scv, 0x11, 0x10, 0xFF, 0x03FFF01E, PPC_NONE, PPC2_ISA300), > GEN_HANDLER_E(scv, 0x11, 0x00, 0xFF, 0x03FFF01E, PPC_NONE, PPC2_ISA300), > GEN_HANDLER_E(rfscv, 0x13, 0x12, 0x02, 0x03FF8001, PPC_NONE, PPC2_ISA300), > #endif > -GEN_HANDLER_E(stop, 0x13, 0x12, 0x0b, 0x03FFF801, PPC_NONE, PPC2_ISA300), > -GEN_HANDLER_E(doze, 0x13, 0x12, 0x0c, 0x03FFF801, PPC_NONE, PPC2_PM_ISA206), > -GEN_HANDLER_E(nap, 0x13, 0x12, 0x0d, 0x03FFF801, PPC_NONE, PPC2_PM_ISA206), > -GEN_HANDLER_E(sleep, 0x13, 0x12, 0x0e, 0x03FFF801, PPC_NONE, PPC2_PM_ISA206), > -GEN_HANDLER_E(rvwinkle, 0x13, 0x12, 0x0f, 0x03FFF801, PPC_NONE, PPC2_PM_ISA206), > GEN_HANDLER(hrfid, 0x13, 0x12, 0x08, 0x03FF8001, PPC_64H), > #endif > /* Top bit of opc2 corresponds with low bit of LEV, so use two handlers */ > diff --git a/target/ppc/translate/processor-ctrl-impl.c.inc b/target/ppc/translate/processor-ctrl-impl.c.inc > index 8abbb89630..bdbc195294 100644 > --- a/target/ppc/translate/processor-ctrl-impl.c.inc > +++ b/target/ppc/translate/processor-ctrl-impl.c.inc > @@ -103,3 +103,104 @@ static bool trans_MSGSYNC(DisasContext *ctx, arg_MSGSYNC *a) > /* interpreted as no-op */ > return true; > } > + > +static bool do_doze(DisasContext *ctx, arg_DOZE *a) > +{ > + REQUIRE_64BIT(ctx); > + > +#if defined(CONFIG_USER_ONLY) > + gen_priv_opc(ctx); > +#else > + TCGv_i32 t; > + > + REQUIRE_HV(ctx); > + translator_io_start(&ctx->base); > + t = tcg_constant_i32(PPC_PM_DOZE); > + gen_helper_pminsn(tcg_env, t); > + /* Stop translation, as the CPU is supposed to sleep from now */ > + gen_exception_nip(ctx, EXCP_HLT, ctx->base.pc_next); > +#endif /* defined(CONFIG_USER_ONLY) */ > + > + return true; > +} > +TRANS_FLAGS2(PM_ISA206, DOZE, do_doze); > + > +static bool do_nap(DisasContext *ctx, arg_NAP *a) > +{ > + REQUIRE_64BIT(ctx); > + > +#if defined(CONFIG_USER_ONLY) > + gen_priv_opc(ctx); > +#else > + TCGv_i32 t; > + > + REQUIRE_HV(ctx); > + translator_io_start(&ctx->base); > + t = tcg_constant_i32(PPC_PM_NAP); > + gen_helper_pminsn(tcg_env, t); > + /* Stop translation, as the CPU is supposed to sleep from now */ > + gen_exception_nip(ctx, EXCP_HLT, ctx->base.pc_next); > +#endif /* defined(CONFIG_USER_ONLY) */ > + return true; > +} > +TRANS_FLAGS2(PM_ISA206, NAP, do_nap); > + > +static bool do_sleep(DisasContext *ctx, arg_SLEEP *a) > +{ > + REQUIRE_64BIT(ctx); > + > +#if defined(CONFIG_USER_ONLY) > + gen_priv_opc(ctx); > +#else > + TCGv_i32 t; > + > + REQUIRE_HV(ctx); > + translator_io_start(&ctx->base); > + t = tcg_constant_i32(PPC_PM_SLEEP); > + gen_helper_pminsn(tcg_env, t); > + /* Stop translation, as the CPU is supposed to sleep from now */ > + gen_exception_nip(ctx, EXCP_HLT, ctx->base.pc_next); > +#endif /* defined(CONFIG_USER_ONLY) */ > + return true; > +} > +TRANS_FLAGS2(PM_ISA206, SLEEP, do_sleep); > + > +static bool do_rvwinkle(DisasContext *ctx, arg_RVWINKLE *a) > +{ > + REQUIRE_64BIT(ctx); > + > +#if defined(CONFIG_USER_ONLY) > + gen_priv_opc(ctx); > +#else > + TCGv_i32 t; > + > + REQUIRE_HV(ctx); > + translator_io_start(&ctx->base); > + t = tcg_constant_i32(PPC_PM_RVWINKLE); > + gen_helper_pminsn(tcg_env, t); > + /* Stop translation, as the CPU is supposed to sleep from now */ > + gen_exception_nip(ctx, EXCP_HLT, ctx->base.pc_next); > +#endif /* defined(CONFIG_USER_ONLY) */ > + return true; > +} > +TRANS_FLAGS2(PM_ISA206, RVWINKLE, do_rvwinkle); > + > +static bool do_stop(DisasContext *ctx, arg_STOP *a) > +{ > + REQUIRE_64BIT(ctx); > + > +#if defined(CONFIG_USER_ONLY) > + gen_priv_opc(ctx); > +#else > + TCGv_i32 t; > + > + REQUIRE_HV(ctx); > + translator_io_start(&ctx->base); > + t = tcg_constant_i32(PPC_PM_STOP); > + gen_helper_pminsn(tcg_env, t); > + /* Stop translation, as the CPU is supposed to sleep from now */ > + gen_exception_nip(ctx, EXCP_HLT, ctx->base.pc_next); > +#endif > + return true; > +} > +TRANS_FLAGS2(ISA300, STOP, do_stop); To me all these functions do_doze, do_nap, do_sleep, do_rvwinkle and do_stop seem to be identical except  for the PPC_PM_* constant passed to gen_helper_pminsn, you can eliminate over 50-60 lines  of boilerplate by creating a single shared helper function. Thanks, ~ Nikhil