Re: [PATCH v1 1/1] dts: add EAL sanity check suite

[Paul Szczepanek <paul.szczepanek@arm.com>]

On 09/12/2024 21:54, Dean Marx wrote:
> Add a test suite to replace hello_world which simply
> starts and stops a testpmd session. The user can use
> this as a sanity check to verify their configuration.
> 
> Signed-off-by: Dean Marx <dmarx@iol.unh.edu>
> ---
>  dts/tests/TestSuite_eal.py | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>  create mode 100644 dts/tests/TestSuite_eal.py
> 
> diff --git a/dts/tests/TestSuite_eal.py b/dts/tests/TestSuite_eal.py
> new file mode 100644
> index 0000000000..35660178f0
> --- /dev/null
> +++ b/dts/tests/TestSuite_eal.py
> @@ -0,0 +1,28 @@
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(c) 2024 University of New Hampshire
> +
> +"""DPDK EAL sanity check suite.
> +
> +Starts and stops a testpmd session to verify EAL parameters
> +are properly configured.
> +"""
> +
> +from framework.remote_session.testpmd_shell import TestPmdShell
> +from framework.test_suite import TestSuite, func_test
> +
> +
> +class TestEal(TestSuite):
> +    """EAL test suite. One test case, which starts and stops a testpmd session."""
> +
> +    @func_test
> +    def test_verify_eal(self) -> None:
> +        """EAL sanity test.
> +
> +        Steps:
> +            Start testpmd session and check status.
> +        Verify:
> +            The testpmd session is alive after starting.
> +        """
> +        with TestPmdShell(node=self.sut_node) as testpmd:
> +            testpmd.start()
> +            self.verify(True, "True")

Not sure the self.verify(True, "True") is needed.

Reviewed-by: Paul Szczepanek <paul.szczepanek@arm.com>