From: Ray Jui <ray.jui@broadcom.com>
To: Scott Branden <scott.branden@broadcom.com>,
Thierry Reding <thierry.reding@gmail.com>
Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>
Subject: Re: [PATCH v3] pwm: add depends, COMPILE_TEST and default y for brcm-iproc-pwm
Date: Sat, 8 Oct 2016 14:02:51 -0700 [thread overview]
Message-ID: <8b29ebaa-eaaa-2f77-6408-a476af3aaa84@broadcom.com> (raw)
In-Reply-To: <1475960045-19313-1-git-send-email-scott.branden@broadcom.com>
On 10/8/2016 1:54 PM, Scott Branden wrote:
> - Add depends on COMMON_CLK for PWM_BCM_IPROC
> - Enable COMPILE_TEST for broader compile coverage.
> - Default y for IPROC PWM driver for IPROC SoCs.
> This allows you to turn it on simply by selecting CONFIG_PWM.
>
> Signed-off-by: Scott Branden <scott.branden@broadcom.com>
> ---
> drivers/pwm/Kconfig | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
> index 80a566a..3eb1b6b 100644
> --- a/drivers/pwm/Kconfig
> +++ b/drivers/pwm/Kconfig
> @@ -76,7 +76,9 @@ config PWM_ATMEL_TCB
>
> config PWM_BCM_IPROC
> tristate "iProc PWM support"
> - depends on ARCH_BCM_IPROC
> + depends on ARCH_BCM_IPROC || COMPILE_TEST
> + depends on COMMON_CLK
> + default ARCH_BCM_IPROC
> help
> Generic PWM framework driver for Broadcom iProc PWM block. This
> block is used in Broadcom iProc SoC's.
>
Looks good to me!
Reviewed-by: Ray Jui <ray.jui@broadcom.com>
next prev parent reply other threads:[~2016-10-08 21:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-08 20:54 [PATCH v3] pwm: add depends, COMPILE_TEST and default y for brcm-iproc-pwm Scott Branden
2016-10-08 21:02 ` Ray Jui [this message]
2016-12-20 19:32 ` Scott Branden
2017-01-18 10:45 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b29ebaa-eaaa-2f77-6408-a476af3aaa84@broadcom.com \
--to=ray.jui@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=scott.branden@broadcom.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.