From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2C0DC47257 for ; Wed, 6 May 2020 09:40:06 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 788672087E for ; Wed, 6 May 2020 09:40:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="EtcPzrkg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 788672087E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 142844B258; Wed, 6 May 2020 05:40:06 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Lk3jf0ZN0dbE; Wed, 6 May 2020 05:40:05 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 00A564B219; Wed, 6 May 2020 05:40:05 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 9137A4B219 for ; Wed, 6 May 2020 05:40:03 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ramdslniIrgk for ; Wed, 6 May 2020 05:40:02 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 73BE64B216 for ; Wed, 6 May 2020 05:40:02 -0400 (EDT) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 56CAB2075E; Wed, 6 May 2020 09:40:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588758001; bh=PnheU1SB759b1ecFKgOFt4WnUTjCjzVdAEES0Im2Xtc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EtcPzrkg+dKsEn/zxiZdqfiIiMAg3jdP8w21mkGZg1GrxW7TqJqSFSW6NUYyq16jD jhC9kvc6joqytrdElp4LjrtbTnUjLDtCf6b6UTAGwZDaQULMpC479xmeoZvCDYSlQJ VPObgH6EMZ79giLTHPXYGwbJ3OnwgooE3ClKJfdk= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jWGX1-009uGa-OB; Wed, 06 May 2020 10:39:59 +0100 MIME-Version: 1.0 Date: Wed, 06 May 2020 10:39:59 +0100 From: Marc Zyngier To: Andrew Scull Subject: Re: [PATCH 05/26] arm64: Document SW reserved PTE/PMD bits in Stage-2 descriptors In-Reply-To: <20200505155916.GB237572@google.com> References: <20200422120050.3693593-1-maz@kernel.org> <20200422120050.3693593-6-maz@kernel.org> <20200505155916.GB237572@google.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <8b399c95ca1393e63cc1077ede8a45f6@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: ascull@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, will@kernel.org, andre.przywara@arm.com, Dave.Martin@arm.com, gcherian@marvell.com, prime.zeng@hisilicon.com, catalin.marinas@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: kvm@vger.kernel.org, Andre Przywara , kvmarm@lists.cs.columbia.edu, George Cherian , "Zengtao \(B\)" , Catalin Marinas , Will Deacon , Dave Martin , linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Hi Andrew, On 2020-05-05 16:59, Andrew Scull wrote: > On Wed, Apr 22, 2020 at 01:00:29PM +0100, Marc Zyngier wrote: >> Advertise bits [58:55] as reserved for SW in the S2 descriptors. >> >> Signed-off-by: Marc Zyngier >> --- >> arch/arm64/include/asm/pgtable-hwdef.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm64/include/asm/pgtable-hwdef.h >> b/arch/arm64/include/asm/pgtable-hwdef.h >> index 6bf5e650da788..7eab0d23cdb52 100644 >> --- a/arch/arm64/include/asm/pgtable-hwdef.h >> +++ b/arch/arm64/include/asm/pgtable-hwdef.h >> @@ -177,10 +177,12 @@ >> #define PTE_S2_RDONLY (_AT(pteval_t, 1) << 6) /* HAP[2:1] */ >> #define PTE_S2_RDWR (_AT(pteval_t, 3) << 6) /* HAP[2:1] */ >> #define PTE_S2_XN (_AT(pteval_t, 2) << 53) /* XN[1:0] */ >> +#define PTE_S2_SW_RESVD (_AT(pteval_t, 15) << 55) /* Reserved for SW >> */ >> >> #define PMD_S2_RDONLY (_AT(pmdval_t, 1) << 6) /* HAP[2:1] */ >> #define PMD_S2_RDWR (_AT(pmdval_t, 3) << 6) /* HAP[2:1] */ >> #define PMD_S2_XN (_AT(pmdval_t, 2) << 53) /* XN[1:0] */ >> +#define PMD_S2_SW_RESVD (_AT(pmdval_t, 15) << 55) /* Reserved for SW >> */ >> >> #define PUD_S2_RDONLY (_AT(pudval_t, 1) << 6) /* HAP[2:1] */ >> #define PUD_S2_RDWR (_AT(pudval_t, 3) << 6) /* HAP[2:1] */ >> -- >> 2.26.1 >> >> _______________________________________________ >> kvmarm mailing list >> kvmarm@lists.cs.columbia.edu >> https://lists.cs.columbia.edu/mailman/listinfo/kvmarm > > This is consistent with "Attribute fields in stage 1 VMSAv8-64 Block > and > Page descriptors" Do you mean "stage 2" instead? The reserved bits are the same, but I want to be sure we have looked at the same thing (ARM DDI 0487F.a, D5-2603). > Reviewed-by: Andrew Scull Thanks, M. -- Jazz is not dead. It just smells funny... _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AB38C47257 for ; Wed, 6 May 2020 09:40:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 19CE52075E for ; Wed, 6 May 2020 09:40:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fLniHYQ9"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="EtcPzrkg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 19CE52075E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+dfBX5rQr4ygXHsiJoy3Od8IB7gh6ZnceTTTANdT/Js=; b=fLniHYQ94HgPhrhOhG/y928RJ mS36vR7LblEH/hFIhGjJjKoQKcP8RBFp+WjxTr6cspDXi9iCVyUeuC0LiNSXs+ndXC0Gpy6ZowQEK WUrRSnagigNzYudmE9xXivy9sFCb/YnVlmE0HvujlBnn4k5ACREU4ZoNfiiudkRiKJSzhnMKZqOtn Ti8+wv41AmOY2ucCpiHWmRXZHNf6/hwKLTM+7md0kt3CsYAUFkGNFaDenHot3srolLR8iB8SmRobc Gi0mHv9LPNRZSCeJ/Qafi1jTi2D3788byP3mbEqhT9UUnUQm4z3aHwTkXprTI8YCa0lB+e9rDoVwH LkGGLvheg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWGX8-0002Gb-4F; Wed, 06 May 2020 09:40:06 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWGX3-0001Hm-V6 for linux-arm-kernel@lists.infradead.org; Wed, 06 May 2020 09:40:04 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 56CAB2075E; Wed, 6 May 2020 09:40:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588758001; bh=PnheU1SB759b1ecFKgOFt4WnUTjCjzVdAEES0Im2Xtc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EtcPzrkg+dKsEn/zxiZdqfiIiMAg3jdP8w21mkGZg1GrxW7TqJqSFSW6NUYyq16jD jhC9kvc6joqytrdElp4LjrtbTnUjLDtCf6b6UTAGwZDaQULMpC479xmeoZvCDYSlQJ VPObgH6EMZ79giLTHPXYGwbJ3OnwgooE3ClKJfdk= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jWGX1-009uGa-OB; Wed, 06 May 2020 10:39:59 +0100 MIME-Version: 1.0 Date: Wed, 06 May 2020 10:39:59 +0100 From: Marc Zyngier To: Andrew Scull Subject: Re: [PATCH 05/26] arm64: Document SW reserved PTE/PMD bits in Stage-2 descriptors In-Reply-To: <20200505155916.GB237572@google.com> References: <20200422120050.3693593-1-maz@kernel.org> <20200422120050.3693593-6-maz@kernel.org> <20200505155916.GB237572@google.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <8b399c95ca1393e63cc1077ede8a45f6@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: ascull@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, will@kernel.org, andre.przywara@arm.com, Dave.Martin@arm.com, gcherian@marvell.com, prime.zeng@hisilicon.com, catalin.marinas@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200506_024002_055034_66E90C81 X-CRM114-Status: GOOD ( 13.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, Andre Przywara , kvmarm@lists.cs.columbia.edu, George Cherian , "Zengtao \(B\)" , Catalin Marinas , Will Deacon , Dave Martin , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andrew, On 2020-05-05 16:59, Andrew Scull wrote: > On Wed, Apr 22, 2020 at 01:00:29PM +0100, Marc Zyngier wrote: >> Advertise bits [58:55] as reserved for SW in the S2 descriptors. >> >> Signed-off-by: Marc Zyngier >> --- >> arch/arm64/include/asm/pgtable-hwdef.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm64/include/asm/pgtable-hwdef.h >> b/arch/arm64/include/asm/pgtable-hwdef.h >> index 6bf5e650da788..7eab0d23cdb52 100644 >> --- a/arch/arm64/include/asm/pgtable-hwdef.h >> +++ b/arch/arm64/include/asm/pgtable-hwdef.h >> @@ -177,10 +177,12 @@ >> #define PTE_S2_RDONLY (_AT(pteval_t, 1) << 6) /* HAP[2:1] */ >> #define PTE_S2_RDWR (_AT(pteval_t, 3) << 6) /* HAP[2:1] */ >> #define PTE_S2_XN (_AT(pteval_t, 2) << 53) /* XN[1:0] */ >> +#define PTE_S2_SW_RESVD (_AT(pteval_t, 15) << 55) /* Reserved for SW >> */ >> >> #define PMD_S2_RDONLY (_AT(pmdval_t, 1) << 6) /* HAP[2:1] */ >> #define PMD_S2_RDWR (_AT(pmdval_t, 3) << 6) /* HAP[2:1] */ >> #define PMD_S2_XN (_AT(pmdval_t, 2) << 53) /* XN[1:0] */ >> +#define PMD_S2_SW_RESVD (_AT(pmdval_t, 15) << 55) /* Reserved for SW >> */ >> >> #define PUD_S2_RDONLY (_AT(pudval_t, 1) << 6) /* HAP[2:1] */ >> #define PUD_S2_RDWR (_AT(pudval_t, 3) << 6) /* HAP[2:1] */ >> -- >> 2.26.1 >> >> _______________________________________________ >> kvmarm mailing list >> kvmarm@lists.cs.columbia.edu >> https://lists.cs.columbia.edu/mailman/listinfo/kvmarm > > This is consistent with "Attribute fields in stage 1 VMSAv8-64 Block > and > Page descriptors" Do you mean "stage 2" instead? The reserved bits are the same, but I want to be sure we have looked at the same thing (ARM DDI 0487F.a, D5-2603). > Reviewed-by: Andrew Scull Thanks, M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59BF1C28CBC for ; Wed, 6 May 2020 09:40:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2F5502082E for ; Wed, 6 May 2020 09:40:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588758003; bh=PnheU1SB759b1ecFKgOFt4WnUTjCjzVdAEES0Im2Xtc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=Ab+hQUdKcyMYtJULH0h9+PqAyMNSsrJ8HvGAZHeyg15ER7d5bzqiT9aKZrJL2X3g2 GPHZRow2mDBcTsNBUMV/9vBK7dLzYT+P3wD8PqpH/TL/6JL9Rb4aEzZJEEYI29Btd7 cEScHHg2O4QmzsFPCAHKIcEK6fLageqU/G3gOVxg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729044AbgEFJkC (ORCPT ); Wed, 6 May 2020 05:40:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:44874 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728306AbgEFJkC (ORCPT ); Wed, 6 May 2020 05:40:02 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 56CAB2075E; Wed, 6 May 2020 09:40:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588758001; bh=PnheU1SB759b1ecFKgOFt4WnUTjCjzVdAEES0Im2Xtc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EtcPzrkg+dKsEn/zxiZdqfiIiMAg3jdP8w21mkGZg1GrxW7TqJqSFSW6NUYyq16jD jhC9kvc6joqytrdElp4LjrtbTnUjLDtCf6b6UTAGwZDaQULMpC479xmeoZvCDYSlQJ VPObgH6EMZ79giLTHPXYGwbJ3OnwgooE3ClKJfdk= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jWGX1-009uGa-OB; Wed, 06 May 2020 10:39:59 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 06 May 2020 10:39:59 +0100 From: Marc Zyngier To: Andrew Scull Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Will Deacon , Andre Przywara , Dave Martin , George Cherian , "Zengtao (B)" , Catalin Marinas Subject: Re: [PATCH 05/26] arm64: Document SW reserved PTE/PMD bits in Stage-2 descriptors In-Reply-To: <20200505155916.GB237572@google.com> References: <20200422120050.3693593-1-maz@kernel.org> <20200422120050.3693593-6-maz@kernel.org> <20200505155916.GB237572@google.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <8b399c95ca1393e63cc1077ede8a45f6@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: ascull@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, will@kernel.org, andre.przywara@arm.com, Dave.Martin@arm.com, gcherian@marvell.com, prime.zeng@hisilicon.com, catalin.marinas@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hi Andrew, On 2020-05-05 16:59, Andrew Scull wrote: > On Wed, Apr 22, 2020 at 01:00:29PM +0100, Marc Zyngier wrote: >> Advertise bits [58:55] as reserved for SW in the S2 descriptors. >> >> Signed-off-by: Marc Zyngier >> --- >> arch/arm64/include/asm/pgtable-hwdef.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm64/include/asm/pgtable-hwdef.h >> b/arch/arm64/include/asm/pgtable-hwdef.h >> index 6bf5e650da788..7eab0d23cdb52 100644 >> --- a/arch/arm64/include/asm/pgtable-hwdef.h >> +++ b/arch/arm64/include/asm/pgtable-hwdef.h >> @@ -177,10 +177,12 @@ >> #define PTE_S2_RDONLY (_AT(pteval_t, 1) << 6) /* HAP[2:1] */ >> #define PTE_S2_RDWR (_AT(pteval_t, 3) << 6) /* HAP[2:1] */ >> #define PTE_S2_XN (_AT(pteval_t, 2) << 53) /* XN[1:0] */ >> +#define PTE_S2_SW_RESVD (_AT(pteval_t, 15) << 55) /* Reserved for SW >> */ >> >> #define PMD_S2_RDONLY (_AT(pmdval_t, 1) << 6) /* HAP[2:1] */ >> #define PMD_S2_RDWR (_AT(pmdval_t, 3) << 6) /* HAP[2:1] */ >> #define PMD_S2_XN (_AT(pmdval_t, 2) << 53) /* XN[1:0] */ >> +#define PMD_S2_SW_RESVD (_AT(pmdval_t, 15) << 55) /* Reserved for SW >> */ >> >> #define PUD_S2_RDONLY (_AT(pudval_t, 1) << 6) /* HAP[2:1] */ >> #define PUD_S2_RDWR (_AT(pudval_t, 3) << 6) /* HAP[2:1] */ >> -- >> 2.26.1 >> >> _______________________________________________ >> kvmarm mailing list >> kvmarm@lists.cs.columbia.edu >> https://lists.cs.columbia.edu/mailman/listinfo/kvmarm > > This is consistent with "Attribute fields in stage 1 VMSAv8-64 Block > and > Page descriptors" Do you mean "stage 2" instead? The reserved bits are the same, but I want to be sure we have looked at the same thing (ARM DDI 0487F.a, D5-2603). > Reviewed-by: Andrew Scull Thanks, M. -- Jazz is not dead. It just smells funny...