Re: [i-g-t] tests/kms_colorop: Use local variable for color pipeline cap

["Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>]

On 9/1/2026 10:25 PM, Kamil Konieczny wrote:
> Hi Borah,,
> On 2026-08-28 at 15:35:29 +0530, Borah, Chaitanya Kumar wrote:
>> Hi Kamil,
>>
>> On 8/27/2026 9:06 PM, Kamil Konieczny wrote:
>>> Hi Chaitanya,
>>> On 2026-08-03 at 13:33:40 +0530, Chaitanya Kumar Borah wrote:
>>>
>>> small nit about subject, please do not use "C code to english",
>>> rather describe what you try to achive, here better:
>>>
>>> [i-g-t] tests/kms_colorop: Get cap color pipeline only once
>>>
>>
>> Noted.
>>
>> Swati, we can perhaps change this while merging if there are no further
>> changes needed.
> 
> There is one change needed so please change subject, fix source,
> add any r-b you got and resend.
> 

I thought we can avoid a CI cycle by not re-sending since it is just a 
commit message change, but I can resend.

==
Chaitanya

> Regards,
> Kamil
> 
>>
>> ==
>> Chaitanya
>>
>>> Regards,
>>> Kamil
>>>
>>>> Following the pattern in kms_color_pipeline, set
>>>> DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE once and stash the result in a
>>>> local variable, then propagate it to display->has_plane_color_pipeline
>>>> after the final igt_display_require() (which reinitializes the display
>>>> state). This avoids calling drmSetClientCap() twice.
>>>>
>>>> Cc: Swati Sharma <swati2.sharma@intel.com>
>>>> Cc: Harry Wentland <harry.wentland@amd.com>
>>>> Cc: Alex Hung <alex.hung@amd.com>
>>>> Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
>>>> ---
>>>>    tests/kms_colorop.c | 9 +++++----
>>>>    1 file changed, 5 insertions(+), 4 deletions(-)
>>>>
>>>> diff --git a/tests/kms_colorop.c b/tests/kms_colorop.c
>>>> index 16db0b8ad..d573d2ceb 100644
>>>> --- a/tests/kms_colorop.c
>>>> +++ b/tests/kms_colorop.c
>>>> @@ -406,6 +406,7 @@ int igt_main_args("d", long_options, help_str, opt_handler, NULL)
>>>>    	igt_display_t display;
>>>>    	int i, j, ret;
>>>> +	int has_plane_color_pipeline = 0;
>>>>    	igt_fixture() {
>>>>    		display.drm_fd = drm_open_driver_master(DRIVER_ANY);
>>>> @@ -417,15 +418,15 @@ int igt_main_args("d", long_options, help_str, opt_handler, NULL)
>>>>    		igt_require_f(!ret, "error setting DRM_CLIENT_CAP_WRITEBACK_CONNECTORS\n");
>>>> -		igt_display_require(&display, display.drm_fd);
>>>>    		if (drmSetClientCap(display.drm_fd, DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE, 1) == 0)
>>>> -			display.has_plane_color_pipeline = 1;
>>>> +			has_plane_color_pipeline = 1;
>>>> +
>>>> +		igt_display_require(&display, display.drm_fd);
>>>>    		kmstest_set_vt_graphics_mode();
>>>>    		igt_display_require(&display, display.drm_fd);
>>>> -		if (drmSetClientCap(display.drm_fd, DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE, 1) == 0)
>>>> -			display.has_plane_color_pipeline = 1;
>>>> +		display.has_plane_color_pipeline = has_plane_color_pipeline;
>>>>    		igt_require(display.is_atomic);
>>>>    	}
>>>> -- 
>>>> 2.50.1
>>>>
>>