All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Marco Giunta <marco_giunta@outlook.it>
Cc: tiwai@suse.com, perex@perex.cz, lgirdwood@gmail.com,
	broonie@kernel.org,  LKML <linux-kernel@vger.kernel.org>,
	linux-sound@vger.kernel.org,
	 "Rafael J. Wysocki" <rafael@kernel.org>,
	lenb@kernel.org,  Hans de Goede <hansg@kernel.org>,
	linux-acpi@vger.kernel.org,  platform-driver-x86@vger.kernel.org,
	wangweidong.a@awinic.com,  nadim@symbolic.software,
	imitoy@imitoy.top, munzirtaha@gmail.com,  yakov.till@gmail.com
Subject: Re: [PATCH 6/8] ACPI/platform: add AWDZ8399 to serial-multi-instantiate
Date: Tue, 21 Jul 2026 18:22:17 +0300 (EEST)	[thread overview]
Message-ID: <8b477bc9-f461-a242-2522-8ac87e2bb2e7@linux.intel.com> (raw)
In-Reply-To: <DS7PR19MB772444EB48828D8ED8EB3175FCC62@DS7PR19MB7724.namprd19.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 2668 bytes --]

On Fri, 17 Jul 2026, Marco Giunta wrote:

> Register the AWINIC AW88399 ACPI hardware ID "AWDZ8399" with the
> serial-multi-instantiate driver and add it to the ACPI scan ignore
> list so that the two I2C amplifier instances on Lenovo Legion laptops
> are enumerated as separate I2C client devices rather than a single
> ACPI platform device.
> 
> The SMI node creates two instances named "aw88399-hda" with
> IRQ_RESOURCE_AUTO, matching the pattern used by CS35L41.
> 
> Tested-by: Nadim Kobeissi <nadim@symbolic.software>
> Tested-by: Xia Yun'an <imitoy@imitoy.top>
> Tested-by: Munzir Taha <munzirtaha@gmail.com>
> Co-developed-by: Yakov Till <yakov.till@gmail.com>
> Signed-off-by: Yakov Till <yakov.till@gmail.com>
> Signed-off-by: Marco Giunta <marco_giunta@outlook.it>
> ---
>  drivers/acpi/scan.c                             |  1 +
>  drivers/platform/x86/serial-multi-instantiate.c | 10 ++++++++++
>  2 files changed, 11 insertions(+)
> 
> diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
> index 9a7ac2eb9ce0..4f4552b1551b 100644
> --- a/drivers/acpi/scan.c
> +++ b/drivers/acpi/scan.c
> @@ -1752,6 +1752,7 @@ static bool acpi_device_enumeration_by_parent(struct acpi_device *device)
>  	 * by the drivers/platform/x86/serial-multi-instantiate.c driver, which
>  	 * knows which client device id to use for each resource.
>  	 */
> +		{"AWDZ8399", },
>  		{"BSG1160", },
>  		{"BSG2150", },
>  		{"CSC3551", },
> diff --git a/drivers/platform/x86/serial-multi-instantiate.c b/drivers/platform/x86/serial-multi-instantiate.c
> index 1a369334f9cb..3e89fcdd45f7 100644
> --- a/drivers/platform/x86/serial-multi-instantiate.c
> +++ b/drivers/platform/x86/serial-multi-instantiate.c
> @@ -307,6 +307,15 @@ static void smi_remove(struct platform_device *pdev)
>  	smi_devs_unregister(smi);
>  }
>  
> +static const struct smi_node aw88399_hda = {
> +	.instances = {
> +		{ "aw88399-hda", IRQ_RESOURCE_AUTO, 0 },
> +		{ "aw88399-hda", IRQ_RESOURCE_AUTO, 0 },
> +		{}
> +	},
> +	.bus_type = SMI_AUTO_DETECT,
> +};
> +
>  static const struct smi_node bsg1160_data = {
>  	.instances = {
>  		{ "bmc150_accel", IRQ_RESOURCE_GPIO, 0 },
> @@ -405,6 +414,7 @@ static const struct smi_node tas2781_hda = {
>   * drivers/acpi/scan.c: acpi_device_enumeration_by_parent().
>   */
>  static const struct acpi_device_id smi_acpi_ids[] = {
> +	{ "AWDZ8399", (unsigned long)&aw88399_hda },
>  	{ "BSG1160", (unsigned long)&bsg1160_data },
>  	{ "BSG2150", (unsigned long)&bsg2150_data },
>  	{ "CSC3551", (unsigned long)&cs35l41_hda },
> 

Acked-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

-- 
 i.

  parent reply	other threads:[~2026-07-21 15:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-17 13:25 [PATCH 0/8] ALSA: hda: Add AW88399 HDA side codec driver for Lenovo Legion Marco Giunta
2026-07-17 13:25 ` [PATCH 1/8] ASoC: aw88399: extract shared device library Marco Giunta
2026-07-21 15:21   ` Ilpo Järvinen
2026-07-21 16:57     ` Mark Brown
2026-07-17 13:25 ` [PATCH 2/8] ASoC: aw88399: derive channel from I2C address on ACPI systems Marco Giunta
2026-07-17 13:25 ` [PATCH 3/8] ASoC: aw88399: add per-instance BSTS status bypass flag Marco Giunta
2026-07-17 13:25 ` [PATCH 4/8] ASoC: aw88399: add firmware reload flag for resume Marco Giunta
2026-07-17 13:25 ` [PATCH 5/8] ASoC: aw88399: add channel setter for HDA side codec Marco Giunta
2026-07-17 13:25 ` [PATCH 6/8] ACPI/platform: add AWDZ8399 to serial-multi-instantiate Marco Giunta
2026-07-21 12:13   ` Rafael J. Wysocki (Intel)
2026-07-21 15:22   ` Ilpo Järvinen [this message]
2026-07-17 13:25 ` [PATCH 7/8] ALSA: hda/scodec: add AW88399 HDA side codec driver Marco Giunta
2026-07-17 13:25 ` [PATCH 8/8] ALSA: hda/realtek: enable AW88399 on Lenovo Legion Pro Marco Giunta
2026-07-21 11:32 ` [PATCH 0/8] ALSA: hda: Add AW88399 HDA side codec driver for Lenovo Legion Takashi Iwai
2026-07-21 18:19 ` (subset) " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8b477bc9-f461-a242-2522-8ac87e2bb2e7@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=broonie@kernel.org \
    --cc=hansg@kernel.org \
    --cc=imitoy@imitoy.top \
    --cc=lenb@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=marco_giunta@outlook.it \
    --cc=munzirtaha@gmail.com \
    --cc=nadim@symbolic.software \
    --cc=perex@perex.cz \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=tiwai@suse.com \
    --cc=wangweidong.a@awinic.com \
    --cc=yakov.till@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.