From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E5B76C5475B for ; Fri, 1 Mar 2024 08:52:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gAu7YclK9K8vOh+dfIwSbMEQSLuG4W3HgEPUkbllzcU=; b=j89yX62uC7kixjr/4RFIqAYDb4 LPov/u25YztiJHYMCbHEZRFpSwjkpPYOkqUH1JcTcs8TAglBIxV2zHJCU36RlXTkfuRErMsQDneGc dDp8XxTqXaTN9h37g+f5XUQR+58tvUkjuQKbckB864YPDKn8jjspO7zFLQOZKk6Y1+CyhN2jmSCw6 vsj948FBSzbFBQWhG2uHWxM3+pNnwgU8ULlOdu6nCHLa4t+oCouPQbroPNdBAMxUriMgIeWoljfAr zInJbeR4yxIkqVOA/y4CVmv325HrcRGjdrIZQUUPVLR/vtN9rRLKX9xcris8tA7oOlHMm8wHKGeI8 UVX3SDdw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfydF-0000000H0Nf-0Zmv; Fri, 01 Mar 2024 08:52:41 +0000 Received: from mail.manjaro.org ([116.203.91.91]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfydB-0000000H0KD-1Soi; Fri, 01 Mar 2024 08:52:39 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1709283154; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HLbvrgwUZZKBHF7NvvXt4qwWmyIAaI4FWrdM6t+PElo=; b=orUcIuS7xstNMAE2D54STQMmWn3gzMFrWU0mCVp7v8cA9eEpuaqSdvrWrsQQ2Aee60Eerw gf21eR1Ap0G3tJglp2/CuNjBCBpsw2dqpeuK8BeEJO0bBigoGu6k37inPdFpJ3ZZVtuElw D1X3XRcX6eRn01R/fCmil5hxndf51F+f2/j9g/+dpjXuTNt/eGN4RbVRDD9X/fRYnHZSlp Xmilmr7rmn/HoZmnd2Sv8pbV/TalK+glKMbGthe/TlspYoVnm09U6WFgeEqVCOnV3u2GdN +y4vC8hUd5L5oyUDk7vNgkaQ1LVOJvjyJmG/FWX3kHPzPPeNoeFJAcDOrICdJA== Date: Fri, 01 Mar 2024 09:52:34 +0100 From: Dragan Simic To: Alexey Charkov Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Daniel Lezcano , Viresh Kumar , Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/5] arm64: dts: rockchip: enable built-in thermal monitoring on RK3588 In-Reply-To: References: <20240229-rk-dts-additions-v3-0-6afe8473a631@gmail.com> <20240229-rk-dts-additions-v3-1-6afe8473a631@gmail.com> Message-ID: <8b48eeac7b629c39adc6024ff418724c@manjaro.org> X-Sender: dsimic@manjaro.org Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240301_005237_721589_99D21749 X-CRM114-Status: GOOD ( 54.01 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gMjAyNC0wMy0wMSAwOToyNSwgQWxleGV5IENoYXJrb3Ygd3JvdGU6Cj4gT24gRnJpLCBNYXIg MSwgMjAyNCBhdCA5OjUx4oCvQU0gRHJhZ2FuIFNpbWljIDxkc2ltaWNAbWFuamFyby5vcmc+IHdy b3RlOgo+PiBPbiAyMDI0LTAzLTAxIDA2OjEyLCBBbGV4ZXkgQ2hhcmtvdiB3cm90ZToKPj4gPiBP biBGcmksIE1hciAxLCAyMDI0IGF0IDEyOjIx4oCvQU0gRHJhZ2FuIFNpbWljIDxkc2ltaWNAbWFu amFyby5vcmc+Cj4+ID4gd3JvdGU6Cj4+ID4+IE9uIDIwMjQtMDItMjkgMjA6MjYsIEFsZXhleSBD aGFya292IHdyb3RlOgo+PiA+PiA+IEluY2x1ZGUgdGhlcm1hbCB6b25lcyBpbmZvcm1hdGlvbiBp biBkZXZpY2UgdHJlZSBmb3IgUkszNTg4IHZhcmlhbnRzLgo+PiA+PiA+Cj4+ID4+ID4gVGhpcyBh bHNvIGVuYWJsZXMgdGhlIFRTQURDIGNvbnRyb2xsZXIgdW5jb25kaXRpb25hbGx5IG9uIGFsbCBi b2FyZHMKPj4gPj4gPiB0byBlbnN1cmUgdGhhdCB0aGVybWFsIHByb3RlY3Rpb25zIGFyZSBpbiBw bGFjZSB2aWEgdGhyb3R0bGluZyBhbmQKPj4gPj4gPiBlbWVyZ2VuY3kgcmVzZXQsIG9uY2UgT1BQ cyBhcmUgYWRkZWQgdG8gZW5hYmxlIENQVSBEVkZTLgo+PiA+PiA+Cj4+ID4+ID4gVGhlIGRlZmF1 bHQgc2V0dGluZ3MgKHVzaW5nIENSVSBhcyB0aGUgZW1lcmdlbmN5IHJlc2V0IG1lY2hhbmlzbSkK Pj4gPj4gPiBzaG91bGQgd29yayBvbiBhbGwgYm9hcmRzIHJlZ2FyZGxlc3Mgb2YgdGhlaXIgd2ly aW5nLCBhcyBDUlUgcmVzZXRzCj4+ID4+ID4gZG8gbm90IGRlcGVuZCBvbiBhbnkgZXh0ZXJuYWwg Y29tcG9uZW50cy4gQm9hcmRzIHRoYXQgaGF2ZSB0aGUgVFNIVVQKPj4gPj4gPiBzaWduYWwgd2ly ZWQgdG8gdGhlIHJlc2V0IGxpbmUgb2YgdGhlIFBNSUMgbWF5IG9wdCB0byBzd2l0Y2ggdG8gR1BJ Two+PiA+PiA+IHRzaHV0IG1vZGUgaW5zdGVhZCAocm9ja2NoaXAsaHctdHNodXQtbW9kZSA9IDwx PjspCj4+ID4+Cj4+ID4+IFF1aXRlIGZyYW5rbHksIEknbSBzdGlsbCBub3Qgc3VyZSB0aGF0IGVu YWJsaW5nIHRoaXMgb24gdGhlIFNvQyBsZXZlbAo+PiA+PiBpcyB0aGUgd2F5IHRvIGdvLiAgQXMg SSBhbHJlYWR5IGRlc2NyaWJlZCBpbiBkZXRhaWwsIFs0XSBhY2NvcmRpbmcgdG8KPj4gPj4gdGhl IFJLMzU4OCBIYXJkd2FyZSBEZXNpZ24gR3VpZGUgdjEuMCBhbmQgdGhlIFJvY2sgNUIgc2NoZW1h dGljLCB3ZQo+PiA+PiBzaG91bGQgYWN0dWFsbHkgdXNlIEdQSU8tYmFzZWQgaGFuZGxpbmcgZm9y IHRoZSB0aGVybWFsIHJ1bmF3YXlzIG9uCj4+ID4+IHRoZSBSb2NrIDVCLiAgT3RoZXIgYm9hcmRz IHNob3VsZCBhbHNvIGJlIGludmVzdGlnYXRlZCBpbmRpdmlkdWFsbHksCj4+ID4+IGFuZCB0aGUg VFNBREMgc2hvdWxkIGJlIGVuYWJsZWQgb24gYSBib2FyZC10by1ib2FyZCBiYXNpcy4KPj4gPgo+ PiA+IFdpdGggYWxsIGR1ZSByZXNwZWN0LCBJIGRpc2FncmVlLCBoZXJlIGlzIHdoeToKPj4gPiAg LSBOZWl0aGVyIHRoZSBzY2hlbWF0aWMgbm9yIHRoZSBoYXJkd2FyZSBkZXNpZ24gZ3VpZGUsIG9u IHdoaWNoIHRoZQo+PiA+IHNjaGVtYXRpYyBzZWVtcyB0byBiZSBiYXNlZCwgcHJlc2NyaWJlcyBh IHBhcnRpY3VsYXIgd2F5IHRvIGhhbmRsZQo+PiA+IHRoZXJtYWwgcnVuYXdheXMuIFRoZXkgb25s eSBwcm92aWRlIHRoZSBwb3NzaWJpbGl0eSBvZiBHUElPIGJhc2VkCj4+ID4gcmVzZXRzLCBhbG9u ZyB3aXRoIHRoZSBDUlUgYmFzZWQgb25lCj4+IAo+PiBQbGVhc2Ugbm90ZSB0aGF0IG90aGVyIGRv Y3VtZW50cyBmcm9tIFJvY2tjaGlwIGFsc28gZXhpc3QuICBCZWxvdyBpcwo+PiBhIGxpbmsgdG8g YSBzY3JlZW5zaG90IGZyb20gdGhlIFRoZXJtYWwgZGV2ZWxvcGVyIGd1aWRlLCB2ZXJzaW9uIDEu MCwKPj4gd2hpY2ggZGVzY3JpYmVzIHRoZSB3aG9sZSB0aGluZyBmdXJ0aGVyLiAgSSBiZWxpZXZl IGl0J3Mgb2J2aW91cyB0aGF0Cj4+IHRoZSB0aGVybWFsIHJ1bmF3YXkgaXMgdG8gYmUgdHJlYXRl ZCBhcyBhIGJvYXJkLWxldmVsIGZlYXR1cmUuCj4+IAo+PiAtIGh0dHBzOi8vaS5pbWd1ci5jb20v SUo2ZFNBYy5wbmcKPiAKPiBGcmFua2x5LCB0aGF0IHN0aWxsIGRvZXNuJ3QgbWFrZSBUU0FEQyBw ZXIgc2UgYSBib2FyZC1sZXZlbCB0aGluZyBJTU8uCj4gVGhlIG9ubHkgdGhpbmcgdGhhdCBpcyBi b2FyZC1sZXZlbCBpcyB0aGUgd2lyaW5nIG9mIEdQSU8gYmFzZWQgcmVzZXRzLAo+IHdoaWNoIEkg ZnVsbHkgYWdyZWUgc2hvdWxkIGdvIHRvIGJvYXJkIC5kdHMgZm9yIGJvYXJkcyB0aGF0IHN1cHBv cnQKPiBpdCwgYnV0IHRoYXQncyBub3QgcGFydCBvZiB0aGUgY3VycmVudCBkZWZhdWx0cyBhbmQg Y2FuIGJlIHNhZmVseQo+IGFkZGVkIGxhdGVyLgo+IAo+IFRTQURDIGlzIGluc2lkZSB0aGUgU29D LiBDUlUgaXMgaW5zaWRlIHRoZSBTb0MuIFRoZXkgd29yayBqdXN0IGZpbmUKPiBmb3IgYSB0aGVy bWFsIHJlc2V0LCBldmVuIGlmIG5vIGRlZGljYXRlZCByZXNldCBsb2dpYyBpcyB3aXJlZCBvbiB0 aGUKPiBib2FyZC4gSSByZWFsbHkgZG9uJ3Qgc2VlIGFueSBkb3duc2lkZXMgaW4gaGF2aW5nIFRT QURDIGVuYWJsZWQgYnkKPiBkZWZhdWx0IHdpdGggQ1JVIGJhc2VkIHJlc2V0czoKPiAtIGl0J3Mg YSBzYWZlIGRlZmF1bHQgKGkuZS4gSSBjYW5ub3QgdGhpbmsgb2YgYW55IGNvbmZpZ3VyYXRpb24g b3IgdXNlCj4gY2FzZSB3aGVyZSBlbmFibGVkLWJ5LWRlZmF1bHQgVFNBREMgZG9lcyBhbnkgaGFy bSkKPiAtIGl0J3Mgc2FmZXIgdGhhbiBhY2NpZGVudGFsbHkgZm9yZ2V0dGluZyB0byBlbmFibGUg VFNBREMgKGFzIGl0IGFkZHMKPiB0aGVybWFsIHByb3RlY3Rpb24gd2hpY2ggaXMgb3RoZXJ3aXNl IG1pc3NpbmcpCj4gLSBpdCB3aWxsIHdvcmsgb24gYWxsIGJvYXJkcyAoZXZlbiBpZiBpdCBkb2Vz bid0IHV0aWxpemUgdGhlIGZ1bGwKPiBoYXJkd2FyZSBmdW5jdGlvbmFsaXR5IGJ5IGlnbm9yaW5n IEdQSU8gcmVzZXRzIHRoYXQgc29tZSBib2FyZHMgYWxzbwo+IGhhdmUgaW4gYWRkaXRpb24gdG8g dGhlIENSVSkKPiAtIGFuZCBpdCByZXF1aXJlcyBmZXdlciBvdmVycmlkZXMgaW4gYm9hcmQgLmR0 cyBmaWxlcwo+IAo+IFNvdW5kcyBsaWtlIGEgbm8tcmVncmV0IG1vdmUgdG8gbWUuCgpQbGVhc2Ug c2VlIG15IGNvbW1lbnRzIGJlbG93LgoKPj4gVG8gYmUgZmFpciwgdGhhdCB2ZXJzaW9uIG9mIHRo ZSBUaGVybWFsIGRldmVsb3BlciBndWlkZSBkYXRlcyBiYWNrIHRvCj4+IDIwMTksIG1lYW5pbmcg dGhhdCBpdCB0ZWNobmljYWxseSBhcHBsaWVzIHRvIHRoZSBSSzMzOTksIGZvciBleGFtcGxlLAo+ PiBidXQgdGhlIFRTQURDIGFuZCByZXNldCBjaXJjdWl0cnkgZGVzaWduIGhhcyBiYXNpY2FsbHkg cmVtYWluZWQgdGhlCj4+IHNhbWUgZm9yIHRoZSBSSzM1ODguCj4+IAo+PiA+ICAtIE15IHN0cm9u ZyBiZWxpZWYgaXMgdGhhdCBkZWZhdWx0cyAocmVnYXJkbGVzcyBvZiBjb250ZXh0KSBzaG91bGQg YmUKPj4gPiBzYWZlIGFuZCByZWFzb25hYmxlLCBhbmQgc2hvdWxkIGFsc28gbWluaW1pemUgdGhl IG5lZWQgdG8gb3ZlcnJpZGUKPj4gPiB0aGVtCj4+IAo+PiBQbGVhc2Ugbm90ZSB0aGF0IHRoZSBU U0FEQyBpcyBkaXNhYmxlZCBpbiB0aGUgUkszMzk5IFNvQyBkdHNpLCBzbyAKPj4gaGF2aW5nCj4+ IGl0IGRpc2FibGVkIGluIHRoZSBSSzM1ODgocykgU29DIGR0c2kgd291bGQgcHJvdmlkZSBzb21l IGNvbnNpc3RlbmN5Lgo+IAo+IEknbSBoYXBweSB0byBwcm9kdWNlIGEgcGF0Y2ggdG8gcmV2ZXJz ZSB0aGUgbG9naWMgaW4gUkszMzk5IChhbmQgYW55Cj4gb3RoZXJzIGZvciB0aGF0IG1hdHRlcikg dG8gYWxzbyBoYXZlIFRTQURDIGVuYWJsZWQgYnkgZGVmYXVsdCB0aGVyZSwKPiB0aHVzIHNhdmlu ZyBzZXZlcmFsIGxpbmVzIG9mIGNvZGUsIGlmIGl0J3MganVzdCBhYm91dCBjb25zaXN0ZW5jeS4K CkJ1dCB3aHkgc2hvdWxkIHdlIGNoYW5nZSBzb21ldGhpbmcgdGhhdCBoYXMgc2VydmVkIHVzIGZv ciB5ZWFycywgb24KbXVsdGlwbGUgU29Dcywgd2l0aCB6ZXJvIHRyb3VibGVzIGFuZCB3aXRoIChB RkFJSykgemVybyBib2FyZHMgcHJvZHVjaW5nCnB1ZmZzIG9mIGJsdWlzaCBzbW9rZT8KCj4+IFRo b3VnaCwgdGhlIFJLMzM5OSBzdGlsbCBkb2VzIGl0IGluIGEgc2FmZSB3YXksIGJ5IG1vdmluZyB0 aGUgT1BQcyAKPj4gaW50bwo+PiBhIHNlcGFyYXRlIGR0c2kgZmlsZSwgbmFtZWQgcmszMzk5LW9w cC5kdHNpLCB3aGljaCB0aGUgYm9hcmQgZHRzIGZpbGVzCj4+IHRoZW4gaW5jbHVkZSB0b2dldGhl ciB3aXRoIGVuYWJsaW5nIHRoZSBUU0FEQy4KPj4gCj4+IElmIHlvdSBhZ3JlZSwgbGV0J3MgZW1w bG95IHRoZSBzYW1lIGFwcHJvYWNoIGZvciB0aGUgUkszNTg4KHMpLCBieQo+PiBoYXZpbmcKPj4g dGhlIGl0cyBPUFBzIGRlZmluZWQgaW4gYSBzZXBhcmF0ZSBmaWxlLCBuYW1lZCByazM1ODhzLW9w cC5kdHNpLCBldGMuCj4gCj4gU2VwYXJhdGUgZmlsZSBmb3IgT1BQcyBpcyBhIGdvb2Qgbm8tcmVn cmV0IG1vdmUgdG8gZGVjbHV0dGVyIHRoZSBTb0MKPiBsZXZlbCAuZHRzaSAoYXMgdGhlIE9QUCB0 YWJsZSBpcyBsb25nIGFuZCBib3JpbmcpIC0gaGFwcHkgdG8gbW92ZSBpdAo+IHJlZ2FyZGxlc3Mg b2YgdGhlIG91dGNvbWUgb2YgdGhlIGFib3ZlIFRTQURDIGRpc2N1c3Npb24uIFRoYW5rcyBmb3IK PiB0aGUgcG9pbnRlciEKClllYWgsIGJ1dCBJJ20gbm90IHN1cmUgdGhhdCBldmVyeW9uZSB3b3Vs ZCBsaWtlIHRoYXQga2luZCBvZiBzZXBhcmF0aW9uLgpJbiBmYWN0LCBzdWNoIHNlcGFyYXRpb24g bWF5IGJlIGZyb3duZWQgdXBvbiB1bmxlc3MgaXQncyBuZWNlc3NhcnkuCgpBcyBJIGFscmVhZHkg ZGVzY3JpYmVkIGluIGFub3RoZXIgdGhyZWFkLCB0aGUgc2VwYXJhdGlvbiBmb3IgdGhlIFJLMzM5 OQppcyB0aGVyZSBvbmx5IGJlY2F1c2UgYSBjb3VwbGUgb2YgZGlmZmVyZW50IHZhcmlhbnRzIG9m IHRoZSBSSzMzOTkgU29DCnJlcXVpcmUgZGlmZmVyZW50IE9QUHMuCgo+PiA+ICAtIEluIGNvbnRl eHQgb2YgZHRzL2R0c2ksIGFzIGZhciBhcyBJIHVuZGVyc3RhbmQgdGhlIGdlbmVyYWwgbG9naWMK Pj4gPiBiZWhpbmQgdGhlIHNwbGl0LCB0aGUgU29DIC5kdHNpIHNob3VsZCBjb250YWluIGFsbCB0 aGUgdGhpbmdzIHRoYXQgYXJlCj4+ID4gZnVsbHkgY29udGFpbmVkIHdpdGhpbiB0aGUgU29DIGFu ZCBkbyBub3QgZGVwZW5kIG9uIHRoZSB3aXJpbmcgb2YgYQo+PiA+IHBhcnRpY3VsYXIgYm9hcmQg b3IgaXRzIHRhcmdldCB1c2UgY2FzZS4gQm9hcmRzIHRoZW4KPj4gPiBhZGQvcmVtb3ZlL292ZXJy aWRlIHNldHRpbmdzIHRvIG1hdGNoIHRoZWlyIHdpcmluZyBhbmQgdXNlIGNhc2UgbW9yZQo+PiA+ IGNsb3NlbHkKPj4gCj4+IE9mIGNvdXJzZSwgYnV0IHRoZSB0aGVybWFsIHNodXRkb3duIGlzIG9i dmlvdXNseSBhIGJvYXJkLWxldmVsIAo+PiBmZWF0dXJlLAo+PiB3aGljaCBJIGRlc2NyaWJlZCBm dXJ0aGVyIGFib3ZlLgo+IAo+IE5vdCBzbyBvYnZpb3VzIHRvIG1lIDotKSBJIGRvbid0IG1lYW4g dG8gYmUgc3R1YmJvcm4gb3IgdW5jb29wZXJhdGl2ZQo+IGhlcmUsIGJ1dCBJIHJlYWxseSBjYW4n dCBmaW5kIGFueSB0ZWNobmljYWwgbWVyaXQgaW4gaGF2aW5nIGl0IGVuYWJsZWQKPiBhdCBib2Fy ZCBsZXZlbCBpbnN0ZWFkIG9mIFNvQyBsZXZlbC4KCldlbGwsIHBsZWFzZSBhbHNvIGNvbnNpZGVy IHRoYXQgdGhlIFBNSUNzIGZyb20gUm9ja2NoaXAgYXJlIGtpbmQgb2YKd2VpcmQgbGl0dGxlIGNo aXBzLCBzcGVjaWZpY2FsbHkgY3VzdG9taXplZCB0byBzZXJ2ZSBwYXJ0aWN1bGFyIFNvQ3MuCkZv ciBleGFtcGxlLCB0aGV5IGVuc3VyZSB0aGUgcmlnaHQgc2VxdWVuY2luZyBhbmQgcmFtcGluZy11 cCBvZiAKZGlmZmVyZW50CnBvd2VyIHJhaWxzLCB3aGljaCBpcyBpbiBtYW55IGNhc2VzIGVzc2Vu dGlhbC4KClRodXMsIHdobyBrbm93cyB3aGF0IG1pZ2h0IChvciBtaWdodCBub3QpIGdvIHdyb25n IGlmIHdlIGRvbid0IHJlc2V0IHRoZQpQTUlDIGF0IHRoZSBzYW1lIHRpbWUgd2hlbiB0aGUgQ1JV IHJlc2V0cyB0aGUgU29DPyAgVW5mb3J0dW5hdGVseSwgdGhlCnRoaW5ncyBhcmVuJ3QgdGhhdCBz dHJhaWdodGZvcndhcmQuCgpPbiB0b3Agb2YgdGhhdCwgc29tZSBib2FyZHMsIHN1Y2ggYXMgdGhl IFJvY2sgNUIsIHVzZSBhIGZldyBhZGRpdGlvbmFsCmRpc2NyZXRlIHZvbHRhZ2UgcmVndWxhdG9y cyBpbnN0ZWFkIG9mIGEgbWFzdGVyLXNsYXZlIFBNSUMgCmNvbmZpZ3VyYXRpb24sCndoaWNoIG1h eSBhY3R1YWxseSBpbnRyb2R1Y2Ugc29tZSB3ZWlyZCBwb3dlci1yZWxhdGVkIGlzc3Vlcywgd2hp Y2ggYWxzbwptYXkgYmUgaW50ZXJtaXR0ZW50LiAgQWN0dWFsbHksIEkndmUgYWxyZWFkeSBvdmVy aGVhcmQgdGhhdCB0aGUgUm9jayA1QgpleHBlcmllbmNlcyBzb21lIGlzc3VlcyBvZiB0aGF0IG5h dHVyZSwgYnV0IEkgZG9uJ3Qga25vdyB0aGUgZGV0YWlscy4KCj4gU3dpdGNoaW5nIHRvIFBNSUMt YXNzaXN0ZWQgcmVzZXRzIGlzIG9uZSB0aGluZyAtIGl0IGRlZmluaXRlbHkgc2hvdWxkCj4gZ28g dG8gYm9hcmQgZmlsZXMsIGFzIGl0IGRlcGVuZHMgb24gdGhlIHNwZWNpZmljIHdpcmluZyBvZiB0 aGUKPiBUU0FEQ19TSFVUIHNpZ25hbC4gRW5hYmxpbmcgVFNBREMgaW4gYSBkZWZhdWx0IGNvbmZp Z3VyYXRpb24gdGhhdCBjYW4KPiBhbmQgd2lsbCB3b3JrIG9uIGFsbCBib2FyZHMgcmVnYXJkbGVz cyBvZiB0aGVpciB3aXJpbmcgaXMgYW5vdGhlcgo+IHRoaW5nLiBJJ20ganVzdCBhcmd1aW5nIGZv ciB0aGUgbGF0dGVyLgoKQ1JVLWJhc2VkIHRoZXJtYWwgcnVuYXdheSBoYW5kbGluZyBtYXkgaW4g dGhlb3J5IHdvcmsgb24gYWxsIGJvYXJkcywgYnV0CndlIHNpbXBseSBjYW4ndCBiZSAxMDAlIHN1 cmUgd2l0aG91dCBkZXRhaWxlZCBpbnNpZ2h0cyBpbnRvIHRoZSBib2FyZApkZXNpZ25zIGFuZCB0 ZXN0aW5nLiAgTWF5YmUgZXZlbiB0aGUgZG93bnN0cmVhbSBVLUJvb3QgZG9lcyBzb21lIG1hZ2lj CmR1cmluZyBzdWNoIHRoZXJtYWwgcnVuYXdheSByZXNldHMsIHdoaWNoIHdlIGRvbid0IGtub3cu ICBJdCBtYXkgYmUKc2ltaWxhciB0byB0aGUgU29DIHJlc2V0IGlzc3VlcyB0aGF0IHRoZSBSSzMz OTkgc3VmZmVycyBmcm9tLgoKU2VlIGFsc28gbXkgY29tbWVudCBhYm92ZS4KCj4gVG8gbWUgaXQg c2VlbXMgc2ltaWxhciB0byB0aGUgd2F0Y2hkb2cgdGltZXIgc2l0dWF0aW9uOiB3ZSBlbmFibGUg aXQKPiBhdCB0aGUgU29DIGxldmVsIFsxXSwgYXMgaXQgaXMgZXhwZWN0ZWQgdG8gd29yayBpbiBp dHMgZGVmYXVsdAo+IGNvbmZpZ3VyYXRpb24gcmVnYXJkbGVzcyBvZiB0aGUgYm9hcmQgd2lyaW5n LCBhbmQgaXQgcHJvdmlkZXMKPiBwcm90ZWN0aW9uIGFnYWluc3Qgc3lzdGVtIG1hbGZ1bmN0aW9u cy4gRG9lc24ndCBtYXR0ZXIgaWYgdGhlIGJvYXJkIG9yCj4gaXRzIHVzZXJzcGFjZSBjb2RlIGVu ZHMgdXAgdXNpbmcgdGhlIGZ1bGwgZnVuY3Rpb25hbGl0eSAtIGl0IGp1c3Qgc2l0cwo+IHRoZXJl IHdhaXRpbmcgZm9yIGl0cyBzcG90bGlnaHQgd2l0aG91dCBodXJ0aW5nIGFueWJvZHkuCgpGcmFu a2x5LCBJIGRvbid0IGtub3cgbXVjaCBhYm91dCB0aGUgd2F0Y2hkb2cgZnVuY3Rpb25hbGl0eSwg c28gSSdkIG5lZWQKdG8gcmVzZWFyY2ggaXQgYmVmb3JlIEkgY291bGQgc2F5IHNvbWV0aGluZyBh Ym91dCBpdC4KCj4gWzFdIAo+IGh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9r ZXJuZWwvZ2l0L3RvcnZhbGRzL2xpbnV4LmdpdC90cmVlL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9j a2NoaXAvcmszNTg4cy5kdHNpI24xODcyCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgtcm9ja2No aXBAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LXJvY2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17BACC5478C for ; Fri, 1 Mar 2024 08:52:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=drW14sJMcCpVOiRG/oYpklKGM9fSRt2/pH3pDrrpgsg=; b=Ck7f2RKAYSV5oGr3SXX3vVpE0q G2Hqia2DKdT9rvioatXb+eprqOjUw00b9ZDgGVvkwxHZDxJcTzL1QtkqT7fRpKrdn8+iF+lac7CYf p9Ys8ScmZBpAZ7Bq5syoSxfQBpnFD1dkNbC0L2QyKHVFNG0r9s2VaiVq2xUR5y09Z3r26crqKYoyZ xNgCQLaiVo7WYw2sk00DKrwnJfXezd6aLr7ILIIwCj6ujKFdOx5uRwMN5MdwvaGQ/sJYWn4WNWAl0 wTHjJoF988oHm6WMBZ1YKHbM2XFLInWtsb8T+wKAAudKUkpubA1iVz+8qsvj1FSCgUQkzIxfr+CrB tpGGzEew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfydE-0000000H0Mg-0DHi; Fri, 01 Mar 2024 08:52:40 +0000 Received: from mail.manjaro.org ([116.203.91.91]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfydB-0000000H0KD-1Soi; Fri, 01 Mar 2024 08:52:39 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1709283154; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HLbvrgwUZZKBHF7NvvXt4qwWmyIAaI4FWrdM6t+PElo=; b=orUcIuS7xstNMAE2D54STQMmWn3gzMFrWU0mCVp7v8cA9eEpuaqSdvrWrsQQ2Aee60Eerw gf21eR1Ap0G3tJglp2/CuNjBCBpsw2dqpeuK8BeEJO0bBigoGu6k37inPdFpJ3ZZVtuElw D1X3XRcX6eRn01R/fCmil5hxndf51F+f2/j9g/+dpjXuTNt/eGN4RbVRDD9X/fRYnHZSlp Xmilmr7rmn/HoZmnd2Sv8pbV/TalK+glKMbGthe/TlspYoVnm09U6WFgeEqVCOnV3u2GdN +y4vC8hUd5L5oyUDk7vNgkaQ1LVOJvjyJmG/FWX3kHPzPPeNoeFJAcDOrICdJA== Date: Fri, 01 Mar 2024 09:52:34 +0100 From: Dragan Simic To: Alexey Charkov Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Daniel Lezcano , Viresh Kumar , Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/5] arm64: dts: rockchip: enable built-in thermal monitoring on RK3588 In-Reply-To: References: <20240229-rk-dts-additions-v3-0-6afe8473a631@gmail.com> <20240229-rk-dts-additions-v3-1-6afe8473a631@gmail.com> Message-ID: <8b48eeac7b629c39adc6024ff418724c@manjaro.org> X-Sender: dsimic@manjaro.org Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240301_005237_721589_99D21749 X-CRM114-Status: GOOD ( 54.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyNC0wMy0wMSAwOToyNSwgQWxleGV5IENoYXJrb3Ygd3JvdGU6Cj4gT24gRnJpLCBNYXIg MSwgMjAyNCBhdCA5OjUx4oCvQU0gRHJhZ2FuIFNpbWljIDxkc2ltaWNAbWFuamFyby5vcmc+IHdy b3RlOgo+PiBPbiAyMDI0LTAzLTAxIDA2OjEyLCBBbGV4ZXkgQ2hhcmtvdiB3cm90ZToKPj4gPiBP biBGcmksIE1hciAxLCAyMDI0IGF0IDEyOjIx4oCvQU0gRHJhZ2FuIFNpbWljIDxkc2ltaWNAbWFu amFyby5vcmc+Cj4+ID4gd3JvdGU6Cj4+ID4+IE9uIDIwMjQtMDItMjkgMjA6MjYsIEFsZXhleSBD aGFya292IHdyb3RlOgo+PiA+PiA+IEluY2x1ZGUgdGhlcm1hbCB6b25lcyBpbmZvcm1hdGlvbiBp biBkZXZpY2UgdHJlZSBmb3IgUkszNTg4IHZhcmlhbnRzLgo+PiA+PiA+Cj4+ID4+ID4gVGhpcyBh bHNvIGVuYWJsZXMgdGhlIFRTQURDIGNvbnRyb2xsZXIgdW5jb25kaXRpb25hbGx5IG9uIGFsbCBi b2FyZHMKPj4gPj4gPiB0byBlbnN1cmUgdGhhdCB0aGVybWFsIHByb3RlY3Rpb25zIGFyZSBpbiBw bGFjZSB2aWEgdGhyb3R0bGluZyBhbmQKPj4gPj4gPiBlbWVyZ2VuY3kgcmVzZXQsIG9uY2UgT1BQ cyBhcmUgYWRkZWQgdG8gZW5hYmxlIENQVSBEVkZTLgo+PiA+PiA+Cj4+ID4+ID4gVGhlIGRlZmF1 bHQgc2V0dGluZ3MgKHVzaW5nIENSVSBhcyB0aGUgZW1lcmdlbmN5IHJlc2V0IG1lY2hhbmlzbSkK Pj4gPj4gPiBzaG91bGQgd29yayBvbiBhbGwgYm9hcmRzIHJlZ2FyZGxlc3Mgb2YgdGhlaXIgd2ly aW5nLCBhcyBDUlUgcmVzZXRzCj4+ID4+ID4gZG8gbm90IGRlcGVuZCBvbiBhbnkgZXh0ZXJuYWwg Y29tcG9uZW50cy4gQm9hcmRzIHRoYXQgaGF2ZSB0aGUgVFNIVVQKPj4gPj4gPiBzaWduYWwgd2ly ZWQgdG8gdGhlIHJlc2V0IGxpbmUgb2YgdGhlIFBNSUMgbWF5IG9wdCB0byBzd2l0Y2ggdG8gR1BJ Two+PiA+PiA+IHRzaHV0IG1vZGUgaW5zdGVhZCAocm9ja2NoaXAsaHctdHNodXQtbW9kZSA9IDwx PjspCj4+ID4+Cj4+ID4+IFF1aXRlIGZyYW5rbHksIEknbSBzdGlsbCBub3Qgc3VyZSB0aGF0IGVu YWJsaW5nIHRoaXMgb24gdGhlIFNvQyBsZXZlbAo+PiA+PiBpcyB0aGUgd2F5IHRvIGdvLiAgQXMg SSBhbHJlYWR5IGRlc2NyaWJlZCBpbiBkZXRhaWwsIFs0XSBhY2NvcmRpbmcgdG8KPj4gPj4gdGhl IFJLMzU4OCBIYXJkd2FyZSBEZXNpZ24gR3VpZGUgdjEuMCBhbmQgdGhlIFJvY2sgNUIgc2NoZW1h dGljLCB3ZQo+PiA+PiBzaG91bGQgYWN0dWFsbHkgdXNlIEdQSU8tYmFzZWQgaGFuZGxpbmcgZm9y IHRoZSB0aGVybWFsIHJ1bmF3YXlzIG9uCj4+ID4+IHRoZSBSb2NrIDVCLiAgT3RoZXIgYm9hcmRz IHNob3VsZCBhbHNvIGJlIGludmVzdGlnYXRlZCBpbmRpdmlkdWFsbHksCj4+ID4+IGFuZCB0aGUg VFNBREMgc2hvdWxkIGJlIGVuYWJsZWQgb24gYSBib2FyZC10by1ib2FyZCBiYXNpcy4KPj4gPgo+ PiA+IFdpdGggYWxsIGR1ZSByZXNwZWN0LCBJIGRpc2FncmVlLCBoZXJlIGlzIHdoeToKPj4gPiAg LSBOZWl0aGVyIHRoZSBzY2hlbWF0aWMgbm9yIHRoZSBoYXJkd2FyZSBkZXNpZ24gZ3VpZGUsIG9u IHdoaWNoIHRoZQo+PiA+IHNjaGVtYXRpYyBzZWVtcyB0byBiZSBiYXNlZCwgcHJlc2NyaWJlcyBh IHBhcnRpY3VsYXIgd2F5IHRvIGhhbmRsZQo+PiA+IHRoZXJtYWwgcnVuYXdheXMuIFRoZXkgb25s eSBwcm92aWRlIHRoZSBwb3NzaWJpbGl0eSBvZiBHUElPIGJhc2VkCj4+ID4gcmVzZXRzLCBhbG9u ZyB3aXRoIHRoZSBDUlUgYmFzZWQgb25lCj4+IAo+PiBQbGVhc2Ugbm90ZSB0aGF0IG90aGVyIGRv Y3VtZW50cyBmcm9tIFJvY2tjaGlwIGFsc28gZXhpc3QuICBCZWxvdyBpcwo+PiBhIGxpbmsgdG8g YSBzY3JlZW5zaG90IGZyb20gdGhlIFRoZXJtYWwgZGV2ZWxvcGVyIGd1aWRlLCB2ZXJzaW9uIDEu MCwKPj4gd2hpY2ggZGVzY3JpYmVzIHRoZSB3aG9sZSB0aGluZyBmdXJ0aGVyLiAgSSBiZWxpZXZl IGl0J3Mgb2J2aW91cyB0aGF0Cj4+IHRoZSB0aGVybWFsIHJ1bmF3YXkgaXMgdG8gYmUgdHJlYXRl ZCBhcyBhIGJvYXJkLWxldmVsIGZlYXR1cmUuCj4+IAo+PiAtIGh0dHBzOi8vaS5pbWd1ci5jb20v SUo2ZFNBYy5wbmcKPiAKPiBGcmFua2x5LCB0aGF0IHN0aWxsIGRvZXNuJ3QgbWFrZSBUU0FEQyBw ZXIgc2UgYSBib2FyZC1sZXZlbCB0aGluZyBJTU8uCj4gVGhlIG9ubHkgdGhpbmcgdGhhdCBpcyBi b2FyZC1sZXZlbCBpcyB0aGUgd2lyaW5nIG9mIEdQSU8gYmFzZWQgcmVzZXRzLAo+IHdoaWNoIEkg ZnVsbHkgYWdyZWUgc2hvdWxkIGdvIHRvIGJvYXJkIC5kdHMgZm9yIGJvYXJkcyB0aGF0IHN1cHBv cnQKPiBpdCwgYnV0IHRoYXQncyBub3QgcGFydCBvZiB0aGUgY3VycmVudCBkZWZhdWx0cyBhbmQg Y2FuIGJlIHNhZmVseQo+IGFkZGVkIGxhdGVyLgo+IAo+IFRTQURDIGlzIGluc2lkZSB0aGUgU29D LiBDUlUgaXMgaW5zaWRlIHRoZSBTb0MuIFRoZXkgd29yayBqdXN0IGZpbmUKPiBmb3IgYSB0aGVy bWFsIHJlc2V0LCBldmVuIGlmIG5vIGRlZGljYXRlZCByZXNldCBsb2dpYyBpcyB3aXJlZCBvbiB0 aGUKPiBib2FyZC4gSSByZWFsbHkgZG9uJ3Qgc2VlIGFueSBkb3duc2lkZXMgaW4gaGF2aW5nIFRT QURDIGVuYWJsZWQgYnkKPiBkZWZhdWx0IHdpdGggQ1JVIGJhc2VkIHJlc2V0czoKPiAtIGl0J3Mg YSBzYWZlIGRlZmF1bHQgKGkuZS4gSSBjYW5ub3QgdGhpbmsgb2YgYW55IGNvbmZpZ3VyYXRpb24g b3IgdXNlCj4gY2FzZSB3aGVyZSBlbmFibGVkLWJ5LWRlZmF1bHQgVFNBREMgZG9lcyBhbnkgaGFy bSkKPiAtIGl0J3Mgc2FmZXIgdGhhbiBhY2NpZGVudGFsbHkgZm9yZ2V0dGluZyB0byBlbmFibGUg VFNBREMgKGFzIGl0IGFkZHMKPiB0aGVybWFsIHByb3RlY3Rpb24gd2hpY2ggaXMgb3RoZXJ3aXNl IG1pc3NpbmcpCj4gLSBpdCB3aWxsIHdvcmsgb24gYWxsIGJvYXJkcyAoZXZlbiBpZiBpdCBkb2Vz bid0IHV0aWxpemUgdGhlIGZ1bGwKPiBoYXJkd2FyZSBmdW5jdGlvbmFsaXR5IGJ5IGlnbm9yaW5n IEdQSU8gcmVzZXRzIHRoYXQgc29tZSBib2FyZHMgYWxzbwo+IGhhdmUgaW4gYWRkaXRpb24gdG8g dGhlIENSVSkKPiAtIGFuZCBpdCByZXF1aXJlcyBmZXdlciBvdmVycmlkZXMgaW4gYm9hcmQgLmR0 cyBmaWxlcwo+IAo+IFNvdW5kcyBsaWtlIGEgbm8tcmVncmV0IG1vdmUgdG8gbWUuCgpQbGVhc2Ug c2VlIG15IGNvbW1lbnRzIGJlbG93LgoKPj4gVG8gYmUgZmFpciwgdGhhdCB2ZXJzaW9uIG9mIHRo ZSBUaGVybWFsIGRldmVsb3BlciBndWlkZSBkYXRlcyBiYWNrIHRvCj4+IDIwMTksIG1lYW5pbmcg dGhhdCBpdCB0ZWNobmljYWxseSBhcHBsaWVzIHRvIHRoZSBSSzMzOTksIGZvciBleGFtcGxlLAo+ PiBidXQgdGhlIFRTQURDIGFuZCByZXNldCBjaXJjdWl0cnkgZGVzaWduIGhhcyBiYXNpY2FsbHkg cmVtYWluZWQgdGhlCj4+IHNhbWUgZm9yIHRoZSBSSzM1ODguCj4+IAo+PiA+ICAtIE15IHN0cm9u ZyBiZWxpZWYgaXMgdGhhdCBkZWZhdWx0cyAocmVnYXJkbGVzcyBvZiBjb250ZXh0KSBzaG91bGQg YmUKPj4gPiBzYWZlIGFuZCByZWFzb25hYmxlLCBhbmQgc2hvdWxkIGFsc28gbWluaW1pemUgdGhl IG5lZWQgdG8gb3ZlcnJpZGUKPj4gPiB0aGVtCj4+IAo+PiBQbGVhc2Ugbm90ZSB0aGF0IHRoZSBU U0FEQyBpcyBkaXNhYmxlZCBpbiB0aGUgUkszMzk5IFNvQyBkdHNpLCBzbyAKPj4gaGF2aW5nCj4+ IGl0IGRpc2FibGVkIGluIHRoZSBSSzM1ODgocykgU29DIGR0c2kgd291bGQgcHJvdmlkZSBzb21l IGNvbnNpc3RlbmN5Lgo+IAo+IEknbSBoYXBweSB0byBwcm9kdWNlIGEgcGF0Y2ggdG8gcmV2ZXJz ZSB0aGUgbG9naWMgaW4gUkszMzk5IChhbmQgYW55Cj4gb3RoZXJzIGZvciB0aGF0IG1hdHRlcikg dG8gYWxzbyBoYXZlIFRTQURDIGVuYWJsZWQgYnkgZGVmYXVsdCB0aGVyZSwKPiB0aHVzIHNhdmlu ZyBzZXZlcmFsIGxpbmVzIG9mIGNvZGUsIGlmIGl0J3MganVzdCBhYm91dCBjb25zaXN0ZW5jeS4K CkJ1dCB3aHkgc2hvdWxkIHdlIGNoYW5nZSBzb21ldGhpbmcgdGhhdCBoYXMgc2VydmVkIHVzIGZv ciB5ZWFycywgb24KbXVsdGlwbGUgU29Dcywgd2l0aCB6ZXJvIHRyb3VibGVzIGFuZCB3aXRoIChB RkFJSykgemVybyBib2FyZHMgcHJvZHVjaW5nCnB1ZmZzIG9mIGJsdWlzaCBzbW9rZT8KCj4+IFRo b3VnaCwgdGhlIFJLMzM5OSBzdGlsbCBkb2VzIGl0IGluIGEgc2FmZSB3YXksIGJ5IG1vdmluZyB0 aGUgT1BQcyAKPj4gaW50bwo+PiBhIHNlcGFyYXRlIGR0c2kgZmlsZSwgbmFtZWQgcmszMzk5LW9w cC5kdHNpLCB3aGljaCB0aGUgYm9hcmQgZHRzIGZpbGVzCj4+IHRoZW4gaW5jbHVkZSB0b2dldGhl ciB3aXRoIGVuYWJsaW5nIHRoZSBUU0FEQy4KPj4gCj4+IElmIHlvdSBhZ3JlZSwgbGV0J3MgZW1w bG95IHRoZSBzYW1lIGFwcHJvYWNoIGZvciB0aGUgUkszNTg4KHMpLCBieQo+PiBoYXZpbmcKPj4g dGhlIGl0cyBPUFBzIGRlZmluZWQgaW4gYSBzZXBhcmF0ZSBmaWxlLCBuYW1lZCByazM1ODhzLW9w cC5kdHNpLCBldGMuCj4gCj4gU2VwYXJhdGUgZmlsZSBmb3IgT1BQcyBpcyBhIGdvb2Qgbm8tcmVn cmV0IG1vdmUgdG8gZGVjbHV0dGVyIHRoZSBTb0MKPiBsZXZlbCAuZHRzaSAoYXMgdGhlIE9QUCB0 YWJsZSBpcyBsb25nIGFuZCBib3JpbmcpIC0gaGFwcHkgdG8gbW92ZSBpdAo+IHJlZ2FyZGxlc3Mg b2YgdGhlIG91dGNvbWUgb2YgdGhlIGFib3ZlIFRTQURDIGRpc2N1c3Npb24uIFRoYW5rcyBmb3IK PiB0aGUgcG9pbnRlciEKClllYWgsIGJ1dCBJJ20gbm90IHN1cmUgdGhhdCBldmVyeW9uZSB3b3Vs ZCBsaWtlIHRoYXQga2luZCBvZiBzZXBhcmF0aW9uLgpJbiBmYWN0LCBzdWNoIHNlcGFyYXRpb24g bWF5IGJlIGZyb3duZWQgdXBvbiB1bmxlc3MgaXQncyBuZWNlc3NhcnkuCgpBcyBJIGFscmVhZHkg ZGVzY3JpYmVkIGluIGFub3RoZXIgdGhyZWFkLCB0aGUgc2VwYXJhdGlvbiBmb3IgdGhlIFJLMzM5 OQppcyB0aGVyZSBvbmx5IGJlY2F1c2UgYSBjb3VwbGUgb2YgZGlmZmVyZW50IHZhcmlhbnRzIG9m IHRoZSBSSzMzOTkgU29DCnJlcXVpcmUgZGlmZmVyZW50IE9QUHMuCgo+PiA+ICAtIEluIGNvbnRl eHQgb2YgZHRzL2R0c2ksIGFzIGZhciBhcyBJIHVuZGVyc3RhbmQgdGhlIGdlbmVyYWwgbG9naWMK Pj4gPiBiZWhpbmQgdGhlIHNwbGl0LCB0aGUgU29DIC5kdHNpIHNob3VsZCBjb250YWluIGFsbCB0 aGUgdGhpbmdzIHRoYXQgYXJlCj4+ID4gZnVsbHkgY29udGFpbmVkIHdpdGhpbiB0aGUgU29DIGFu ZCBkbyBub3QgZGVwZW5kIG9uIHRoZSB3aXJpbmcgb2YgYQo+PiA+IHBhcnRpY3VsYXIgYm9hcmQg b3IgaXRzIHRhcmdldCB1c2UgY2FzZS4gQm9hcmRzIHRoZW4KPj4gPiBhZGQvcmVtb3ZlL292ZXJy aWRlIHNldHRpbmdzIHRvIG1hdGNoIHRoZWlyIHdpcmluZyBhbmQgdXNlIGNhc2UgbW9yZQo+PiA+ IGNsb3NlbHkKPj4gCj4+IE9mIGNvdXJzZSwgYnV0IHRoZSB0aGVybWFsIHNodXRkb3duIGlzIG9i dmlvdXNseSBhIGJvYXJkLWxldmVsIAo+PiBmZWF0dXJlLAo+PiB3aGljaCBJIGRlc2NyaWJlZCBm dXJ0aGVyIGFib3ZlLgo+IAo+IE5vdCBzbyBvYnZpb3VzIHRvIG1lIDotKSBJIGRvbid0IG1lYW4g dG8gYmUgc3R1YmJvcm4gb3IgdW5jb29wZXJhdGl2ZQo+IGhlcmUsIGJ1dCBJIHJlYWxseSBjYW4n dCBmaW5kIGFueSB0ZWNobmljYWwgbWVyaXQgaW4gaGF2aW5nIGl0IGVuYWJsZWQKPiBhdCBib2Fy ZCBsZXZlbCBpbnN0ZWFkIG9mIFNvQyBsZXZlbC4KCldlbGwsIHBsZWFzZSBhbHNvIGNvbnNpZGVy IHRoYXQgdGhlIFBNSUNzIGZyb20gUm9ja2NoaXAgYXJlIGtpbmQgb2YKd2VpcmQgbGl0dGxlIGNo aXBzLCBzcGVjaWZpY2FsbHkgY3VzdG9taXplZCB0byBzZXJ2ZSBwYXJ0aWN1bGFyIFNvQ3MuCkZv ciBleGFtcGxlLCB0aGV5IGVuc3VyZSB0aGUgcmlnaHQgc2VxdWVuY2luZyBhbmQgcmFtcGluZy11 cCBvZiAKZGlmZmVyZW50CnBvd2VyIHJhaWxzLCB3aGljaCBpcyBpbiBtYW55IGNhc2VzIGVzc2Vu dGlhbC4KClRodXMsIHdobyBrbm93cyB3aGF0IG1pZ2h0IChvciBtaWdodCBub3QpIGdvIHdyb25n IGlmIHdlIGRvbid0IHJlc2V0IHRoZQpQTUlDIGF0IHRoZSBzYW1lIHRpbWUgd2hlbiB0aGUgQ1JV IHJlc2V0cyB0aGUgU29DPyAgVW5mb3J0dW5hdGVseSwgdGhlCnRoaW5ncyBhcmVuJ3QgdGhhdCBz dHJhaWdodGZvcndhcmQuCgpPbiB0b3Agb2YgdGhhdCwgc29tZSBib2FyZHMsIHN1Y2ggYXMgdGhl IFJvY2sgNUIsIHVzZSBhIGZldyBhZGRpdGlvbmFsCmRpc2NyZXRlIHZvbHRhZ2UgcmVndWxhdG9y cyBpbnN0ZWFkIG9mIGEgbWFzdGVyLXNsYXZlIFBNSUMgCmNvbmZpZ3VyYXRpb24sCndoaWNoIG1h eSBhY3R1YWxseSBpbnRyb2R1Y2Ugc29tZSB3ZWlyZCBwb3dlci1yZWxhdGVkIGlzc3Vlcywgd2hp Y2ggYWxzbwptYXkgYmUgaW50ZXJtaXR0ZW50LiAgQWN0dWFsbHksIEkndmUgYWxyZWFkeSBvdmVy aGVhcmQgdGhhdCB0aGUgUm9jayA1QgpleHBlcmllbmNlcyBzb21lIGlzc3VlcyBvZiB0aGF0IG5h dHVyZSwgYnV0IEkgZG9uJ3Qga25vdyB0aGUgZGV0YWlscy4KCj4gU3dpdGNoaW5nIHRvIFBNSUMt YXNzaXN0ZWQgcmVzZXRzIGlzIG9uZSB0aGluZyAtIGl0IGRlZmluaXRlbHkgc2hvdWxkCj4gZ28g dG8gYm9hcmQgZmlsZXMsIGFzIGl0IGRlcGVuZHMgb24gdGhlIHNwZWNpZmljIHdpcmluZyBvZiB0 aGUKPiBUU0FEQ19TSFVUIHNpZ25hbC4gRW5hYmxpbmcgVFNBREMgaW4gYSBkZWZhdWx0IGNvbmZp Z3VyYXRpb24gdGhhdCBjYW4KPiBhbmQgd2lsbCB3b3JrIG9uIGFsbCBib2FyZHMgcmVnYXJkbGVz cyBvZiB0aGVpciB3aXJpbmcgaXMgYW5vdGhlcgo+IHRoaW5nLiBJJ20ganVzdCBhcmd1aW5nIGZv ciB0aGUgbGF0dGVyLgoKQ1JVLWJhc2VkIHRoZXJtYWwgcnVuYXdheSBoYW5kbGluZyBtYXkgaW4g dGhlb3J5IHdvcmsgb24gYWxsIGJvYXJkcywgYnV0CndlIHNpbXBseSBjYW4ndCBiZSAxMDAlIHN1 cmUgd2l0aG91dCBkZXRhaWxlZCBpbnNpZ2h0cyBpbnRvIHRoZSBib2FyZApkZXNpZ25zIGFuZCB0 ZXN0aW5nLiAgTWF5YmUgZXZlbiB0aGUgZG93bnN0cmVhbSBVLUJvb3QgZG9lcyBzb21lIG1hZ2lj CmR1cmluZyBzdWNoIHRoZXJtYWwgcnVuYXdheSByZXNldHMsIHdoaWNoIHdlIGRvbid0IGtub3cu ICBJdCBtYXkgYmUKc2ltaWxhciB0byB0aGUgU29DIHJlc2V0IGlzc3VlcyB0aGF0IHRoZSBSSzMz OTkgc3VmZmVycyBmcm9tLgoKU2VlIGFsc28gbXkgY29tbWVudCBhYm92ZS4KCj4gVG8gbWUgaXQg c2VlbXMgc2ltaWxhciB0byB0aGUgd2F0Y2hkb2cgdGltZXIgc2l0dWF0aW9uOiB3ZSBlbmFibGUg aXQKPiBhdCB0aGUgU29DIGxldmVsIFsxXSwgYXMgaXQgaXMgZXhwZWN0ZWQgdG8gd29yayBpbiBp dHMgZGVmYXVsdAo+IGNvbmZpZ3VyYXRpb24gcmVnYXJkbGVzcyBvZiB0aGUgYm9hcmQgd2lyaW5n LCBhbmQgaXQgcHJvdmlkZXMKPiBwcm90ZWN0aW9uIGFnYWluc3Qgc3lzdGVtIG1hbGZ1bmN0aW9u cy4gRG9lc24ndCBtYXR0ZXIgaWYgdGhlIGJvYXJkIG9yCj4gaXRzIHVzZXJzcGFjZSBjb2RlIGVu ZHMgdXAgdXNpbmcgdGhlIGZ1bGwgZnVuY3Rpb25hbGl0eSAtIGl0IGp1c3Qgc2l0cwo+IHRoZXJl IHdhaXRpbmcgZm9yIGl0cyBzcG90bGlnaHQgd2l0aG91dCBodXJ0aW5nIGFueWJvZHkuCgpGcmFu a2x5LCBJIGRvbid0IGtub3cgbXVjaCBhYm91dCB0aGUgd2F0Y2hkb2cgZnVuY3Rpb25hbGl0eSwg c28gSSdkIG5lZWQKdG8gcmVzZWFyY2ggaXQgYmVmb3JlIEkgY291bGQgc2F5IHNvbWV0aGluZyBh Ym91dCBpdC4KCj4gWzFdIAo+IGh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9r ZXJuZWwvZ2l0L3RvcnZhbGRzL2xpbnV4LmdpdC90cmVlL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9j a2NoaXAvcmszNTg4cy5kdHNpI24xODcyCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0t a2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.manjaro.org (mail.manjaro.org [116.203.91.91]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 088EB69E16; Fri, 1 Mar 2024 08:52:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=116.203.91.91 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709283159; cv=none; b=HwMcgwHMKX7JtLzNGFNUy887rSxdgsbgiFTplk7sRLjATU9fNVVVx4U5JEVOTvnzJsFloITtmO3Pq0AWC26Lx1AhzFxxI1GhnwpQDxTzoG3gcPVusPU8P8WOzJlMmyuh8wzRcNh3QNzns6eS5Rvl3QAIWQlBMoRFa/29E7k22cE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709283159; c=relaxed/simple; bh=ByJxXjUmVJOan1Gat8sDAxu1MHfl4qWUa465EQgUY7Q=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=kpqgRD3XxtvHiHDJL77t6wIiMHLA+IOITbpEMxK6F9C1pL5KPfGGfrNjjUwKYHHpOTTi6CzKLBVTBa2hMUr1B02FJJeNAaY6aJkCOTR2osqKocWGzYRM4z1D9TTNCvQWRwqNoV2TddiTmNZL2OvQIIjpwQnglhaV91n8a+yibQU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org; spf=pass smtp.mailfrom=manjaro.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b=orUcIuS7; arc=none smtp.client-ip=116.203.91.91 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=manjaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b="orUcIuS7" Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1709283154; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HLbvrgwUZZKBHF7NvvXt4qwWmyIAaI4FWrdM6t+PElo=; b=orUcIuS7xstNMAE2D54STQMmWn3gzMFrWU0mCVp7v8cA9eEpuaqSdvrWrsQQ2Aee60Eerw gf21eR1Ap0G3tJglp2/CuNjBCBpsw2dqpeuK8BeEJO0bBigoGu6k37inPdFpJ3ZZVtuElw D1X3XRcX6eRn01R/fCmil5hxndf51F+f2/j9g/+dpjXuTNt/eGN4RbVRDD9X/fRYnHZSlp Xmilmr7rmn/HoZmnd2Sv8pbV/TalK+glKMbGthe/TlspYoVnm09U6WFgeEqVCOnV3u2GdN +y4vC8hUd5L5oyUDk7vNgkaQ1LVOJvjyJmG/FWX3kHPzPPeNoeFJAcDOrICdJA== Date: Fri, 01 Mar 2024 09:52:34 +0100 From: Dragan Simic To: Alexey Charkov Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Daniel Lezcano , Viresh Kumar , Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/5] arm64: dts: rockchip: enable built-in thermal monitoring on RK3588 In-Reply-To: References: <20240229-rk-dts-additions-v3-0-6afe8473a631@gmail.com> <20240229-rk-dts-additions-v3-1-6afe8473a631@gmail.com> Message-ID: <8b48eeac7b629c39adc6024ff418724c@manjaro.org> X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org On 2024-03-01 09:25, Alexey Charkov wrote: > On Fri, Mar 1, 2024 at 9:51 AM Dragan Simic wrote: >> On 2024-03-01 06:12, Alexey Charkov wrote: >> > On Fri, Mar 1, 2024 at 12:21 AM Dragan Simic >> > wrote: >> >> On 2024-02-29 20:26, Alexey Charkov wrote: >> >> > Include thermal zones information in device tree for RK3588 variants. >> >> > >> >> > This also enables the TSADC controller unconditionally on all boards >> >> > to ensure that thermal protections are in place via throttling and >> >> > emergency reset, once OPPs are added to enable CPU DVFS. >> >> > >> >> > The default settings (using CRU as the emergency reset mechanism) >> >> > should work on all boards regardless of their wiring, as CRU resets >> >> > do not depend on any external components. Boards that have the TSHUT >> >> > signal wired to the reset line of the PMIC may opt to switch to GPIO >> >> > tshut mode instead (rockchip,hw-tshut-mode = <1>;) >> >> >> >> Quite frankly, I'm still not sure that enabling this on the SoC level >> >> is the way to go. As I already described in detail, [4] according to >> >> the RK3588 Hardware Design Guide v1.0 and the Rock 5B schematic, we >> >> should actually use GPIO-based handling for the thermal runaways on >> >> the Rock 5B. Other boards should also be investigated individually, >> >> and the TSADC should be enabled on a board-to-board basis. >> > >> > With all due respect, I disagree, here is why: >> > - Neither the schematic nor the hardware design guide, on which the >> > schematic seems to be based, prescribes a particular way to handle >> > thermal runaways. They only provide the possibility of GPIO based >> > resets, along with the CRU based one >> >> Please note that other documents from Rockchip also exist. Below is >> a link to a screenshot from the Thermal developer guide, version 1.0, >> which describes the whole thing further. I believe it's obvious that >> the thermal runaway is to be treated as a board-level feature. >> >> - https://i.imgur.com/IJ6dSAc.png > > Frankly, that still doesn't make TSADC per se a board-level thing IMO. > The only thing that is board-level is the wiring of GPIO based resets, > which I fully agree should go to board .dts for boards that support > it, but that's not part of the current defaults and can be safely > added later. > > TSADC is inside the SoC. CRU is inside the SoC. They work just fine > for a thermal reset, even if no dedicated reset logic is wired on the > board. I really don't see any downsides in having TSADC enabled by > default with CRU based resets: > - it's a safe default (i.e. I cannot think of any configuration or use > case where enabled-by-default TSADC does any harm) > - it's safer than accidentally forgetting to enable TSADC (as it adds > thermal protection which is otherwise missing) > - it will work on all boards (even if it doesn't utilize the full > hardware functionality by ignoring GPIO resets that some boards also > have in addition to the CRU) > - and it requires fewer overrides in board .dts files > > Sounds like a no-regret move to me. Please see my comments below. >> To be fair, that version of the Thermal developer guide dates back to >> 2019, meaning that it technically applies to the RK3399, for example, >> but the TSADC and reset circuitry design has basically remained the >> same for the RK3588. >> >> > - My strong belief is that defaults (regardless of context) should be >> > safe and reasonable, and should also minimize the need to override >> > them >> >> Please note that the TSADC is disabled in the RK3399 SoC dtsi, so >> having >> it disabled in the RK3588(s) SoC dtsi would provide some consistency. > > I'm happy to produce a patch to reverse the logic in RK3399 (and any > others for that matter) to also have TSADC enabled by default there, > thus saving several lines of code, if it's just about consistency. But why should we change something that has served us for years, on multiple SoCs, with zero troubles and with (AFAIK) zero boards producing puffs of bluish smoke? >> Though, the RK3399 still does it in a safe way, by moving the OPPs >> into >> a separate dtsi file, named rk3399-opp.dtsi, which the board dts files >> then include together with enabling the TSADC. >> >> If you agree, let's employ the same approach for the RK3588(s), by >> having >> the its OPPs defined in a separate file, named rk3588s-opp.dtsi, etc. > > Separate file for OPPs is a good no-regret move to declutter the SoC > level .dtsi (as the OPP table is long and boring) - happy to move it > regardless of the outcome of the above TSADC discussion. Thanks for > the pointer! Yeah, but I'm not sure that everyone would like that kind of separation. In fact, such separation may be frowned upon unless it's necessary. As I already described in another thread, the separation for the RK3399 is there only because a couple of different variants of the RK3399 SoC require different OPPs. >> > - In context of dts/dtsi, as far as I understand the general logic >> > behind the split, the SoC .dtsi should contain all the things that are >> > fully contained within the SoC and do not depend on the wiring of a >> > particular board or its target use case. Boards then >> > add/remove/override settings to match their wiring and use case more >> > closely >> >> Of course, but the thermal shutdown is obviously a board-level >> feature, >> which I described further above. > > Not so obvious to me :-) I don't mean to be stubborn or uncooperative > here, but I really can't find any technical merit in having it enabled > at board level instead of SoC level. Well, please also consider that the PMICs from Rockchip are kind of weird little chips, specifically customized to serve particular SoCs. For example, they ensure the right sequencing and ramping-up of different power rails, which is in many cases essential. Thus, who knows what might (or might not) go wrong if we don't reset the PMIC at the same time when the CRU resets the SoC? Unfortunately, the things aren't that straightforward. On top of that, some boards, such as the Rock 5B, use a few additional discrete voltage regulators instead of a master-slave PMIC configuration, which may actually introduce some weird power-related issues, which also may be intermittent. Actually, I've already overheard that the Rock 5B experiences some issues of that nature, but I don't know the details. > Switching to PMIC-assisted resets is one thing - it definitely should > go to board files, as it depends on the specific wiring of the > TSADC_SHUT signal. Enabling TSADC in a default configuration that can > and will work on all boards regardless of their wiring is another > thing. I'm just arguing for the latter. CRU-based thermal runaway handling may in theory work on all boards, but we simply can't be 100% sure without detailed insights into the board designs and testing. Maybe even the downstream U-Boot does some magic during such thermal runaway resets, which we don't know. It may be similar to the SoC reset issues that the RK3399 suffers from. See also my comment above. > To me it seems similar to the watchdog timer situation: we enable it > at the SoC level [1], as it is expected to work in its default > configuration regardless of the board wiring, and it provides > protection against system malfunctions. Doesn't matter if the board or > its userspace code ends up using the full functionality - it just sits > there waiting for its spotlight without hurting anybody. Frankly, I don't know much about the watchdog functionality, so I'd need to research it before I could say something about it. > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/rockchip/rk3588s.dtsi#n1872