From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: * X-Spam-Status: No, score=1.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, URIBL_DBL_ABUSE_MALW autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8107AC2D0B1 for ; Thu, 6 Feb 2020 09:09:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4EDFA206CC for ; Thu, 6 Feb 2020 09:09:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FzU+FxSF"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="UiOq8E+c" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4EDFA206CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CsvM14JfBwlMGP/Sy2T9aVlNhSzvMI8sauGBzSHr8vs=; b=FzU+FxSFenXMevclDnN1jx1RE VNxknyvlRHZjmkZ63sbruqMod4Q3wwxLJTDzfbwdQks3UU8OR3jYnVYVKTTHUa3+hqbFus2Ua5HWq gVLNFfZUrdGo/3m0P+uE1nvTkHeCEyeUcfOFta0LbI0L+1ruMCCh/5gEMR3arkPH2Y1yybLGDsg7/ 0q6pDyVIXWlBDiLgDBa81cXENc/rqAM1q9EHLqlZmdML259iSwTu5d7hNKJVyc77CtvhLnSPHhJhH ia0EfOAov1dd7DCP881YpMJhYsuoIjdXrn4+qmy4dL5sgKO3xaA34N79GQDosRdHK7X5NqZ9CN0lu +3CWiQMiw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1izdA3-0002ek-VK; Thu, 06 Feb 2020 09:09:23 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1izdA0-0002eE-KG for linux-arm-kernel@lists.infradead.org; Thu, 06 Feb 2020 09:09:21 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CFEE3206CC; Thu, 6 Feb 2020 09:09:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580980160; bh=o5FYUNHWR4JnSDHrUMdC3nhqVzIDwQIn4yBc45ZxDb8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UiOq8E+c4EAjWNLFpgTWXyhiBSZdZcts6MCCsrMsOHNx0zxnY+i5a2rU4m1Yt0tVh ugtRjr4NWauEOYlDScswJ9301WdrLIOfFhE7o/8U/qR9lVBZFvm1MOjWcKsnBAyNFw cYK5TvfOmuO4drjALZ1HuwmwzYFKx7cCXtXGugFI= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1izd9y-003HNt-2V; Thu, 06 Feb 2020 09:09:18 +0000 MIME-Version: 1.0 Date: Thu, 06 Feb 2020 09:09:18 +0000 From: Marc Zyngier To: Michal Simek Subject: Re: [PATCH v2] irqchip: xilinx: Add support for multiple instances In-Reply-To: <3d6077c1-2b13-acc6-e8f4-3d1ab23dc159@xilinx.com> References: <1580911535-19415-1-git-send-email-mubin.usman.sayyed@xilinx.com> <3d6077c1-2b13-acc6-e8f4-3d1ab23dc159@xilinx.com> Message-ID: <8b5c5b5d601856ddc3f4388e267c4cd0@kernel.org> X-Sender: maz@kernel.org User-Agent: Roundcube Webmail/1.3.8 X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: michal.simek@xilinx.com, mubin.usman.sayyed@xilinx.com, tglx@linutronix.de, jason@lakedaemon.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, siva.durga.paladugu@xilinx.com, anirudha.sarangi@xilinx.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200206_010920_712253_64F63EEB X-CRM114-Status: GOOD ( 18.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jason@lakedaemon.net, Mubin Usman Sayyed , anirudha.sarangi@xilinx.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, siva.durga.paladugu@xilinx.com, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMC0wMi0wNiAwNzowNiwgTWljaGFsIFNpbWVrIHdyb3RlOgo+IE9uIDA1LiAwMi4gMjAg MTc6NTMsIE1hcmMgWnluZ2llciB3cm90ZToKPj4gT24gMjAyMC0wMi0wNSAxNDowNSwgTXViaW4g VXNtYW4gU2F5eWVkIHdyb3RlOgoKWy4uLl0KCj4+PiDCoHVuc2lnbmVkIGludCB4aW50Y19nZXRf aXJxKHZvaWQpCj4+PiDCoHsKPj4+IC3CoMKgwqDCoMKgwqAgdW5zaWduZWQgaW50IGh3aXJxLCBp cnEgPSAtMTsKPj4+ICvCoMKgwqDCoMKgwqAgaW50IGh3aXJxLCBpcnEgPSAtMTsKPj4+IAo+Pj4g LcKgwqDCoMKgwqDCoCBod2lycSA9IHhpbnRjX3JlYWQoSVZSKTsKPj4+ICvCoMKgwqDCoMKgwqAg aHdpcnEgPSB4aW50Y19yZWFkKHByaW1hcnlfaW50Yy0+YmFzZSArIElWUik7Cj4+PiDCoMKgwqDC oMKgwqDCoCBpZiAoaHdpcnEgIT0gLTFVKQo+Pj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAgaXJxID0gaXJxX2ZpbmRfbWFwcGluZyh4aW50Y19pcnFjLT5yb290X2RvbWFpbiwgCj4+PiBo d2lycSk7Cj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBpcnEgPSBpcnFfZmluZF9t YXBwaW5nKHByaW1hcnlfaW50Yy0+cm9vdF9kb21haW4sIAo+Pj4gaHdpcnEpOwo+Pj4gCj4+PiDC oMKgwqDCoMKgwqDCoCBwcl9kZWJ1ZygiaXJxLXhpbGlueDogaHdpcnE9JWQsIGlycT0lZFxuIiwg aHdpcnEsIGlycSk7Cj4+IAo+PiBJIGhhdmUgdGhlIHVnbHkgZmVlbGluZyBJJ20gcmVhZGluZyB0 aGUgc2FtZSBjb2RlIHR3aWNlLi4uIFN1cmVseSB5b3UgCj4+IGNhbgo+PiBtYWtlIHRoZXNlIHR3 byBmdW5jdGlvbnMgY29tbW9uIGNvZGUuCj4gCj4gSSBoYXZlIHNvbWUgcXVlc3Rpb25zIHJlZ2Fy ZGluZyB0aGlzLgo+IEkgaGF2ZSB1cGRhdGVkIG9uZSBwYXRjaHNldCB3aGljaCBpcyBhZGRpbmcg c3VwcG9ydCBmb3IgTWljcm9ibGF6ZSBTTVAuCj4gQW5kIHdoZW4gSSB3YXMgbG9va2luZyBhdCBj dXJyZW50IHdpcmluZyBvZiB0aGlzIGRyaXZlciBJIGhhdmUgZGVjaWRlZAo+IHRvIGNoYW5nZSBp dC4KPiAKPiBJIGhhdmUgZW5hYmxlZCAgR0VORVJJQ19JUlFfTVVMVElfSEFORExFUiBhbmQgSEFO RExFX0RPTUFJTl9JUlEuCj4gVGhpcyBkcml2ZXIgY2FsbHMgc2V0X2hhbmRsZV9pcnEoeGlsX2lu dGNfaGFuZGxlX2lycSkKPiBhbmQgTUIgZG9fSVJRKCkgY2FsbCBoYW5kbGVfYXJjaF9pcnEoKQo+ IGFuZCBJUlEgcm91dGluZSBoZXJlIGlzIHVzaW5nIGhhbmRsZV9kb21haW5faXJxKCkuCj4gCj4g SSB3b3VsZCBleHBlY3QgdGhhdCB0aGlzIGNoYWluZWQgSVJRIGhhbmRsZXIgY2FuIGFsc28gdXNl Cj4gaGFuZGxlX2RvbWFpbl9pcnEoKS4KPiAKPiBJcyB0aGF0IGNvcnJlY3QgdW5kZXJzdGFuZGlu Zz8KCmhhbmRsZV9kb21haW5faXJxKCkgaW1wbGllcyB0aGF0IHlvdSBoYXZlIGEgc2V0IG9mIHB0 X3JlZ3MsIHJlcHJlc2VudGluZwp0aGUgY29udGV4dCB5b3UgaW50ZXJydXB0ZWQuIFlvdSBjYW4n dCBmYWtlIHRoYXQgdXAsIHNvIEkgY2FuJ3Qgc2VlIGhvdwp5b3UgdXNlIGl0IGluIGEgY2hhaW5l ZCBjb250ZXh0LgoKWy4uLl0KCj4+PiArwqDCoMKgwqDCoMKgIGludGNfZGV2LT5uYW1lID0gaW50 Yy0+ZnVsbF9uYW1lOwo+PiAKPj4gTm8uIFRoZSB3b3JsZCBkb2Vzbid0IG5lZWQgdG8gc2VlIHRo ZSBPRiBwYXRoIG9mIHlvdXIgaW50ZXJydXB0Cj4+IGNvbnRyb2xsZXIgaW4gL3Byb2MvY3B1aW5m by4KPj4gVGhlIG5hbWUgdGhhdCB3YXMgdGhlcmUgYmVmb3JlIHdhcyBwZXJmZWN0bHkgZGVzY3Jp cHRpdmUsIHBsZWFzZSBzdGljawo+PiB0byBpdC4KPiAKPiBJdCBzaG91bGQgYmUgc2hvd2luZyBu YW1lIGxpa2UgaW50ZXJydXB0LWNvbnRyb2xsZXJANDE4MDAwMDAuCj4gRG8geW91IHRoaW5rIHRo YXQgd2UgcmVhbGx5IHNob3VsZCBzdGljayB3aXRoIGp1c3QgZml4ZWQgbmFtZT8KPiBUaGVyZSBj b3VsZCBiZSBtdWx0aXBsZSBpbnN0YW5jZXMgaW4gdGhlIHN5c3RlbSBhbmQgeW91IHdpbGwgaGF2 ZSBubwo+IGlkZWEgaG93IHRoZXkgYXJlIGNvbm5lY3RlZC4KCldoYXQgaXMgdGhhdCB1c2VkIGZv cj8gRGVidWdnaW5nLiBXZSBoYXZlIGEgd2hvbGUgaW5mcmFzdHJ1Y3R1cmUgZm9yIAp0aGF0CihH RU5FUklDX0lSUV9ERUJVR0ZTKSwgd2hpY2ggaXMgdGhlIHJpZ2h0IHRvb2wgZm9yIHRoZSBqb2Iu IElmIGl0IG5lZWRzCmltcHJvdmVtZW50LCBwbGVhc2UgbGV0IG1lIGtub3cgd2hhdCBpcyBtaXNz aW5nLgoKQWxzbywgYW55dGhpbmcgaW4gL3Byb2MgaXMgQUJJLCBzbyB3ZSBkb24ndCBjaGFuZ2Ug aXQgcmFuZG9tbHkuCgpUaGFua3MsCgogICAgICAgICBNLgotLSAKSmF6eiBpcyBub3QgZGVhZC4g SXQganVzdCBzbWVsbHMgZnVubnkuLi4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04FBEC2D0B1 for ; Thu, 6 Feb 2020 09:09:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CAE91217BA for ; Thu, 6 Feb 2020 09:09:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580980161; bh=o5FYUNHWR4JnSDHrUMdC3nhqVzIDwQIn4yBc45ZxDb8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=DTKn/gIOeQW/C7q9yPWZqVTwe/8uftSPZ5IbCG8PhsWuDLh0UagXuOs6qGQvLYhnm 1AFrAR6lGVt0xe9pgXheWBI8apzst3IaHVID8EjDlvGFaXwvmD63KBIeetgURjTLdA FiTpqbhx2ConGYvfllCX42lu2ftyAnXL6ccy4y90= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728286AbgBFJJV (ORCPT ); Thu, 6 Feb 2020 04:09:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:52824 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727848AbgBFJJU (ORCPT ); Thu, 6 Feb 2020 04:09:20 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CFEE3206CC; Thu, 6 Feb 2020 09:09:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580980160; bh=o5FYUNHWR4JnSDHrUMdC3nhqVzIDwQIn4yBc45ZxDb8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UiOq8E+c4EAjWNLFpgTWXyhiBSZdZcts6MCCsrMsOHNx0zxnY+i5a2rU4m1Yt0tVh ugtRjr4NWauEOYlDScswJ9301WdrLIOfFhE7o/8U/qR9lVBZFvm1MOjWcKsnBAyNFw cYK5TvfOmuO4drjALZ1HuwmwzYFKx7cCXtXGugFI= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1izd9y-003HNt-2V; Thu, 06 Feb 2020 09:09:18 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Thu, 06 Feb 2020 09:09:18 +0000 From: Marc Zyngier To: Michal Simek Cc: Mubin Usman Sayyed , tglx@linutronix.de, jason@lakedaemon.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, siva.durga.paladugu@xilinx.com, anirudha.sarangi@xilinx.com Subject: Re: [PATCH v2] irqchip: xilinx: Add support for multiple instances In-Reply-To: <3d6077c1-2b13-acc6-e8f4-3d1ab23dc159@xilinx.com> References: <1580911535-19415-1-git-send-email-mubin.usman.sayyed@xilinx.com> <3d6077c1-2b13-acc6-e8f4-3d1ab23dc159@xilinx.com> Message-ID: <8b5c5b5d601856ddc3f4388e267c4cd0@kernel.org> X-Sender: maz@kernel.org User-Agent: Roundcube Webmail/1.3.8 X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: michal.simek@xilinx.com, mubin.usman.sayyed@xilinx.com, tglx@linutronix.de, jason@lakedaemon.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, siva.durga.paladugu@xilinx.com, anirudha.sarangi@xilinx.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-02-06 07:06, Michal Simek wrote: > On 05. 02. 20 17:53, Marc Zyngier wrote: >> On 2020-02-05 14:05, Mubin Usman Sayyed wrote: [...] >>>  unsigned int xintc_get_irq(void) >>>  { >>> -       unsigned int hwirq, irq = -1; >>> +       int hwirq, irq = -1; >>> >>> -       hwirq = xintc_read(IVR); >>> +       hwirq = xintc_read(primary_intc->base + IVR); >>>         if (hwirq != -1U) >>> -               irq = irq_find_mapping(xintc_irqc->root_domain, >>> hwirq); >>> +               irq = irq_find_mapping(primary_intc->root_domain, >>> hwirq); >>> >>>         pr_debug("irq-xilinx: hwirq=%d, irq=%d\n", hwirq, irq); >> >> I have the ugly feeling I'm reading the same code twice... Surely you >> can >> make these two functions common code. > > I have some questions regarding this. > I have updated one patchset which is adding support for Microblaze SMP. > And when I was looking at current wiring of this driver I have decided > to change it. > > I have enabled GENERIC_IRQ_MULTI_HANDLER and HANDLE_DOMAIN_IRQ. > This driver calls set_handle_irq(xil_intc_handle_irq) > and MB do_IRQ() call handle_arch_irq() > and IRQ routine here is using handle_domain_irq(). > > I would expect that this chained IRQ handler can also use > handle_domain_irq(). > > Is that correct understanding? handle_domain_irq() implies that you have a set of pt_regs, representing the context you interrupted. You can't fake that up, so I can't see how you use it in a chained context. [...] >>> +       intc_dev->name = intc->full_name; >> >> No. The world doesn't need to see the OF path of your interrupt >> controller in /proc/cpuinfo. >> The name that was there before was perfectly descriptive, please stick >> to it. > > It should be showing name like interrupt-controller@41800000. > Do you think that we really should stick with just fixed name? > There could be multiple instances in the system and you will have no > idea how they are connected. What is that used for? Debugging. We have a whole infrastructure for that (GENERIC_IRQ_DEBUGFS), which is the right tool for the job. If it needs improvement, please let me know what is missing. Also, anything in /proc is ABI, so we don't change it randomly. Thanks, M. -- Jazz is not dead. It just smells funny...