From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Huang2, Wei" Subject: RE: [PATCH] patch to support super page (2M) with EPT Date: Mon, 12 May 2008 07:14:02 -0500 Message-ID: <8b6101c8b429$a44c31ea$b424b5a3@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-class: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser , "Xin, Xiaohui" , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org I will re-submit another one today. -----Original Message----- From: Keir Fraser Sent: Monday, May 12, 2008 2:03 AM To: Xin, Xiaohui ; Huang2, Wei = ; xen-devel@lists.xensource.com = Subject: Re: [Xen-devel][PATCH] patch to support super page (2M) with = EPT Yes, absolutely no need for 4M page support. We do not support the = 32-bit non-PAE build target any more. -- Keir On 12/5/08 06:04, "Xin, Xiaohui" wrote: Some comments here: 1) Basically 4M pages allocations is not hardware naturally for EPT, we = only use 2M super pages now.=20 I remembered that Keir said that 2M pages allocation is sufficient, and = he removed all the pure 32bit support already. 2) If we don=92t allocate the last 2M area with 4kb pages, the EPT = will meet some problem. Xen will set one of the 4k page there to be invalid, logically that means we should invalid the = all the 2M page if we allocate it with 2M, and then the=20 special pages Xen used in the high end of the guest memory can not = be used then. May we know how you cope with that? =20 Thanks Xiaohui =20 =09 ________________________________ From: xen-devel-bounces@lists.xensource.com = [mailto:xen-devel-bounces@lists.xensource.com] On Behalf Of Huang2, Wei Sent: Monday, May 12, 2008 12:36 PM To: Xin, Xiaohui; xen-devel@lists.xensource.com Subject: RE: [Xen-devel][PATCH] patch to support super page (2M) with = EPT =09 This is the latest one I created. Please review it and I will = re-submit. =20 1. It includes the patch for p2m-ept.c, directly from your = previous patch.=20 =09 2. Xc_hvm_create.c is based on my original approach. It includes = support for both 2MB and 4MB pages. Also it considers the case of odd = page size (such as 255MB). But I did not allocate the last 2MB area = using 4KB pages. Let me know if it is a big issue. =09 3. The rest are pretty similar. =09 =09 Thanks, =20 -Wei =20 =09 From: xen-devel-bounces@lists.xensource.com = [mailto:xen-devel-bounces@lists.xensource.com] On Behalf Of Huang2, Wei Sent: Sunday, May 11, 2008 3:34 PM To: Xin, Xiaohui; xen-devel@lists.xensource.com Subject: RE: [Xen-devel][PATCH] patch to support super page (2M) with = EPT =09 Could we work together for a common solution? As far as I can see, it = largely overlaps with my super page patch. The major difference is = between p2m.c and p2m-ept.c. =20 -Wei =20 =09 From: xen-devel-bounces@lists.xensource.com = [mailto:xen-devel-bounces@lists.xensource.com] On Behalf Of Xin, Xiaohui Sent: Friday, May 09, 2008 4:11 AM To: xen-devel@lists.xensource.com Subject: [Xen-devel][PATCH] patch to support super page (2M) with EPT =09 Attached are the patches to support super page with EPT. We only = support 2M size. And shadow may still work fine with 4K pages. The patches can be split into 3 parts. Apply order is as attached. =20 tool.diff=20 To allocate 2M physical contiguous memory in guest except the first 2M = and the last 2M. The first 2M covers special memory, and Xen use the last few pages in = guest memory to do special things. We let them to be 4K pages as normal. super_page_common.patch=20 To modify the p2m interfaces by adding an order parameter, such as = guest_physmap_add_page(), p2m_set_entry(), etc. p2m-ept-file.patch To handle the EPT tables to support super page. =20 =20 =20 Signed-off-by: Xin Xiaohui Signed-off-by: Li Xin, B =20 =09 =20 =09 =09 ________________________________ _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel =09