Re: [PATCH v6 0/3] Add SCLP event type CPI

[Shalini Chellathurai Saroja <shalini@linux.ibm.com>]

On 2025-06-24 12:25, Thomas Huth wrote:
> On 16/06/2025 16.01, Shalini Chellathurai Saroja wrote:
>> Implement the Service-Call Logical Processor (SCLP) event
>> type Control-Program Identification (CPI) in QEMU.
>> 
>> Changed since v5:
>> - Add identifiers as class properties instead of object properties
>> - Add description for all the class properties
>> - Remove S390ControlProgramId as it is not needed anymore
>> - Update description of system_level identifier
>> - Add Reviewed-by tags
> 
>  Hi Shalini!
> 
> Thanks, I've picked this up for my next pull request.
> 
> If you've got some spare time, could you maybe also look into writing
> a regression test for this, e.g. by extending one of the tests in
> tests/functional/test_s390x_ccw_virtio.py to see whether the guests
> provide the expected information via CPI there? (I hope the guests in
> that test are recent enough for this feature, otherwise we might want
> to update them)
> 

Hello Thomas,

Thank you very much. Yes, I will do so.

>  Thanks,
>   Thomas

-- 
Mit freundlichen Grüßen / Kind regards
Shalini Chellathurai Saroja
Software Developer
Linux on IBM Z & KVM Development
IBM Deutschland Research & Development GmbH
Dept 1419, Schoenaicher Str. 220, 71032 Boeblingen
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht 
Stuttgart, HRB 243294