Re: [PATCH] KVM: s390: arm64: Tolerate unused functions in extracted source

[Christian Borntraeger <borntraeger@linux.ibm.com>]

Am 05.11.26 um 15:14 schrieb Andreas Grapentin:
> Extracting static declared arm64 functions with no consumer on the s390
> side into the generated sources causes compiler warnings when subsuming
> the generated sources from s390. This causes spurious compiler warnings
> that make it harder to extract larger, more cohesive portions of the
> arm64 source.
> 
> Update the extraction logic to wrap the extracted source into diagnostic
> pragmas to disable -Wunused-function for the extracted block. This
> allows us to share more freely, and also opens up more paths for future
> code sharing with a separation of extraction and definition of consumers
> in separate commits.
> 
> Obviously no functional change intended.
> 
> Signed-off-by: Andreas Grapentin <gra@linux.ibm.com>
> Reviewed-by: Steffen Eiden <seiden@linux.ibm.com>
> Signed-off-by: Steffen Eiden <seiden@linux.ibm.com>

Acked-by: Christian Borntraeger <borntraeger@linux.ibm.com>


As you send this mail, I will drop Steffens signoff.
applied thanks.


> ---
>   arch/s390/kvm/arm64/copy-arm64c.awk | 10 +++++++++-
>   1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/s390/kvm/arm64/copy-arm64c.awk b/arch/s390/kvm/arm64/copy-arm64c.awk
> index 640a7bcb7e23..a318be97c419 100644
> --- a/arch/s390/kvm/arm64/copy-arm64c.awk
> +++ b/arch/s390/kvm/arm64/copy-arm64c.awk
> @@ -42,6 +42,9 @@ BEGIN {
>   	print "#endif /* __INCL_GEN_ARM_FILE */"
>   	print "#undef __INCL_GEN_ARM_FILE"
>   	print ""
> +	print "__diag_push()"
> +	print "__diag_ignore_all(\"-Wunused-function\", \"tolerate unused functions shared from arm64\")"
> +	print ""
>   
>   	file_header_done = 1
>   }
> @@ -78,5 +81,10 @@ copying {
>   }
>   
>   END {
> -	exit error || !found_marker || copying
> +	ok = !error && found_marker && !copying
> +	if (ok) {
> +		print ""
> +		print "__diag_pop()"
> +	}
> +	exit !ok
>   }
> 
> ---
> base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
> change-id: 20261105-series1-fixups2-8ce6cc54a21f
> 
> Best regards,