Re: [PATCH v4 6/9] net/i40e/base: fix unused value warnings

["Burakov, Anatoly" <anatoly.burakov@intel.com>]

On 3/28/2025 12:16 PM, Bruce Richardson wrote:
> Fix warnings about unused values - parameters, variables, etc., and
> remove the warning disable flags for them. Although modifying the
> base-code files is not ideal, the changes required are minor, and only
> affect two files from the imported base code.
> 
> Fixes: 8db9e2a1b232 ("i40e: base driver")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>   drivers/net/intel/i40e/base/i40e_nvm.c   |  2 +-
>   drivers/net/intel/i40e/base/i40e_osdep.h |  4 ++--
>   drivers/net/intel/i40e/base/i40e_type.h  | 14 +++++++++-----
>   drivers/net/intel/i40e/base/meson.build  |  3 ---
>   drivers/net/intel/i40e/i40e_ethdev.c     |  1 +
>   5 files changed, 13 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/net/intel/i40e/base/i40e_nvm.c b/drivers/net/intel/i40e/base/i40e_nvm.c
> index 3e16a0d997..56dc4d9279 100644
> --- a/drivers/net/intel/i40e/base/i40e_nvm.c
> +++ b/drivers/net/intel/i40e/base/i40e_nvm.c
> @@ -1743,7 +1743,7 @@ STATIC enum i40e_status_code i40e_nvmupd_get_aq_result(struct i40e_hw *hw,
>    **/
>   STATIC enum i40e_status_code i40e_nvmupd_get_aq_event(struct i40e_hw *hw,
>   						    struct i40e_nvm_access *cmd,
> -						    u8 *bytes, int *perrno)
> +						    u8 *bytes, __rte_unused int *perrno)

I don't think we should be adding __rte_unused to base code, there's 
probably a macro for it in osdep? If not, maybe add 
UNREFERENCED_1PARAMETER in code?

For other parts,

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly