From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
"Wei Liu" <wl@xen.org>, "Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH v2] x86/cpuid: Extend the cpuid= option to support all named features
Date: Wed, 25 Sep 2019 13:32:19 +0100 [thread overview]
Message-ID: <8b7e7d18-cdec-dbd1-e11f-7058b2646b5a@citrix.com> (raw)
In-Reply-To: <0d059668-7e2d-e5ca-4946-7024ec680bb8@suse.com>
On 25/09/2019 13:30, Jan Beulich wrote:
> On 05.09.2019 21:49, Andrew Cooper wrote:
>> For gen-cpuid.py, fix a comment describing self.names, and generate the
>> reverse mapping in self.values. Write out INIT_FEATURE_NAMES which maps a
>> string name to a bit position.
>>
>> For parse_cpuid(), use cmdline_strcmp() and perform a binary search over
>> INIT_FEATURE_NAMES. A tweak to cmdline_strcmp() is needed to break at equals
>> signs as well.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> ---
>> CC: Jan Beulich <JBeulich@suse.com>
>> CC: Wei Liu <wl@xen.org>
>> CC: Roger Pau Monné <roger.pau@citrix.com>
>>
>> v2:
>> * Rebase over cmdline_strcmp()
>> ---
>> xen/arch/x86/cpuid.c | 75 +++++++++++++++++++++++++++++++-------------------
>> xen/common/kernel.c | 6 ++--
>> xen/include/xen/lib.h | 4 +--
>> xen/tools/gen-cpuid.py | 22 +++++++++++++--
>> 4 files changed, 71 insertions(+), 36 deletions(-)
> I've noticed this only now: This change would have wanted to be
> accompanied by an adjustment to the command line doc.
I debated that, but I don't want to give people the idea that using
cpuid=no-lm might be a sensible thing to do.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-09-25 12:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 19:49 [Xen-devel] [PATCH v2] x86/cpuid: Extend the cpuid= option to support all named features Andrew Cooper
2019-09-06 15:18 ` Jan Beulich
2019-09-06 15:27 ` Andrew Cooper
2019-09-06 15:54 ` Jan Beulich
2019-09-25 12:30 ` Jan Beulich
2019-09-25 12:32 ` Andrew Cooper [this message]
2019-09-25 12:39 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b7e7d18-cdec-dbd1-e11f-7058b2646b5a@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.