From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C3F3C433FE for ; Mon, 28 Nov 2022 09:00:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uxQ4Op4wJkfy+E4USfATcQwka4uMnYgoKUlk7fhdGSE=; b=Lgnbxoegp45ai5vCioseVLe/sl 3XUg91J2yITkIsoiIA1AFaSc1JakVuHU3KVUhuQUb7QxgSQVQndS799dct6XuAUoOF6RlHwCOhy3F WEDkOl7hqtcAY9dslKRJ8hriBynEmKIj/8ziUrKZ6mM+Mhi1fOdc4NoiyqfJJE5H9VbUoOqCtnT23 EUM0XfG9Ak8T3RRh6v8HIBZhlOr206Rb8n85INpWnSjZp2aysYOJSl+tAl6Ybf6/3G3UrOIAPhRtG nPiKtMwbJ+YRb7DzWKPjBlnj51dhLjs3r9BoKQb543rynXTBxe+tTP8YxgeFlNYzS6IzAwkqhPS2c bN1QrJEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozZzz-000S07-E0; Mon, 28 Nov 2022 09:00:23 +0000 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozZzv-000Rx2-03 for linux-mediatek@lists.infradead.org; Mon, 28 Nov 2022 09:00:20 +0000 Received: by mail-lf1-x136.google.com with SMTP id j16so16255607lfe.12 for ; Mon, 28 Nov 2022 01:00:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uxQ4Op4wJkfy+E4USfATcQwka4uMnYgoKUlk7fhdGSE=; b=vYdb5XXPSaGwuCoLSVoXRdQxnPaAziy9sgNBD8ranp2ceRSNgedYCPqR4S0vLEMnU5 P7HmMByv0VoBFVxh3uq65mFCK6MQA3c0f560kARTzEWaiHCOOyVKCJTkHV4l3S0g0eq6 vyrw/O9/ZX1QkVXD18yE6C+NWMpaloiZ48EArn/TOG2veHbj9d1Vcemour9Z1xigBKa3 RpQk3CTgz6qadxdn6IuvgcjwozjTQ3KcPOCBhwr3enogTDQR0PzTks2bn9+1k7OhHpBq tbyLx/EFDgvPrd35WmKItzN43WvkclKutLtUhhSEvey4QSfvY342K6flzqPRcf5xJC5F updg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uxQ4Op4wJkfy+E4USfATcQwka4uMnYgoKUlk7fhdGSE=; b=KyJbZY7VJQIcC45p76a9n9WOlLZIJNnEVrR4BIbUpYfEvgUjO9vL0OeqhzNEFbOVip tVWVCOOB93aEQT6mV1xpnR1dTki9oer8n/gHX90XCC5apE/rnkIrAWnu4kyfqjE4eZxH GsmY4jjVjALlDQwawLnzlLhgA4x9mQIop/1R+CCDOHV/jPCR+3l5HxwyqJJneE51723y okETEv5RfBSiM/6sdDN5FZyHM61Oax9kzLE88zWtcQazXvwpS09Fr2OW9inFJ15Tw6Gl hE1L0DXJUsPGu5DPrGztQqoPps2WfTFbl90lBxg0s0kBj0i8tfCz1P3ZW/P8vdJkfDm6 HsUw== X-Gm-Message-State: ANoB5pniVLFum3q96+8iRzQx+QgHq0yS0MHHfKAp5HyLEGI+4tYPq0pZ w0Ur6NcXHytGLwCJ5ndkvTdx0A== X-Google-Smtp-Source: AA0mqf4yCrmsZoHkLNUdgjrfnhNmrW+jAyoF8Yth5MPBnrKTzOxQXVV9S2/fv4YTu9XRNKVY+0RP+Q== X-Received: by 2002:ac2:52aa:0:b0:4b1:fc9:429f with SMTP id r10-20020ac252aa000000b004b10fc9429fmr17759584lfm.84.1669626015128; Mon, 28 Nov 2022 01:00:15 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id v28-20020a05651203bc00b0048a757d1303sm1655307lfp.217.2022.11.28.01.00.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Nov 2022 01:00:14 -0800 (PST) Message-ID: <8b8e4b23-a3bc-7e3d-199a-e8f591d05d71@linaro.org> Date: Mon, 28 Nov 2022 10:00:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 5/9] dt-bindings: spi: mtk-snfi: add mt7986 IC snfi bindings Content-Language: en-US To: Xiangsheng Hou , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Mark Brown , Chuanhong Guo Cc: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, benliang.zhao@mediatek.com, bin.zhang@mediatek.com References: <20221128020613.14821-1-xiangsheng.hou@mediatek.com> <20221128020613.14821-6-xiangsheng.hou@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <20221128020613.14821-6-xiangsheng.hou@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221128_010019_076340_DB1B70C3 X-CRM114-Status: GOOD ( 14.88 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 28/11/2022 03:06, Xiangsheng Hou wrote: > 1. add mt7986 IC bindings Subject: drop second, redundant "bindings". > 2. add optional nfi_hclk property which needed for mt7986 > > Signed-off-by: Xiangsheng Hou > --- > .../devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml > index 6e6e02c91780..ee20075cd0e7 100644 > --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml > +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml > @@ -26,6 +26,7 @@ properties: > enum: > - mediatek,mt7622-snand > - mediatek,mt7629-snand > + - mediatek,mt7986-snand > > reg: > items: > @@ -36,14 +37,19 @@ properties: > - description: NFI interrupt > > clocks: > + minItems: 2 > items: > - description: clock used for the controller > - description: clock used for the SPI bus > + - description: clock used for the AHB bus dma bus, this depends on > + hardware design, so this is optional. Optional for which variants? For all of them? > > clock-names: > + minItems: 2 > items: > - const: nfi_clk > - const: pad_clk > + - const: nfi_hclk Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16472C4332F for ; Mon, 28 Nov 2022 09:00:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3rjJsmgvj+ZtVPveSuLhwtjfQvoxLBKWtNkDpIDZ2XA=; b=cRiNO4qK0z41VO fU11y9SWyQRi6KN0UyZ81fHQgp1kHiD/eMFJMQEu5lkcqd4M4wZXw68OR/w+N4MoDHUi4cKBvlA8S 0riCwCvr/81oiCVX5AFtVdHp/pXmvwqVjCuoZOf92TXNrEsg3v9B14EXeBHB/qlsQ+BsO6jfNsqcK 7NOyMPduA/OeeL4r2bh2hMbzKfrAnFLtu8kyiX+Z39OXhNNnIp5yc6u5xzUJTrsHqch4ltmCqAEkL KeEksYAv1tL8q8EwlzaqKS1ehyHJN5C1c/NK5nIiYl7Uk11siqrGzFP8LPxT8nTtYEYOG7JUgAF6m ambmILMmfl0xviNrblwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozZzx-000Rz7-Ne; Mon, 28 Nov 2022 09:00:21 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozZzu-000Rx1-WC for linux-mtd@lists.infradead.org; Mon, 28 Nov 2022 09:00:20 +0000 Received: by mail-lf1-x12e.google.com with SMTP id b3so16310266lfv.2 for ; Mon, 28 Nov 2022 01:00:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uxQ4Op4wJkfy+E4USfATcQwka4uMnYgoKUlk7fhdGSE=; b=vYdb5XXPSaGwuCoLSVoXRdQxnPaAziy9sgNBD8ranp2ceRSNgedYCPqR4S0vLEMnU5 P7HmMByv0VoBFVxh3uq65mFCK6MQA3c0f560kARTzEWaiHCOOyVKCJTkHV4l3S0g0eq6 vyrw/O9/ZX1QkVXD18yE6C+NWMpaloiZ48EArn/TOG2veHbj9d1Vcemour9Z1xigBKa3 RpQk3CTgz6qadxdn6IuvgcjwozjTQ3KcPOCBhwr3enogTDQR0PzTks2bn9+1k7OhHpBq tbyLx/EFDgvPrd35WmKItzN43WvkclKutLtUhhSEvey4QSfvY342K6flzqPRcf5xJC5F updg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uxQ4Op4wJkfy+E4USfATcQwka4uMnYgoKUlk7fhdGSE=; b=tRFJ8O975YAyCGQtDLvvrQwiO48ZxaKedtSH/WFpIEg8CWlhwkgR67zDmcnShkXwTX 9KzSd1+rVN3ZuT1odggYPxR31qYw9fKAK5dGIWYPxvn9Q9teFKMTh0nrDE0SSDTyZaMQ x4wYGijRkoyFSzeWtyuOLuewqzqEuQDkWSFT03IOOPjo3SbR7mcq7rTTUYR4YrB9eSW5 DsGB9yBbqGfe1gTDpQlQKW4E4gr9T/+o/y0xwSB9J+oOKbDLAwZC5XIfnjMdinzGGp/S RC5PBCVZGGzc5vdj8M1SPOdR0sckGpmr9MFWfjGl2vcoUf+ajympRtjWRQwf3b9q1rNJ OqIQ== X-Gm-Message-State: ANoB5pmVdC49qiiuZDgi+CxwxeNoLLqCwad+fMyzzBDqhnC3+THHzqs7 KN8yhaY7BCguhO/5h3V8Ohl5gQ== X-Google-Smtp-Source: AA0mqf4yCrmsZoHkLNUdgjrfnhNmrW+jAyoF8Yth5MPBnrKTzOxQXVV9S2/fv4YTu9XRNKVY+0RP+Q== X-Received: by 2002:ac2:52aa:0:b0:4b1:fc9:429f with SMTP id r10-20020ac252aa000000b004b10fc9429fmr17759584lfm.84.1669626015128; Mon, 28 Nov 2022 01:00:15 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id v28-20020a05651203bc00b0048a757d1303sm1655307lfp.217.2022.11.28.01.00.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Nov 2022 01:00:14 -0800 (PST) Message-ID: <8b8e4b23-a3bc-7e3d-199a-e8f591d05d71@linaro.org> Date: Mon, 28 Nov 2022 10:00:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 5/9] dt-bindings: spi: mtk-snfi: add mt7986 IC snfi bindings Content-Language: en-US To: Xiangsheng Hou , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Mark Brown , Chuanhong Guo Cc: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, benliang.zhao@mediatek.com, bin.zhang@mediatek.com References: <20221128020613.14821-1-xiangsheng.hou@mediatek.com> <20221128020613.14821-6-xiangsheng.hou@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <20221128020613.14821-6-xiangsheng.hou@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221128_010019_071670_EF668B9C X-CRM114-Status: GOOD ( 15.51 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On 28/11/2022 03:06, Xiangsheng Hou wrote: > 1. add mt7986 IC bindings Subject: drop second, redundant "bindings". > 2. add optional nfi_hclk property which needed for mt7986 > > Signed-off-by: Xiangsheng Hou > --- > .../devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml > index 6e6e02c91780..ee20075cd0e7 100644 > --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml > +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml > @@ -26,6 +26,7 @@ properties: > enum: > - mediatek,mt7622-snand > - mediatek,mt7629-snand > + - mediatek,mt7986-snand > > reg: > items: > @@ -36,14 +37,19 @@ properties: > - description: NFI interrupt > > clocks: > + minItems: 2 > items: > - description: clock used for the controller > - description: clock used for the SPI bus > + - description: clock used for the AHB bus dma bus, this depends on > + hardware design, so this is optional. Optional for which variants? For all of them? > > clock-names: > + minItems: 2 > items: > - const: nfi_clk > - const: pad_clk > + - const: nfi_hclk Best regards, Krzysztof ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5201AC4332F for ; Mon, 28 Nov 2022 09:01:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2WbqXs28jYP/cCB3A0LDAxqrlDvw+Sj62QKHgAQzD0o=; b=08d4MbS+V8HTbM s+bYi2MYB1/ewoE25XRoibJL5C448ll7CJhHBA4fLzdA7N7OEXFEvCEa4azgXwynkGGgGlz76kcTT 90RIwaYV7ohqXXq8fIyZYSaHJL1V1IsOpYzD/1b2urvhWwb6a1kmYu7exj8PdTLdVZXhseSiM9oUE f0QN76h40C8aY4HgnEa6B0Z/Yc8ZzkpwJvzPcz7SpTs9SmzGmkw+zvU9WljoAlJQs9kCrz5mohLj7 a24BpOaPgrbdZgK5bndtLJ1jgGsM4jZhjE/SSOujXP7qU7hlKhSoQeEiwgXArmhG/dnN1umPV/u96 YhWgskXLE3XMr0bIz0sg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oza00-000S0O-OA; Mon, 28 Nov 2022 09:00:24 +0000 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozZzv-000Rx3-01 for linux-arm-kernel@lists.infradead.org; Mon, 28 Nov 2022 09:00:21 +0000 Received: by mail-lf1-x129.google.com with SMTP id d6so16285043lfs.10 for ; Mon, 28 Nov 2022 01:00:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uxQ4Op4wJkfy+E4USfATcQwka4uMnYgoKUlk7fhdGSE=; b=vYdb5XXPSaGwuCoLSVoXRdQxnPaAziy9sgNBD8ranp2ceRSNgedYCPqR4S0vLEMnU5 P7HmMByv0VoBFVxh3uq65mFCK6MQA3c0f560kARTzEWaiHCOOyVKCJTkHV4l3S0g0eq6 vyrw/O9/ZX1QkVXD18yE6C+NWMpaloiZ48EArn/TOG2veHbj9d1Vcemour9Z1xigBKa3 RpQk3CTgz6qadxdn6IuvgcjwozjTQ3KcPOCBhwr3enogTDQR0PzTks2bn9+1k7OhHpBq tbyLx/EFDgvPrd35WmKItzN43WvkclKutLtUhhSEvey4QSfvY342K6flzqPRcf5xJC5F updg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uxQ4Op4wJkfy+E4USfATcQwka4uMnYgoKUlk7fhdGSE=; b=wmmQJ44lzT6Kz6svILL63uy6fjrXj459AXAmZq9vEJnunZf/ss6N+JTWggHFQbHVF1 LsD+qyDvgtx1J6rJAdm6H4Ux31sCAyANU8hoXsoiPErK6san85oh5TSybqonLf2y3D2U irLTLs73J1B+pdHYa2UKVfAtO0NIXDSquPzf50ANLZitX7JPScybVkw1Oy158b+Ff67q DQdqOQNAUyfgjiD7heVLBc+e4uxx8auELb8LP4hdiCNynxtzfvypaYlnzL9b6GfrQDXr YKqozX+SHfQtqXbFYnBWkS6q90i/CnyRSpzb4lEBZ+pMNn8nhjukZubkBU8RxhLu1JB6 P+ZQ== X-Gm-Message-State: ANoB5pnmZmMFuriECMUP4pGxJSPd0ZkloTc3l7Bqxxz85xj3Jm2hKcov exv6vwSlGb7WKCSG3XJDApz7YA== X-Google-Smtp-Source: AA0mqf4yCrmsZoHkLNUdgjrfnhNmrW+jAyoF8Yth5MPBnrKTzOxQXVV9S2/fv4YTu9XRNKVY+0RP+Q== X-Received: by 2002:ac2:52aa:0:b0:4b1:fc9:429f with SMTP id r10-20020ac252aa000000b004b10fc9429fmr17759584lfm.84.1669626015128; Mon, 28 Nov 2022 01:00:15 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id v28-20020a05651203bc00b0048a757d1303sm1655307lfp.217.2022.11.28.01.00.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Nov 2022 01:00:14 -0800 (PST) Message-ID: <8b8e4b23-a3bc-7e3d-199a-e8f591d05d71@linaro.org> Date: Mon, 28 Nov 2022 10:00:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 5/9] dt-bindings: spi: mtk-snfi: add mt7986 IC snfi bindings Content-Language: en-US To: Xiangsheng Hou , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Mark Brown , Chuanhong Guo Cc: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, benliang.zhao@mediatek.com, bin.zhang@mediatek.com References: <20221128020613.14821-1-xiangsheng.hou@mediatek.com> <20221128020613.14821-6-xiangsheng.hou@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <20221128020613.14821-6-xiangsheng.hou@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221128_010019_071048_278F47A6 X-CRM114-Status: GOOD ( 16.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28/11/2022 03:06, Xiangsheng Hou wrote: > 1. add mt7986 IC bindings Subject: drop second, redundant "bindings". > 2. add optional nfi_hclk property which needed for mt7986 > > Signed-off-by: Xiangsheng Hou > --- > .../devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml > index 6e6e02c91780..ee20075cd0e7 100644 > --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml > +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml > @@ -26,6 +26,7 @@ properties: > enum: > - mediatek,mt7622-snand > - mediatek,mt7629-snand > + - mediatek,mt7986-snand > > reg: > items: > @@ -36,14 +37,19 @@ properties: > - description: NFI interrupt > > clocks: > + minItems: 2 > items: > - description: clock used for the controller > - description: clock used for the SPI bus > + - description: clock used for the AHB bus dma bus, this depends on > + hardware design, so this is optional. Optional for which variants? For all of them? > > clock-names: > + minItems: 2 > items: > - const: nfi_clk > - const: pad_clk > + - const: nfi_hclk Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel