From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8AC0FF8850 for ; Mon, 27 Apr 2026 00:42:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject:Cc: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DphAJKAZoOBFmM5J4v7APra/1tcB8OeyseLSxqYYfJc=; b=InKkRAV4FJk5gu 5ivVloD3OFdscUotEtmw2f8wNMQBT/3uDnzxTN1AtP7OFdTIElbVuGUDJ4KNTzlpmkPbUW4/9o/6X 6PxREGrN4wQn8Pagr/VMVp315SBIUJf1dSgBm8RwyJNmCm+NimZ8yFVcfmvBYdzfX5ovV9rCTb/5H KF1aut/n5ch38YuYmAJcIsm4u0GpaWss8Qvgu71VKcKv8u39ASwO6Gn+kJ1fAMyqPqfe8wy5Q2qaU OTyegMVQkL4tEK4DTLPV8jDhE0IfZdmbZLaBiXdDsume5vKvyjwnirXp9+wn5MjunqAooFX1slnPN /JNIv4ZVvNbRWalbhKmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wHA3b-0000000Fyjl-0ks3; Mon, 27 Apr 2026 00:42:39 +0000 Received: from mail-m478512530.xmail.ntesmail.com ([47.85.125.30]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wHA3X-0000000FyjL-2Fv7; Mon, 27 Apr 2026 00:42:38 +0000 Received: from [172.16.12.17] (unknown [61.154.14.86]) by smtp.qiye.163.com (Hmail) with ESMTP id 3c3314299; Mon, 27 Apr 2026 08:42:18 +0800 (GMT+08:00) Message-ID: <8b8ea5e8-4e1a-41e7-b377-0a4246609cf4@rock-chips.com> Date: Mon, 27 Apr 2026 08:42:16 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: shawn.lin@rock-chips.com, linux-rockchip@lists.infradead.org, Heiko Stuebner , Neil Armstrong , linux-kernel@vger.kernel.org Subject: Re: [PATCH] phy: rockchip: naneng-combphy: Fix TX detect RX termination errata To: Vinod Koul , linux-phy@lists.infradead.org References: <1774423383-36599-1-git-send-email-shawn.lin@rock-chips.com> From: Shawn Lin In-Reply-To: <1774423383-36599-1-git-send-email-shawn.lin@rock-chips.com> X-HM-Tid: 0a9dcc63143c09cckunmc5962bd51746c4 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFITzdXWRgWCB1ZQUpXWS1ZQUlXWQ8JGhUIEh9ZQVlCHkpKVkweGh9LGEpKSh8fS1YVFA kWGhdVEwETFhoSFyQUDg9ZV1kYEgtZQVlNSlVKTk9VSk9VQ01ZV1kWGg8SFR0UWUFZT0tIVUpLSU 9PT0hVSktLVUpCS0tZBg++ DKIM-Signature: a=rsa-sha256; b=IjSoo2P0FJMHK5MMBUpKSypXR5a7rsvOxpIZmjilqnCPppzaDlEiEnBbJbfk1AEDCEVyqAlY2QkIpJMDEs4dEMUgqtSrCXN2sDqlya/nXN42m+uu5Q1UgpM3OI89eYqZkSJQ1HEAQUp1YHWyvEIzZi+oSd95GnWwRwCi6YqNWmo=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=3HoksNeI6ZtKSz9ycILX9bag3CMDi7LUrvjdbGKG7Jc=; h=date:mime-version:subject:message-id:from; X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260426_174236_896774_67BD5C40 X-CRM114-Status: GOOD ( 17.50 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org UGluZy4uLgoK5ZyoIDIwMjYvMDMvMjUg5pif5pyf5LiJIDE1OjIzLCBTaGF3biBMaW4g5YaZ6YGT Ogo+IFNvbWUgUEhZIHJldmlzaW9ucyBtYXkgZmFpbCB0byBkZXRlY3QgdGhlIHBlZXIgUlgncyB0 ZXJtaW5hdGlvbgo+IHJlc2lzdG9yIChSVEVSTSkgdW5kZXIgY2VydGFpbiBjcml0aWNhbCB0ZW1w ZXJhdHVyZSBjb25kaXRpb25zLgo+IFRoaXMgY2F1c2VzIFRYIGRldGVjdGlvbiBmYWlsdXJlcyBv biBQQ0llIGxpbmtzLgo+IAo+IEFkZCBhIHdvcmthcm91bmQgdG8gZm9yY2UgdGhlIFJURVJNIGRl dGVjdGlvbiByZWFkeSBzaWduYWwgZm9yCj4gYWZmZWN0ZWQgUEhZIHJldmlzaW9ucy4gVGhpcyBl bnN1cmVzIHJlbGlhYmxlIFRYLXRvLVJYIHRlcm1pbmF0aW9uCj4gZGV0ZWN0aW9uIGFjcm9zcyBh bGwgb3BlcmF0aW5nIHRlbXBlcmF0dXJlIHJhbmdlcy4KPiAKPiBUaGUgZml4IGFwcGxpZXMgdG8g UkszNTYyLCBSSzM1NjgsIFJLMzU3NiBhbmQgUkszNTg4IFNvQ3Mgd2hpY2ggc2hhcmUKPiB0aGUg c2FtZSBQSFkgSVAgd2l0aCB0aGlzIGhhcmR3YXJlIGVycmF0YS4KPiAKPiBTaWduZWQtb2ZmLWJ5 OiBTaGF3biBMaW4gPHNoYXduLmxpbkByb2NrLWNoaXBzLmNvbT4KPiAtLS0KPiAKPiAgIGRyaXZl cnMvcGh5L3JvY2tjaGlwL3BoeS1yb2NrY2hpcC1uYW5lbmctY29tYnBoeS5jIHwgMTkgKysrKysr KysrKysrKysrKysrKwo+ICAgMSBmaWxlIGNoYW5nZWQsIDE5IGluc2VydGlvbnMoKykKPiAKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9waHkvcm9ja2NoaXAvcGh5LXJvY2tjaGlwLW5hbmVuZy1jb21i cGh5LmMgYi9kcml2ZXJzL3BoeS9yb2NrY2hpcC9waHktcm9ja2NoaXAtbmFuZW5nLWNvbWJwaHku Ywo+IGluZGV4IGI2MGQ2YmYuLjc2ZDQ5OTQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9waHkvcm9j a2NoaXAvcGh5LXJvY2tjaGlwLW5hbmVuZy1jb21icGh5LmMKPiArKysgYi9kcml2ZXJzL3BoeS9y b2NrY2hpcC9waHktcm9ja2NoaXAtbmFuZW5nLWNvbWJwaHkuYwo+IEBAIC0xMDYsNiArMTA2LDkg QEAKPiAgICNkZWZpbmUgUkszNTY4X1BIWVJFRzE4CQkJCTB4NDQKPiAgICNkZWZpbmUgUkszNTY4 X1BIWVJFRzE4X1BMTF9MT09QCQkweDMyCj4gICAKPiArI2RlZmluZSBSSzM1NjhfUEhZUkVHMjYJ CQkJMHg2NAo+ICsjZGVmaW5lIFJLMzU2OF9QSFlSRUcyNl9GT1JDRV9SVEVSTV9ERVRfUkRZCUJJ VCg1KQo+ICsKPiAgICNkZWZpbmUgUkszNTY4X1BIWVJFRzMwCQkJCTB4NzQKPiAgICNkZWZpbmUg UkszNTY4X1BIWVJFRzMwX0dBVEVfVFhfUENLX1NFTCAgICAgICAgIEJJVCg3KQo+ICAgI2RlZmlu ZSBSSzM1NjhfUEhZUkVHMzBfR0FURV9UWF9QQ0tfRExZX1BMTF9PRkYgQklUKDcpCj4gQEAgLTE5 Myw2ICsxOTYsNyBAQCBzdHJ1Y3Qgcm9ja2NoaXBfY29tYnBoeV9jZmcgewo+ICAgCXVuc2lnbmVk IGludCBudW1fcGh5czsKPiAgIAl1bnNpZ25lZCBpbnQgcGh5X2lkc1szXTsKPiAgIAljb25zdCBz dHJ1Y3Qgcm9ja2NoaXBfY29tYnBoeV9ncmZjZmcgKmdyZmNmZzsKPiArCWJvb2wgZm9yY2Vfcnh0 ZXJtX2RldF9yZHk7Cj4gICAJaW50ICgqY29tYnBoeV9jZmcpKHN0cnVjdCByb2NrY2hpcF9jb21i cGh5X3ByaXYgKnByaXYpOwo+ICAgfTsKPiAgIAo+IEBAIC0yNjQsNiArMjY4LDE3IEBAIHN0YXRp YyBpbnQgcm9ja2NoaXBfY29tYnBoeV9pbml0KHN0cnVjdCBwaHkgKnBoeSkKPiAgIAo+ICAgCXN3 aXRjaCAocHJpdi0+dHlwZSkgewo+ICAgCWNhc2UgUEhZX1RZUEVfUENJRToKPiArCQkvKgo+ICsJ CSAqIEhhcmR3YXJlIEVycmF0YTogVFggZmFpbHMgdG8gZGV0ZWN0IHBlZXIgUlggdGVybWluYXRp b24uCj4gKwkJICogU29tZSBQSFkgcmV2aXNpb25zIG1heSBmYWlsIHRvIGRldGVjdCByZW1vdGUg UlgncyBSVEVSTQo+ICsJCSAqIChyZWNlaXZlciB0ZXJtaW5hdGlvbiByZXNpc3RvcikgdW5kZXIg Y2VydGFpbiBjcml0aWNhbAo+ICsJCSAqIHRlbXBlcmF0dXJlIGNvbmRpdGlvbnMuIFNldCBmb3Jj ZSBydGVybSBkZXRlY3QgcmVhZHkgdG8KPiArCQkgKiBmaXggaXQuCj4gKwkJICovCj4gKwkJaWYg KHByaXYtPmNmZy0+Zm9yY2Vfcnh0ZXJtX2RldF9yZHkpCj4gKwkJCXJvY2tjaGlwX2NvbWJwaHlf dXBkYXRlbChwcml2LCBSSzM1NjhfUEhZUkVHMjZfRk9SQ0VfUlRFUk1fREVUX1JEWSwKPiArCQkJ CQlSSzM1NjhfUEhZUkVHMjZfRk9SQ0VfUlRFUk1fREVUX1JEWSwgUkszNTY4X1BIWVJFRzI2KTsK PiArCQlmYWxsdGhyb3VnaDsKPiAgIAljYXNlIFBIWV9UWVBFX1VTQjM6Cj4gICAJY2FzZSBQSFlf VFlQRV9TQVRBOgo+ICAgCWNhc2UgUEhZX1RZUEVfU0dNSUk6Cj4gQEAgLTc0NSw2ICs3NjAsNyBA QCBzdGF0aWMgY29uc3Qgc3RydWN0IHJvY2tjaGlwX2NvbWJwaHlfY2ZnIHJrMzU2Ml9jb21icGh5 X2NmZ3MgPSB7Cj4gICAJfSwKPiAgIAkuZ3JmY2ZnCQk9ICZyazM1NjJfY29tYnBoeV9ncmZjZmdz LAo+ICAgCS5jb21icGh5X2NmZwk9IHJrMzU2Ml9jb21icGh5X2NmZywKPiArCS5mb3JjZV9yeHRl cm1fZGV0X3JkeSAgPSB0cnVlLAo+ICAgfTsKPiAgIAo+ICAgc3RhdGljIGludCByazM1NjhfY29t YnBoeV9jZmcoc3RydWN0IHJvY2tjaGlwX2NvbWJwaHlfcHJpdiAqcHJpdikKPiBAQCAtOTYyLDYg Kzk3OCw3IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3Qgcm9ja2NoaXBfY29tYnBoeV9jZmcgcmszNTY4 X2NvbWJwaHlfY2ZncyA9IHsKPiAgIAl9LAo+ICAgCS5ncmZjZmcJCT0gJnJrMzU2OF9jb21icGh5 X2dyZmNmZ3MsCj4gICAJLmNvbWJwaHlfY2ZnCT0gcmszNTY4X2NvbWJwaHlfY2ZnLAo+ICsJLmZv cmNlX3J4dGVybV9kZXRfcmR5ICA9IHRydWUsCj4gICB9Owo+ICAgCj4gICBzdGF0aWMgaW50IHJr MzU3Nl9jb21icGh5X2NmZyhzdHJ1Y3Qgcm9ja2NoaXBfY29tYnBoeV9wcml2ICpwcml2KQo+IEBA IC0xMjMxLDYgKzEyNDgsNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IHJvY2tjaGlwX2NvbWJwaHlf Y2ZnIHJrMzU3Nl9jb21icGh5X2NmZ3MgPSB7Cj4gICAJfSwKPiAgIAkuZ3JmY2ZnCQk9ICZyazM1 NzZfY29tYnBoeV9ncmZjZmdzLAo+ICAgCS5jb21icGh5X2NmZwk9IHJrMzU3Nl9jb21icGh5X2Nm ZywKPiArCS5mb3JjZV9yeHRlcm1fZGV0X3JkeSAgPSB0cnVlLAo+ICAgfTsKPiAgIAo+ICAgc3Rh dGljIGludCByazM1ODhfY29tYnBoeV9jZmcoc3RydWN0IHJvY2tjaGlwX2NvbWJwaHlfcHJpdiAq cHJpdikKPiBAQCAtMTQxOCw2ICsxNDM2LDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCByb2NrY2hp cF9jb21icGh5X2NmZyByazM1ODhfY29tYnBoeV9jZmdzID0gewo+ICAgCX0sCj4gICAJLmdyZmNm ZwkJPSAmcmszNTg4X2NvbWJwaHlfZ3JmY2ZncywKPiAgIAkuY29tYnBoeV9jZmcJPSByazM1ODhf Y29tYnBoeV9jZmcsCj4gKwkuZm9yY2Vfcnh0ZXJtX2RldF9yZHkgID0gdHJ1ZSwKPiAgIH07Cj4g ICAKPiAgIHN0YXRpYyBjb25zdCBzdHJ1Y3Qgb2ZfZGV2aWNlX2lkIHJvY2tjaGlwX2NvbWJwaHlf b2ZfbWF0Y2hbXSA9IHsKCi0tIApsaW51eC1waHkgbWFpbGluZyBsaXN0CmxpbnV4LXBoeUBsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LXBoeQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1B38BFF8850 for ; Mon, 27 Apr 2026 00:42:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject:Cc: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SIBP2SL+xDNaUj3OG/OETPHvVuMK6+fz7bKLsNt76SA=; b=TGLBmG6w7AnHMl fi7uziHmgzCFQPoMk7yJQAyAf4AeuS7tsYmTQU9tV4y7zZsD+ZKPpor7d4nosbVDz03WJH9VdJy1K IQU+zwDF3rz2Khaf0RzEyGSeRXFYMQWNjgwEqJVqgBqjW2eR9cIDUAG8kIRUfsx5DN6HWv/Eg6u3L 9nVLE6IY9FSXDGovImI0VHUMT7GBKfy3fn/g2a4sgoon4rzYJ+8tGtyEXmULntGacpGO6G0SOVavm dZxy5ovqy8WTqJk5RhnmfTTIN3sHa2ytZJZDOZCqrdrbRoLe+ZecQTvXdJLJ5bGg7N1c/tgKZOWTN vaLyrA7JRW7sImFcaQmw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wHA3b-0000000Fyjs-1pqj; Mon, 27 Apr 2026 00:42:39 +0000 Received: from mail-m478512530.xmail.ntesmail.com ([47.85.125.30]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wHA3X-0000000FyjL-2Fv7; Mon, 27 Apr 2026 00:42:38 +0000 Received: from [172.16.12.17] (unknown [61.154.14.86]) by smtp.qiye.163.com (Hmail) with ESMTP id 3c3314299; Mon, 27 Apr 2026 08:42:18 +0800 (GMT+08:00) Message-ID: <8b8ea5e8-4e1a-41e7-b377-0a4246609cf4@rock-chips.com> Date: Mon, 27 Apr 2026 08:42:16 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: shawn.lin@rock-chips.com, linux-rockchip@lists.infradead.org, Heiko Stuebner , Neil Armstrong , linux-kernel@vger.kernel.org Subject: Re: [PATCH] phy: rockchip: naneng-combphy: Fix TX detect RX termination errata To: Vinod Koul , linux-phy@lists.infradead.org References: <1774423383-36599-1-git-send-email-shawn.lin@rock-chips.com> From: Shawn Lin In-Reply-To: <1774423383-36599-1-git-send-email-shawn.lin@rock-chips.com> X-HM-Tid: 0a9dcc63143c09cckunmc5962bd51746c4 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFITzdXWRgWCB1ZQUpXWS1ZQUlXWQ8JGhUIEh9ZQVlCHkpKVkweGh9LGEpKSh8fS1YVFA kWGhdVEwETFhoSFyQUDg9ZV1kYEgtZQVlNSlVKTk9VSk9VQ01ZV1kWGg8SFR0UWUFZT0tIVUpLSU 9PT0hVSktLVUpCS0tZBg++ DKIM-Signature: a=rsa-sha256; b=IjSoo2P0FJMHK5MMBUpKSypXR5a7rsvOxpIZmjilqnCPppzaDlEiEnBbJbfk1AEDCEVyqAlY2QkIpJMDEs4dEMUgqtSrCXN2sDqlya/nXN42m+uu5Q1UgpM3OI89eYqZkSJQ1HEAQUp1YHWyvEIzZi+oSd95GnWwRwCi6YqNWmo=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=3HoksNeI6ZtKSz9ycILX9bag3CMDi7LUrvjdbGKG7Jc=; h=date:mime-version:subject:message-id:from; X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260426_174236_896774_67BD5C40 X-CRM114-Status: GOOD ( 17.50 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org UGluZy4uLgoK5ZyoIDIwMjYvMDMvMjUg5pif5pyf5LiJIDE1OjIzLCBTaGF3biBMaW4g5YaZ6YGT Ogo+IFNvbWUgUEhZIHJldmlzaW9ucyBtYXkgZmFpbCB0byBkZXRlY3QgdGhlIHBlZXIgUlgncyB0 ZXJtaW5hdGlvbgo+IHJlc2lzdG9yIChSVEVSTSkgdW5kZXIgY2VydGFpbiBjcml0aWNhbCB0ZW1w ZXJhdHVyZSBjb25kaXRpb25zLgo+IFRoaXMgY2F1c2VzIFRYIGRldGVjdGlvbiBmYWlsdXJlcyBv biBQQ0llIGxpbmtzLgo+IAo+IEFkZCBhIHdvcmthcm91bmQgdG8gZm9yY2UgdGhlIFJURVJNIGRl dGVjdGlvbiByZWFkeSBzaWduYWwgZm9yCj4gYWZmZWN0ZWQgUEhZIHJldmlzaW9ucy4gVGhpcyBl bnN1cmVzIHJlbGlhYmxlIFRYLXRvLVJYIHRlcm1pbmF0aW9uCj4gZGV0ZWN0aW9uIGFjcm9zcyBh bGwgb3BlcmF0aW5nIHRlbXBlcmF0dXJlIHJhbmdlcy4KPiAKPiBUaGUgZml4IGFwcGxpZXMgdG8g UkszNTYyLCBSSzM1NjgsIFJLMzU3NiBhbmQgUkszNTg4IFNvQ3Mgd2hpY2ggc2hhcmUKPiB0aGUg c2FtZSBQSFkgSVAgd2l0aCB0aGlzIGhhcmR3YXJlIGVycmF0YS4KPiAKPiBTaWduZWQtb2ZmLWJ5 OiBTaGF3biBMaW4gPHNoYXduLmxpbkByb2NrLWNoaXBzLmNvbT4KPiAtLS0KPiAKPiAgIGRyaXZl cnMvcGh5L3JvY2tjaGlwL3BoeS1yb2NrY2hpcC1uYW5lbmctY29tYnBoeS5jIHwgMTkgKysrKysr KysrKysrKysrKysrKwo+ICAgMSBmaWxlIGNoYW5nZWQsIDE5IGluc2VydGlvbnMoKykKPiAKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9waHkvcm9ja2NoaXAvcGh5LXJvY2tjaGlwLW5hbmVuZy1jb21i cGh5LmMgYi9kcml2ZXJzL3BoeS9yb2NrY2hpcC9waHktcm9ja2NoaXAtbmFuZW5nLWNvbWJwaHku Ywo+IGluZGV4IGI2MGQ2YmYuLjc2ZDQ5OTQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9waHkvcm9j a2NoaXAvcGh5LXJvY2tjaGlwLW5hbmVuZy1jb21icGh5LmMKPiArKysgYi9kcml2ZXJzL3BoeS9y b2NrY2hpcC9waHktcm9ja2NoaXAtbmFuZW5nLWNvbWJwaHkuYwo+IEBAIC0xMDYsNiArMTA2LDkg QEAKPiAgICNkZWZpbmUgUkszNTY4X1BIWVJFRzE4CQkJCTB4NDQKPiAgICNkZWZpbmUgUkszNTY4 X1BIWVJFRzE4X1BMTF9MT09QCQkweDMyCj4gICAKPiArI2RlZmluZSBSSzM1NjhfUEhZUkVHMjYJ CQkJMHg2NAo+ICsjZGVmaW5lIFJLMzU2OF9QSFlSRUcyNl9GT1JDRV9SVEVSTV9ERVRfUkRZCUJJ VCg1KQo+ICsKPiAgICNkZWZpbmUgUkszNTY4X1BIWVJFRzMwCQkJCTB4NzQKPiAgICNkZWZpbmUg UkszNTY4X1BIWVJFRzMwX0dBVEVfVFhfUENLX1NFTCAgICAgICAgIEJJVCg3KQo+ICAgI2RlZmlu ZSBSSzM1NjhfUEhZUkVHMzBfR0FURV9UWF9QQ0tfRExZX1BMTF9PRkYgQklUKDcpCj4gQEAgLTE5 Myw2ICsxOTYsNyBAQCBzdHJ1Y3Qgcm9ja2NoaXBfY29tYnBoeV9jZmcgewo+ICAgCXVuc2lnbmVk IGludCBudW1fcGh5czsKPiAgIAl1bnNpZ25lZCBpbnQgcGh5X2lkc1szXTsKPiAgIAljb25zdCBz dHJ1Y3Qgcm9ja2NoaXBfY29tYnBoeV9ncmZjZmcgKmdyZmNmZzsKPiArCWJvb2wgZm9yY2Vfcnh0 ZXJtX2RldF9yZHk7Cj4gICAJaW50ICgqY29tYnBoeV9jZmcpKHN0cnVjdCByb2NrY2hpcF9jb21i cGh5X3ByaXYgKnByaXYpOwo+ICAgfTsKPiAgIAo+IEBAIC0yNjQsNiArMjY4LDE3IEBAIHN0YXRp YyBpbnQgcm9ja2NoaXBfY29tYnBoeV9pbml0KHN0cnVjdCBwaHkgKnBoeSkKPiAgIAo+ICAgCXN3 aXRjaCAocHJpdi0+dHlwZSkgewo+ICAgCWNhc2UgUEhZX1RZUEVfUENJRToKPiArCQkvKgo+ICsJ CSAqIEhhcmR3YXJlIEVycmF0YTogVFggZmFpbHMgdG8gZGV0ZWN0IHBlZXIgUlggdGVybWluYXRp b24uCj4gKwkJICogU29tZSBQSFkgcmV2aXNpb25zIG1heSBmYWlsIHRvIGRldGVjdCByZW1vdGUg UlgncyBSVEVSTQo+ICsJCSAqIChyZWNlaXZlciB0ZXJtaW5hdGlvbiByZXNpc3RvcikgdW5kZXIg Y2VydGFpbiBjcml0aWNhbAo+ICsJCSAqIHRlbXBlcmF0dXJlIGNvbmRpdGlvbnMuIFNldCBmb3Jj ZSBydGVybSBkZXRlY3QgcmVhZHkgdG8KPiArCQkgKiBmaXggaXQuCj4gKwkJICovCj4gKwkJaWYg KHByaXYtPmNmZy0+Zm9yY2Vfcnh0ZXJtX2RldF9yZHkpCj4gKwkJCXJvY2tjaGlwX2NvbWJwaHlf dXBkYXRlbChwcml2LCBSSzM1NjhfUEhZUkVHMjZfRk9SQ0VfUlRFUk1fREVUX1JEWSwKPiArCQkJ CQlSSzM1NjhfUEhZUkVHMjZfRk9SQ0VfUlRFUk1fREVUX1JEWSwgUkszNTY4X1BIWVJFRzI2KTsK PiArCQlmYWxsdGhyb3VnaDsKPiAgIAljYXNlIFBIWV9UWVBFX1VTQjM6Cj4gICAJY2FzZSBQSFlf VFlQRV9TQVRBOgo+ICAgCWNhc2UgUEhZX1RZUEVfU0dNSUk6Cj4gQEAgLTc0NSw2ICs3NjAsNyBA QCBzdGF0aWMgY29uc3Qgc3RydWN0IHJvY2tjaGlwX2NvbWJwaHlfY2ZnIHJrMzU2Ml9jb21icGh5 X2NmZ3MgPSB7Cj4gICAJfSwKPiAgIAkuZ3JmY2ZnCQk9ICZyazM1NjJfY29tYnBoeV9ncmZjZmdz LAo+ICAgCS5jb21icGh5X2NmZwk9IHJrMzU2Ml9jb21icGh5X2NmZywKPiArCS5mb3JjZV9yeHRl cm1fZGV0X3JkeSAgPSB0cnVlLAo+ICAgfTsKPiAgIAo+ICAgc3RhdGljIGludCByazM1NjhfY29t YnBoeV9jZmcoc3RydWN0IHJvY2tjaGlwX2NvbWJwaHlfcHJpdiAqcHJpdikKPiBAQCAtOTYyLDYg Kzk3OCw3IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3Qgcm9ja2NoaXBfY29tYnBoeV9jZmcgcmszNTY4 X2NvbWJwaHlfY2ZncyA9IHsKPiAgIAl9LAo+ICAgCS5ncmZjZmcJCT0gJnJrMzU2OF9jb21icGh5 X2dyZmNmZ3MsCj4gICAJLmNvbWJwaHlfY2ZnCT0gcmszNTY4X2NvbWJwaHlfY2ZnLAo+ICsJLmZv cmNlX3J4dGVybV9kZXRfcmR5ICA9IHRydWUsCj4gICB9Owo+ICAgCj4gICBzdGF0aWMgaW50IHJr MzU3Nl9jb21icGh5X2NmZyhzdHJ1Y3Qgcm9ja2NoaXBfY29tYnBoeV9wcml2ICpwcml2KQo+IEBA IC0xMjMxLDYgKzEyNDgsNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IHJvY2tjaGlwX2NvbWJwaHlf Y2ZnIHJrMzU3Nl9jb21icGh5X2NmZ3MgPSB7Cj4gICAJfSwKPiAgIAkuZ3JmY2ZnCQk9ICZyazM1 NzZfY29tYnBoeV9ncmZjZmdzLAo+ICAgCS5jb21icGh5X2NmZwk9IHJrMzU3Nl9jb21icGh5X2Nm ZywKPiArCS5mb3JjZV9yeHRlcm1fZGV0X3JkeSAgPSB0cnVlLAo+ICAgfTsKPiAgIAo+ICAgc3Rh dGljIGludCByazM1ODhfY29tYnBoeV9jZmcoc3RydWN0IHJvY2tjaGlwX2NvbWJwaHlfcHJpdiAq cHJpdikKPiBAQCAtMTQxOCw2ICsxNDM2LDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCByb2NrY2hp cF9jb21icGh5X2NmZyByazM1ODhfY29tYnBoeV9jZmdzID0gewo+ICAgCX0sCj4gICAJLmdyZmNm ZwkJPSAmcmszNTg4X2NvbWJwaHlfZ3JmY2ZncywKPiAgIAkuY29tYnBoeV9jZmcJPSByazM1ODhf Y29tYnBoeV9jZmcsCj4gKwkuZm9yY2Vfcnh0ZXJtX2RldF9yZHkgID0gdHJ1ZSwKPiAgIH07Cj4g ICAKPiAgIHN0YXRpYyBjb25zdCBzdHJ1Y3Qgb2ZfZGV2aWNlX2lkIHJvY2tjaGlwX2NvbWJwaHlf b2ZfbWF0Y2hbXSA9IHsKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m15599.qiye.163.com (mail-m15599.qiye.163.com [101.71.155.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71F301E4BE for ; Mon, 27 Apr 2026 01:58:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=101.71.155.99 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777255091; cv=none; b=osAu4Q4RqodWvJif8ULp9GRfiTaEkH/FxxYGHZNii3iVYsbAerjjYehFD7ev0xU831LwZlUEaziYaWZQ/J3Q7SPSLoheG1rYHOnqfjgxWA3ylVL4MEaMc4bOVQVRnRoNXVvOUV9zKRdr+H9PIqrLHzgMmHt1QiyNXscSwgC9mC4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777255091; c=relaxed/simple; bh=1d8l61NQGpTgnU9G+8vJXaX23oXSUFBSOl8jWN/sPTA=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=eGiqmL6yn0/kHQHbS3kLdfiz53j279/wxZiCbkITahtIqYYXkbhb4Dv67D6PbVkWBL0cmmWMeCZHdueUE2wjEbmQg2QpcVdpl8hf624PXGFlzK2Tqo7mNWBT/o0N9NuD52p4+s/bpoYhxWfOT4MLOlUXll7LukeBhVVsqbDw5CE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=IjSoo2P0; arc=none smtp.client-ip=101.71.155.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="IjSoo2P0" Received: from [172.16.12.17] (unknown [61.154.14.86]) by smtp.qiye.163.com (Hmail) with ESMTP id 3c3314299; Mon, 27 Apr 2026 08:42:18 +0800 (GMT+08:00) Message-ID: <8b8ea5e8-4e1a-41e7-b377-0a4246609cf4@rock-chips.com> Date: Mon, 27 Apr 2026 08:42:16 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: shawn.lin@rock-chips.com, linux-rockchip@lists.infradead.org, Heiko Stuebner , Neil Armstrong , linux-kernel@vger.kernel.org Subject: Re: [PATCH] phy: rockchip: naneng-combphy: Fix TX detect RX termination errata To: Vinod Koul , linux-phy@lists.infradead.org References: <1774423383-36599-1-git-send-email-shawn.lin@rock-chips.com> From: Shawn Lin In-Reply-To: <1774423383-36599-1-git-send-email-shawn.lin@rock-chips.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Tid: 0a9dcc63143c09cckunmc5962bd51746c4 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFITzdXWRgWCB1ZQUpXWS1ZQUlXWQ8JGhUIEh9ZQVlCHkpKVkweGh9LGEpKSh8fS1YVFA kWGhdVEwETFhoSFyQUDg9ZV1kYEgtZQVlNSlVKTk9VSk9VQ01ZV1kWGg8SFR0UWUFZT0tIVUpLSU 9PT0hVSktLVUpCS0tZBg++ DKIM-Signature: a=rsa-sha256; b=IjSoo2P0FJMHK5MMBUpKSypXR5a7rsvOxpIZmjilqnCPppzaDlEiEnBbJbfk1AEDCEVyqAlY2QkIpJMDEs4dEMUgqtSrCXN2sDqlya/nXN42m+uu5Q1UgpM3OI89eYqZkSJQ1HEAQUp1YHWyvEIzZi+oSd95GnWwRwCi6YqNWmo=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=3HoksNeI6ZtKSz9ycILX9bag3CMDi7LUrvjdbGKG7Jc=; h=date:mime-version:subject:message-id:from; Ping... 在 2026/03/25 星期三 15:23, Shawn Lin 写道: > Some PHY revisions may fail to detect the peer RX's termination > resistor (RTERM) under certain critical temperature conditions. > This causes TX detection failures on PCIe links. > > Add a workaround to force the RTERM detection ready signal for > affected PHY revisions. This ensures reliable TX-to-RX termination > detection across all operating temperature ranges. > > The fix applies to RK3562, RK3568, RK3576 and RK3588 SoCs which share > the same PHY IP with this hardware errata. > > Signed-off-by: Shawn Lin > --- > > drivers/phy/rockchip/phy-rockchip-naneng-combphy.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c b/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c > index b60d6bf..76d4994 100644 > --- a/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c > +++ b/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c > @@ -106,6 +106,9 @@ > #define RK3568_PHYREG18 0x44 > #define RK3568_PHYREG18_PLL_LOOP 0x32 > > +#define RK3568_PHYREG26 0x64 > +#define RK3568_PHYREG26_FORCE_RTERM_DET_RDY BIT(5) > + > #define RK3568_PHYREG30 0x74 > #define RK3568_PHYREG30_GATE_TX_PCK_SEL BIT(7) > #define RK3568_PHYREG30_GATE_TX_PCK_DLY_PLL_OFF BIT(7) > @@ -193,6 +196,7 @@ struct rockchip_combphy_cfg { > unsigned int num_phys; > unsigned int phy_ids[3]; > const struct rockchip_combphy_grfcfg *grfcfg; > + bool force_rxterm_det_rdy; > int (*combphy_cfg)(struct rockchip_combphy_priv *priv); > }; > > @@ -264,6 +268,17 @@ static int rockchip_combphy_init(struct phy *phy) > > switch (priv->type) { > case PHY_TYPE_PCIE: > + /* > + * Hardware Errata: TX fails to detect peer RX termination. > + * Some PHY revisions may fail to detect remote RX's RTERM > + * (receiver termination resistor) under certain critical > + * temperature conditions. Set force rterm detect ready to > + * fix it. > + */ > + if (priv->cfg->force_rxterm_det_rdy) > + rockchip_combphy_updatel(priv, RK3568_PHYREG26_FORCE_RTERM_DET_RDY, > + RK3568_PHYREG26_FORCE_RTERM_DET_RDY, RK3568_PHYREG26); > + fallthrough; > case PHY_TYPE_USB3: > case PHY_TYPE_SATA: > case PHY_TYPE_SGMII: > @@ -745,6 +760,7 @@ static const struct rockchip_combphy_cfg rk3562_combphy_cfgs = { > }, > .grfcfg = &rk3562_combphy_grfcfgs, > .combphy_cfg = rk3562_combphy_cfg, > + .force_rxterm_det_rdy = true, > }; > > static int rk3568_combphy_cfg(struct rockchip_combphy_priv *priv) > @@ -962,6 +978,7 @@ static const struct rockchip_combphy_cfg rk3568_combphy_cfgs = { > }, > .grfcfg = &rk3568_combphy_grfcfgs, > .combphy_cfg = rk3568_combphy_cfg, > + .force_rxterm_det_rdy = true, > }; > > static int rk3576_combphy_cfg(struct rockchip_combphy_priv *priv) > @@ -1231,6 +1248,7 @@ static const struct rockchip_combphy_cfg rk3576_combphy_cfgs = { > }, > .grfcfg = &rk3576_combphy_grfcfgs, > .combphy_cfg = rk3576_combphy_cfg, > + .force_rxterm_det_rdy = true, > }; > > static int rk3588_combphy_cfg(struct rockchip_combphy_priv *priv) > @@ -1418,6 +1436,7 @@ static const struct rockchip_combphy_cfg rk3588_combphy_cfgs = { > }, > .grfcfg = &rk3588_combphy_grfcfgs, > .combphy_cfg = rk3588_combphy_cfg, > + .force_rxterm_det_rdy = true, > }; > > static const struct of_device_id rockchip_combphy_of_match[] = {