From: Jens Axboe <axboe@kernel.dk>
To: Martin Raiber <martin@urbackup.org>, io-uring@vger.kernel.org
Subject: Re: Fixed buffer have out-dated content
Date: Sat, 9 Jan 2021 09:23:14 -0700 [thread overview]
Message-ID: <8ba549a0-7724-a42f-bd11-3605ef0bd034@kernel.dk> (raw)
In-Reply-To: <01020176e45e6c4d-c15dc1e2-6a6a-407c-a32d-24be51a1b3f8-000000@eu-west-1.amazonses.com>
On 1/8/21 4:39 PM, Martin Raiber wrote:
> Hi,
>
> I have a gnarly issue with io_uring and fixed buffers (fixed
> read/write). It seems the contents of those buffers contain old data in
> some rare cases under memory pressure after a read/during a write.
>
> Specifically I use io_uring with fuse and to confirm this is not some
> user space issue let fuse print the unique id it adds to each request.
> Fuse adds this request data to a pipe, and when the pipe buffer is later
> copied to the io_uring fixed buffer it has the id of a fuse request
> returned earlier using the same buffer while returning the size of the
> new request. Or I set the unique id in the buffer, write it to fuse (via
> writing to a pipe, then splicing) and then fuse returns with e.g.
> ENOENT, because the unique id is not correct because in kernel it reads
> the id of the previous, already completed, request using this buffer.
>
> To make reproducing this faster running memtester (which mlocks a
> configurable amount of memory) with a large amount of user memory every
> 30s helps. So it has something to do with swapping? It seems to not
> occur if no swap space is active. Problem occurs without warning when
> the kernel is build with KASAN and slab debugging.
>
> If I don't use the _FIXED opcodes (which is easy to do), the problem
> does not occur.
>
> Problem occurs with 5.9.16 and 5.10.5.
Can you mention more about what kind of IO you are doing, I'm assuming
it's O_DIRECT? I'll see if I can reproduce this.
--
Jens Axboe
next prev parent reply other threads:[~2021-01-09 16:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 23:39 Fixed buffer have out-dated content Martin Raiber
2021-01-09 16:23 ` Jens Axboe [this message]
2021-01-09 16:58 ` Martin Raiber
2021-01-09 20:32 ` Pavel Begunkov
2021-01-10 16:50 ` Martin Raiber
2021-01-14 21:50 ` Fixed buffers " Martin Raiber
2021-01-16 19:30 ` Pavel Begunkov
2021-01-16 19:39 ` Jens Axboe
2021-01-16 22:12 ` Jens Axboe
2021-01-16 23:05 ` Linus Torvalds
2021-01-16 23:34 ` Linus Torvalds
2021-01-17 20:07 ` Martin Raiber
2021-01-17 20:14 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ba549a0-7724-a42f-bd11-3605ef0bd034@kernel.dk \
--to=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=martin@urbackup.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.