From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: Lahav Schlesinger <lschlesinger@drivenets.com>,
Ido Schimmel <idosch@idosch.org>
Cc: netdev@vger.kernel.org, kuba@kernel.org, dsahern@gmail.com
Subject: Re: [PATCH net-next v4] rtnetlink: Support fine-grained netdevice bulk deletion
Date: Mon, 6 Dec 2021 09:07:12 +0100 [thread overview]
Message-ID: <8bbc2f92-df95-d1ca-1f5b-d86757baa018@6wind.com> (raw)
In-Reply-To: <20211205150531.hy4rv7mtgau37xe2@kgollan-pc>
Le 05/12/2021 à 16:05, Lahav Schlesinger a écrit :
[snip]
>> In your specific case, it is quite useless for the kernel to generate
>> 16k notifications when moving the netdevs to a group since the entire
>> reason they are moved to a group is so that they could be deleted in a
>> batch.
>>
>> I assume that there are other use cases where having the kernel suppress
>> notifications can be useful. Did you consider adding such a flag to the
>> request? I think such a mechanism is more generic/useful than an ad-hoc
>> API to delete a list of netdevs and should allow you to utilize the
>> existing group deletion mechanism.
>
> I think having an API to suppress kernel notifications will be abused by
> userspace and introduce hard-to-debug bugs, e.g. some program will
> incorrectly set this flag when it shouldn't (on the premise that this
> flag will "make things faster") and inadvertently break other programs
> that depend on the notifications to function.
+1
next prev parent reply other threads:[~2021-12-06 8:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 17:45 [PATCH net-next v4] rtnetlink: Support fine-grained netdevice bulk deletion Lahav Schlesinger
2021-12-04 1:06 ` Jakub Kicinski
2021-12-04 10:15 ` Nikolay Aleksandrov
2021-12-04 16:18 ` David Ahern
2021-12-05 8:28 ` Lahav Schlesinger
2021-12-05 9:53 ` Ido Schimmel
2021-12-05 12:11 ` Lahav Schlesinger
2021-12-05 13:49 ` Ido Schimmel
2021-12-05 15:05 ` Lahav Schlesinger
2021-12-06 8:07 ` Nicolas Dichtel [this message]
2021-12-07 3:56 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bbc2f92-df95-d1ca-1f5b-d86757baa018@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=dsahern@gmail.com \
--cc=idosch@idosch.org \
--cc=kuba@kernel.org \
--cc=lschlesinger@drivenets.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.