From: Mahanta Jambigi <mjambigi@linux.ibm.com>
To: dust.li@linux.alibaba.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, alibuda@linux.alibaba.com,
sidraya@linux.ibm.com, wenjia@linux.ibm.com
Cc: pasic@linux.ibm.com, horms@kernel.org, tonylu@linux.alibaba.com,
guwen@linux.alibaba.com, netdev@vger.kernel.org,
linux-s390@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH net] net/smc: Remove unused argument from 2 SMC functions
Date: Tue, 9 Sep 2025 17:13:35 +0530 [thread overview]
Message-ID: <8bc987c9-a79d-42ec-8279-da8b407cfd2c@linux.ibm.com> (raw)
In-Reply-To: <aMAR8q4mc3Lhkovw@linux.alibaba.com>
On 09/09/25 5:09 pm, Dust Li wrote:
> On 2025-09-09 09:11:45, Mahanta Jambigi wrote:
>> The smc argument is not used in both smc_connect_ism_vlan_setup() &
>> smc_connect_ism_vlan_cleanup(). Hence removing it.
>>
>> Fixes: 413498440e30 net/smc: add SMC-D support in af_smc
>
> The standard format for the Fixes tag requires the title to be enclosed
> in parentheses.
I missed this. Let me fix it in next version.
>
> But I don't think this is a bugfix.
Yeah, its more of a clean up code. Should I use net-next? How should I
got about this.
>
>
>> Signed-off-by: Mahanta Jambigi <mjambigi@linux.ibm.com>
>> Reviewed-by: Sidraya Jayagond <sidraya@linux.ibm.com>
>
> Besides,
> Reviewed-by: Dust Li <dust.li@linux.alibaba.com>
>
> Best regards,
> Dust
next prev parent reply other threads:[~2025-09-09 11:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 7:11 [PATCH net] net/smc: Remove unused argument from 2 SMC functions Mahanta Jambigi
2025-09-09 11:39 ` Dust Li
2025-09-09 11:43 ` Mahanta Jambigi [this message]
2025-09-09 12:14 ` Dust Li
2025-09-09 12:18 ` Mahanta Jambigi
2025-09-09 12:36 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bc987c9-a79d-42ec-8279-da8b407cfd2c@linux.ibm.com \
--to=mjambigi@linux.ibm.com \
--cc=alibuda@linux.alibaba.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dust.li@linux.alibaba.com \
--cc=edumazet@google.com \
--cc=guwen@linux.alibaba.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=sidraya@linux.ibm.com \
--cc=tonylu@linux.alibaba.com \
--cc=wenjia@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.