Re: [PATCH] loongarch: kgdb: remove unnecessary init variable

[Yanteng Si <si.yanteng@linux.dev>]

在 5/30/25 3:09 PM, Li Jun 写道:
> the get_step_address(regs, &addr) should assign a value
> to 'error' before it is read.so the var don't need init
> to 0.
So, is it wrong to initialize it to 0 now?


Thanks,
Yanteng
> 
> Signed-off-by: Li Jun <lijun01@kylinos.cn>
> ---
>   arch/loongarch/kernel/kgdb.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/loongarch/kernel/kgdb.c b/arch/loongarch/kernel/kgdb.c
> index 7be5b4c0c900..df3c7a5565e9 100644
> --- a/arch/loongarch/kernel/kgdb.c
> +++ b/arch/loongarch/kernel/kgdb.c
> @@ -379,7 +379,7 @@ static int get_step_address(struct pt_regs *regs, unsigned long *next_addr)
>   
>   static int do_single_step(struct pt_regs *regs)
>   {
> -	int error = 0;
> +	int error;
>   	unsigned long addr = 0; /* Determine where the target instruction will send us to */
>   
>   	error = get_step_address(regs, &addr);