From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9581C36008 for ; Wed, 26 Mar 2025 09:54:51 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.927447.1330196 (Exim 4.92) (envelope-from ) id 1txNT9-00046p-HN; Wed, 26 Mar 2025 09:54:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 927447.1330196; Wed, 26 Mar 2025 09:54:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1txNT9-00046i-Ei; Wed, 26 Mar 2025 09:54:43 +0000 Received: by outflank-mailman (input) for mailman id 927447; Wed, 26 Mar 2025 09:54:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1txNT8-0003yw-7z for xen-devel@lists.xenproject.org; Wed, 26 Mar 2025 09:54:42 +0000 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [2a00:1450:4864:20::334]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 56835e9d-0a28-11f0-9ea3-5ba50f476ded; Wed, 26 Mar 2025 10:54:41 +0100 (CET) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-43d04dc73b7so68878225e9.3 for ; Wed, 26 Mar 2025 02:54:41 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d4fcea400sm178803215e9.2.2025.03.26.02.54.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Mar 2025 02:54:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 56835e9d-0a28-11f0-9ea3-5ba50f476ded DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1742982881; x=1743587681; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=EXus/nKSU901hG7n4zUiYodgGn9Wc8k2AuhZETXrFqo=; b=aJ+BhnupCqAxQ54K14WNfkoNsnIZMfaCVxeeM771rGmg8UCEopn8gqLpo3sdhc06oJ kqNJZ5nfJk1gA/UZXSOEELNj53zk3D0zD5sJrpl7/aT9LWsCZPxJSq9yPFgYiC8q0748 c2Cjx3hDGvgym/itdrCzp4CxVh43h646j5ZQFU3aUlyMIMibBcASbzsq0GMaLpUFl7gN 9FzSK7SePYj9Jka9g7K6QPDKoVGZPveor+/aW0RqxNeFvHcHqK19QgBaqnpSRahpwAph oPCLsZ9Zuw+lj4ZDSmemkRWuAe5rEemc8NBK8CVDLP7njb9puuosE1MlG1Ma1wGaIahY xe3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742982881; x=1743587681; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EXus/nKSU901hG7n4zUiYodgGn9Wc8k2AuhZETXrFqo=; b=lJWfL+4M/OaFkHpiQDzBpfWGyC0WIJz0ZrXLdWVE5NxGyFnmxFe2UBv8/Vbg4TTqrs z+8rnciMvei9x+p/nDH2ds6QHHozTkOki5PWhBzUxrwJiP90FxXkN7E6/TAMMOULNlzr hYi/WDbjvu/3Xxntz0q43MFHtv1IDOiIzJKivDjDpXfoJ2ekqLY/ddYcCg5hjC5KdoNE A6z/Nt0P4xmwVd7B1KmU40M5tyOo1DxFpfvxt2ev0vnFj5VHzgnNCXGDN3Pl4Bt+Xdl3 PYDrX8qPQixdgxgEy3HdZnTd+uOluIjlkVh5dWJP41z3watOmqykLBWqE50IqC+29BOu cYHA== X-Forwarded-Encrypted: i=1; AJvYcCVOAp8nKqpYzHF432MDKuCL4rwlf+UKc7MWDpy+8OwkFVc2+xsREU+pItcHEfdGJ6n9muu3Sny2t/A=@lists.xenproject.org X-Gm-Message-State: AOJu0YwHk5YtNSEHSAb3nZjcaKz5KBzCuSD9YA5BIQ1hsXFnZiiq347v gRZeyv/hte/fwPXmSJ+bGBRVJvyL9wlG0HqM5oudRoyn7bhaQbBuSaaGQb4V7A== X-Gm-Gg: ASbGncuvh88AjQmLYlKkE0waKrVglUtwRE84jPSi3i78fQZLRn6TcT40tHKkxfxSEv1 6aOcm2wJPpjTZAx88bUTSh6kCq2JDruFXY1Ix16aD2i9wGk719caXyO4LG3jwzMO3AOo+90bNab A8u7Uw9tUsdXnu2+2zpFQgG2lJy6lg6yTSmQbSzXdBD2XtJzHHisvZYAHxvnLxhd0eFdqfUWYZA wU91axlKcjaDVZbhS1gaYD27R6lc7CmdV0yL0+JniyCKaZnWzxhfopX9PagHJll1eYDShpRqK8D 0IpOPWxioMyLIUjvZTb9osTIWA8gHbKj/R1B+iaGgHBnkNjE0KWyxo5KkZpazPsqsEwZQWeqOgc evfUpZRCZ1inKVciGRUXZJU4eWLQJgg== X-Google-Smtp-Source: AGHT+IFqZHePhoETfc16xiWBUckcYIce5k0a1Q4AJw5QH4OcZJ/ilGsBWGBNLUjLO+JynaUbYVqtSQ== X-Received: by 2002:a05:600c:1c9b:b0:43d:1b95:6d0e with SMTP id 5b1f17b1804b1-43d50a200e4mr190303225e9.23.1742982880877; Wed, 26 Mar 2025 02:54:40 -0700 (PDT) Message-ID: <8c160573-ca40-4bf0-bf67-ee905fe9fb12@suse.com> Date: Wed, 26 Mar 2025 10:54:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 6/7] xen: introduce Kconfig ARCH_PAGING_MEMPOOL To: "Orzel, Michal" Cc: Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , Anthony PERARD , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Alistair Francis , Bob Eshleman , Connor Davis , Wei Chen , xen-devel@lists.xenproject.org, Oleksii Kurochko , Luca Fancellu References: <20250317200727.798696-1-luca.fancellu@arm.com> <20250317200727.798696-7-luca.fancellu@arm.com> <85ba02a9-f9f9-4141-85be-a9a2d431e450@gmail.com> <26583ecf-4057-46b1-8f87-f4589d7bec17@suse.com> <136cf1c5-d1e5-471d-b560-51632b444e41@gmail.com> <94865aea-043b-4f52-adb8-d2d78dba293b@suse.com> <0957c74f-a53d-4107-bc8d-e13d7c308d39@amd.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <0957c74f-a53d-4107-bc8d-e13d7c308d39@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 26.03.2025 10:39, Orzel, Michal wrote: > > > On 20/03/2025 08:32, Jan Beulich wrote: >> >> >> On 19.03.2025 17:31, Oleksii Kurochko wrote: >>> >>> On 3/19/25 12:35 PM, Jan Beulich wrote: >>>> On 18.03.2025 14:05, Oleksii Kurochko wrote: >>>>> On 3/17/25 9:07 PM, Luca Fancellu wrote: >>>>>> From: Penny Zheng >>>>>> >>>>>> ARM MPU system doesn't need to use paging memory pool, as MPU memory >>>>>> mapping table at most takes only one 4KB page, which is enough to >>>>>> manage the maximum 255 MPU memory regions, for all EL2 stage 1 >>>>>> translation and EL1 stage 2 translation. >>>>>> >>>>>> Introduce ARCH_PAGING_MEMPOOL Kconfig common symbol, selected for Arm >>>>>> MMU systems, x86 and RISC-V. >>>>>> >>>>>> Wrap the code inside 'construct_domU' that deal with p2m paging >>>>>> allocation in a new function 'domain_p2m_set_allocation', protected >>>>>> by ARCH_PAGING_MEMPOOL, this is done in this way to prevent polluting >>>>>> the former function with #ifdefs and improve readability >>>>>> >>>>>> Introduce arch_{get,set}_paging_mempool_size stubs for architecture >>>>>> with !ARCH_PAGING_MEMPOOL. >>>>>> >>>>>> Remove 'struct paging_domain' from Arm 'struct arch_domain' when the >>>>>> field is not required. >>>>>> >>>>>> Signed-off-by: Penny Zheng >>>>>> Signed-off-by: Wei Chen >>>>>> Signed-off-by: Luca Fancellu >>>>>> --- >>>>>> v3 changes: >>>>>> - Introduced ARCH_PAGING_MEMPOOL instead of HAS_PAGING_MEMPOOL >>>>>> v2 changes: >>>>>> - make Kconfig HAS_PAGING_MEMPOOL common >>>>>> - protect also "xen,domain-p2m-mem-mb" reading with HAS_PAGING_MEMPOOL >>>>>> - do not define p2m_teardown{_allocation} in this patch >>>>>> - change commit message >>>>>> --- >>>>>> xen/arch/arm/Kconfig | 1 + >>>>>> xen/arch/arm/dom0less-build.c | 74 ++++++++++++++++++++----------- >>>>>> xen/arch/arm/include/asm/domain.h | 2 + >>>>>> xen/arch/riscv/Kconfig | 1 + >>>>>> xen/arch/x86/Kconfig | 1 + >>>>>> xen/common/Kconfig | 3 ++ >>>>>> xen/include/xen/domain.h | 17 +++++++ >>>>>> 7 files changed, 73 insertions(+), 26 deletions(-) >>>>> For RISC-V: >>>>> Reviewed-by: Oleksii Kurochko >>>> Mind me asking then why RISC-V needs this at this point? The stubs surely >>>> were added to address some build issue, not because they are actively >>>> meaningful? >>> >>> Only because we have stubs and not to have redefinition compilation >>> error. And, yes, they are not actively meaningful now, at least. I am >>> okay with not enabling of this config for RISC-V but then seems to me we >>> have to drop stubs in riscv/stubs.c. ~ Oleksii >> >> Well, I don't think it's "have to", but I agree that dropping them would >> make sense then (and be desirable). > @Jan, @Oleksii, is there anything blocking this patch to be committed (Luca > question does not seem to be answered)? Other patches in the series are ready to > be merged. While I think Oleksii's reply has sufficiently clarified things, I still wonder: What question of Luca are you referring to? There's none visible in context here afaics. The two questions that are visible were raised by me, and answered by Oleksii (also visible in context above). There was an implication to draw from that, yes, which Oleksii has now made explicit in his reply to your mail. And then, formally this still didn't have a REST ack (you limited your R-b to Arm) nor an x86 one. Jan