From: Marek Vasut <marex@denx.de>
To: Fabio Estevam <festevam@gmail.com>, martyn.welch@collabora.com
Cc: parthitce@gmail.com, u-boot@lists.denx.de, y.moog@phytec.de,
w.egorov@phytec.de, Masahiro Yamada <masahiroy@kernel.org>
Subject: Re: [PATCH] phycore_pcl063: Drop leading zero from USB vendor number
Date: Mon, 25 Mar 2024 15:01:13 +0100 [thread overview]
Message-ID: <8c17ed8e-b282-4eae-8059-10d9c0a7670d@denx.de> (raw)
In-Reply-To: <20240325135230.1777213-1-festevam@gmail.com>
On 3/25/24 2:52 PM, Fabio Estevam wrote:
> CONFIG_USB_GADGET_VENDOR_NUM is a 16-bit number, so remove
> the leading zero.
>
> Reported-by: Marek Vasut <marex@denx.de>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> configs/phycore_pcl063_defconfig | 2 +-
> configs/phycore_pcl063_ull_defconfig | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configs/phycore_pcl063_defconfig b/configs/phycore_pcl063_defconfig
> index 6b00df1cffb3..017054a8e12b 100644
> --- a/configs/phycore_pcl063_defconfig
> +++ b/configs/phycore_pcl063_defconfig
> @@ -63,7 +63,7 @@ CONFIG_USB=y
> CONFIG_SPL_USB_HOST=y
> CONFIG_USB_GADGET=y
> CONFIG_USB_GADGET_MANUFACTURER="Phytec"
> -CONFIG_USB_GADGET_VENDOR_NUM=0x01b67
> +CONFIG_USB_GADGET_VENDOR_NUM=0x1b67
> CONFIG_USB_GADGET_PRODUCT_NUM=0x4fff
> CONFIG_CI_UDC=y
> CONFIG_USB_GADGET_DOWNLOAD=y
> diff --git a/configs/phycore_pcl063_ull_defconfig b/configs/phycore_pcl063_ull_defconfig
> index 6195fcfb73df..b3da43a5bf1e 100644
> --- a/configs/phycore_pcl063_ull_defconfig
> +++ b/configs/phycore_pcl063_ull_defconfig
> @@ -54,7 +54,7 @@ CONFIG_USB=y
> CONFIG_SPL_USB_HOST=y
> CONFIG_USB_GADGET=y
> CONFIG_USB_GADGET_MANUFACTURER="Phytec"
> -CONFIG_USB_GADGET_VENDOR_NUM=0x01b67
> +CONFIG_USB_GADGET_VENDOR_NUM=0x1b67
Reviewed-by: Marek Vasut <marex@denx.de>
+CC Yamada-san , can Kconfig somehow sanitize 16bit numbers like this ?
next prev parent reply other threads:[~2024-03-25 14:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 13:52 [PATCH] phycore_pcl063: Drop leading zero from USB vendor number Fabio Estevam
2024-03-25 14:01 ` Marek Vasut [this message]
2024-03-30 19:44 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c17ed8e-b282-4eae-8059-10d9c0a7670d@denx.de \
--to=marex@denx.de \
--cc=festevam@gmail.com \
--cc=martyn.welch@collabora.com \
--cc=masahiroy@kernel.org \
--cc=parthitce@gmail.com \
--cc=u-boot@lists.denx.de \
--cc=w.egorov@phytec.de \
--cc=y.moog@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.