From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5914D29E for ; Sat, 6 Apr 2024 03:05:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=85.214.62.61 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712372737; cv=none; b=W/YkRYKSiuv+dlp/vRtqG6aT28demxxh0ThYjYDqGtZQIRcLpM7zpryqBOR8Ct3Wghlc/82DgKtGszuph6YEHNJIs6O5mtFVt7VfXS1wc+j19zTesDwzcSELXUMaQCQliS3NnlNlhtavAAGzodBWq3ZYUwO+gQqWEuF+cxSGZr0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712372737; c=relaxed/simple; bh=ZMIzrbbfNhT0+osKQbaDl6ZZ8FiZg74QjizS7mVXHE0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bHz3BR6L7AdeeTVTsSQV3YnvJv6ew+Pq0NtAHw1YKYtS2DDF62umPSHZI/kyFA2rvEb9CXybuf3Fg+fzSE+NlO51JdLBxRgHiKULFHxi/Zc4pf2GTL12LODA6+41A8Xd8OwCSx8Tg2/3zxHZS6z63qHS1lT20jJ0w9SwGA9eyPI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=denx.de; spf=pass smtp.mailfrom=denx.de; dkim=pass (2048-bit key) header.d=denx.de header.i=@denx.de header.b=pX9xhHYP; arc=none smtp.client-ip=85.214.62.61 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=denx.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=denx.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=denx.de header.i=@denx.de header.b="pX9xhHYP" Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id ECF9688003; Sat, 6 Apr 2024 05:05:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1712372732; bh=ObJuP7iCEb29EVb5EPrgoeoAW4XgwKZjQyDe2HQIMaU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=pX9xhHYPSyKZbjtaUSauvNytgw/Z39jmBw8hs+JHDnn9mu+u4Vgz4t1+q3sLQDwXa UInw7crefLEYc1a0MnWaVeqGwNDHOGHFVWeShGRC+KgT9nj3h5ZP3mXVNdsUuYk4DZ 9FAyVXSIpxMmNYd5XbT2pHyMMWmjw1W03eLi4+z50diFoXPzfX66Gp5TsgHqLZ6+dW TXMlUSeh1Ju5cf9M557K/w1ePu9wzJZRZD+gukAoE/7/P2uQ33c43CL7rzr8oSFp90 1IPKo8kVCty2TaTQ/zVy50vE4MVTmDwsrBRZdzqltX4KqfyPZ5prPbFfKKGQmz1GMf FqIt4BdJa+yew== Message-ID: <8c1935d1-7f59-4742-9659-bf87ac4b736c@denx.de> Date: Sat, 6 Apr 2024 04:58:39 +0200 Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: imx8mp: Align both CSI2 pixel clock To: Adam Ford , Laurent Pinchart Cc: linux-arm-kernel@lists.infradead.org, Conor Dooley , Fabio Estevam , Krzysztof Kozlowski , Paul Elder , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, imx@lists.linux.dev References: <20240405202243.46278-1-marex@denx.de> <20240405204251.GE12507@pendragon.ideasonboard.com> Content-Language: en-US From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 4/5/24 11:04 PM, Adam Ford wrote: > On Fri, Apr 5, 2024 at 3:43 PM Laurent Pinchart > wrote: >> >> Hi Marek, >> >> (CC'ing Adam) >> >> Thank you for the patch. >> >> On Fri, Apr 05, 2024 at 10:22:26PM +0200, Marek Vasut wrote: >>> Configure both CSI2 assigned-clock-rates the same way. >>> There does not seem to be any reason for keeping the >>> two CSI2 pixel clock set to different frequencies. >> >> There's an issue when using two cameras concurrently. This has been >> discussed some time ago on the linux-media mailing list, see [1]. Adam >> knows more than I do on this topic. >> >> [1] https://lore.kernel.org/linux-media/CAHCN7x+kymRGO2kxvN2=zLiqRjfTc3hdf3VdNVkWjsW3La0bnA@mail.gmail.com/ >> >>> Signed-off-by: Marek Vasut >>> --- >>> Cc: Conor Dooley >>> Cc: Fabio Estevam >>> Cc: Krzysztof Kozlowski >>> Cc: Laurent Pinchart >>> Cc: Paul Elder >>> Cc: Pengutronix Kernel Team >>> Cc: Rob Herring >>> Cc: Sascha Hauer >>> Cc: Shawn Guo >>> Cc: devicetree@vger.kernel.org >>> Cc: imx@lists.linux.dev >>> Cc: linux-arm-kernel@lists.infradead.org >>> --- >>> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi >>> index 1bb96e96639f2..2e9ce0c3a9815 100644 >>> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi >>> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi >>> @@ -1703,7 +1703,7 @@ mipi_csi_1: csi@32e50000 { >>> <&clk IMX8MP_CLK_MEDIA_MIPI_PHY1_REF>; >>> assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_1000M>, >>> <&clk IMX8MP_CLK_24M>; >>> - assigned-clock-rates = <266000000>; >>> + assigned-clock-rates = <500000000>; > > I am traveling, so I don't have the technical documents in front of > me, but I beleive this is an over-drive speed, and 400MHz would be the > single clock, standard rate. I created an imx8mm-overdrive and > imx8mn-overdrive dtsi file to let users who operate in overdrive mode > to update their clocks in one place. > > I also think this goes down if the user is running two cameras instead > of one. I re-read the old thread, and it's coming back to me, but > until I can get settled into my hotel in Germany, I won't have time to > review. I think the original idea was to use the lowest, conservative > value with the idea that people can tweak their clock settings if > they're only running one and if they are running in over-drive mode. MX8MPCEC does indeed read 400 MHz regular, 500 MHz overdrive. Shall we align both CSI2 ports to 400 MHz ? Currently they are one 500 MHz and the other 266 MHz . From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C1ABC3A59D for ; Sat, 6 Apr 2024 03:05:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NAPjEsmgN8BaTzcVJXTzqYN3BKu8qP7hrNWNj6cY8eo=; b=IcezbMCXXxG5zz 2AdhBAnYnpDe2NjspQeWej7hSlzzCDA/kXBPsDl5Bh0aDaJSofypesRNjR3MCOe1h7jPCo1qBB+qw +UglM3nHY4JCr92MThNrWFwYTntDruAPZyEiNlh2U4VVQUy2HL5bM+IJv3VRM25eLgSjWr7+8TpfK ynoIOZXZkR6doEn7dXQBzuc4LNHmLEsjY7B5pZJiJMwv1AqEH/c2j7Un4WpWCs4ElMEsuKbGgStNO wSwWO0GSOfXfcGfNB/9lqM+r8aGzGO3IkfYCuELsWH+wvJeSxQ7+HW2RGn2NS2asZNW6yEL2Rtspr To2dnZwTFz97flqkp2vQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rswNA-00000009YAO-0kOR; Sat, 06 Apr 2024 03:05:40 +0000 Received: from phobos.denx.de ([2a01:238:438b:c500:173d:9f52:ddab:ee01]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rswN7-00000009Y9S-0nSR for linux-arm-kernel@lists.infradead.org; Sat, 06 Apr 2024 03:05:38 +0000 Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id ECF9688003; Sat, 6 Apr 2024 05:05:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1712372732; bh=ObJuP7iCEb29EVb5EPrgoeoAW4XgwKZjQyDe2HQIMaU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=pX9xhHYPSyKZbjtaUSauvNytgw/Z39jmBw8hs+JHDnn9mu+u4Vgz4t1+q3sLQDwXa UInw7crefLEYc1a0MnWaVeqGwNDHOGHFVWeShGRC+KgT9nj3h5ZP3mXVNdsUuYk4DZ 9FAyVXSIpxMmNYd5XbT2pHyMMWmjw1W03eLi4+z50diFoXPzfX66Gp5TsgHqLZ6+dW TXMlUSeh1Ju5cf9M557K/w1ePu9wzJZRZD+gukAoE/7/P2uQ33c43CL7rzr8oSFp90 1IPKo8kVCty2TaTQ/zVy50vE4MVTmDwsrBRZdzqltX4KqfyPZ5prPbFfKKGQmz1GMf FqIt4BdJa+yew== Message-ID: <8c1935d1-7f59-4742-9659-bf87ac4b736c@denx.de> Date: Sat, 6 Apr 2024 04:58:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: imx8mp: Align both CSI2 pixel clock To: Adam Ford , Laurent Pinchart Cc: linux-arm-kernel@lists.infradead.org, Conor Dooley , Fabio Estevam , Krzysztof Kozlowski , Paul Elder , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, imx@lists.linux.dev References: <20240405202243.46278-1-marex@denx.de> <20240405204251.GE12507@pendragon.ideasonboard.com> Content-Language: en-US From: Marek Vasut In-Reply-To: X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240405_200537_573187_60AE18D3 X-CRM114-Status: GOOD ( 22.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gNC81LzI0IDExOjA0IFBNLCBBZGFtIEZvcmQgd3JvdGU6Cj4gT24gRnJpLCBBcHIgNSwgMjAy NCBhdCAzOjQz4oCvUE0gTGF1cmVudCBQaW5jaGFydAo+IDxsYXVyZW50LnBpbmNoYXJ0QGlkZWFz b25ib2FyZC5jb20+IHdyb3RlOgo+Pgo+PiBIaSBNYXJlaywKPj4KPj4gKENDJ2luZyBBZGFtKQo+ Pgo+PiBUaGFuayB5b3UgZm9yIHRoZSBwYXRjaC4KPj4KPj4gT24gRnJpLCBBcHIgMDUsIDIwMjQg YXQgMTA6MjI6MjZQTSArMDIwMCwgTWFyZWsgVmFzdXQgd3JvdGU6Cj4+PiBDb25maWd1cmUgYm90 aCBDU0kyIGFzc2lnbmVkLWNsb2NrLXJhdGVzIHRoZSBzYW1lIHdheS4KPj4+IFRoZXJlIGRvZXMg bm90IHNlZW0gdG8gYmUgYW55IHJlYXNvbiBmb3Iga2VlcGluZyB0aGUKPj4+IHR3byBDU0kyIHBp eGVsIGNsb2NrIHNldCB0byBkaWZmZXJlbnQgZnJlcXVlbmNpZXMuCj4+Cj4+IFRoZXJlJ3MgYW4g aXNzdWUgd2hlbiB1c2luZyB0d28gY2FtZXJhcyBjb25jdXJyZW50bHkuIFRoaXMgaGFzIGJlZW4K Pj4gZGlzY3Vzc2VkIHNvbWUgdGltZSBhZ28gb24gdGhlIGxpbnV4LW1lZGlhIG1haWxpbmcgbGlz dCwgc2VlIFsxXS4gQWRhbQo+PiBrbm93cyBtb3JlIHRoYW4gSSBkbyBvbiB0aGlzIHRvcGljLgo+ Pgo+PiBbMV0gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGludXgtbWVkaWEvQ0FIQ043eCtreW1S R08ya3h2TjI9ekxpcVJqZlRjM2hkZjNWZE5Wa1dqc1czTGEwYm5BQG1haWwuZ21haWwuY29tLwo+ Pgo+Pj4gU2lnbmVkLW9mZi1ieTogTWFyZWsgVmFzdXQgPG1hcmV4QGRlbnguZGU+Cj4+PiAtLS0K Pj4+IENjOiBDb25vciBEb29sZXkgPGNvbm9yK2R0QGtlcm5lbC5vcmc+Cj4+PiBDYzogRmFiaW8g RXN0ZXZhbSA8ZmVzdGV2YW1AZ21haWwuY29tPgo+Pj4gQ2M6IEtyenlzenRvZiBLb3psb3dza2kg PGtyenlzenRvZi5rb3psb3dza2krZHRAbGluYXJvLm9yZz4KPj4+IENjOiBMYXVyZW50IFBpbmNo YXJ0IDxsYXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+Cj4+PiBDYzogUGF1bCBFbGRl ciA8cGF1bC5lbGRlckBpZGVhc29uYm9hcmQuY29tPgo+Pj4gQ2M6IFBlbmd1dHJvbml4IEtlcm5l bCBUZWFtIDxrZXJuZWxAcGVuZ3V0cm9uaXguZGU+Cj4+PiBDYzogUm9iIEhlcnJpbmcgPHJvYmhA a2VybmVsLm9yZz4KPj4+IENjOiBTYXNjaGEgSGF1ZXIgPHMuaGF1ZXJAcGVuZ3V0cm9uaXguZGU+ Cj4+PiBDYzogU2hhd24gR3VvIDxzaGF3bmd1b0BrZXJuZWwub3JnPgo+Pj4gQ2M6IGRldmljZXRy ZWVAdmdlci5rZXJuZWwub3JnCj4+PiBDYzogaW14QGxpc3RzLmxpbnV4LmRldgo+Pj4gQ2M6IGxp bnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwo+Pj4gLS0tCj4+PiAgIGFyY2gvYXJt NjQvYm9vdC9kdHMvZnJlZXNjYWxlL2lteDhtcC5kdHNpIHwgMiArLQo+Pj4gICAxIGZpbGUgY2hh bmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEv YXJjaC9hcm02NC9ib290L2R0cy9mcmVlc2NhbGUvaW14OG1wLmR0c2kgYi9hcmNoL2FybTY0L2Jv b3QvZHRzL2ZyZWVzY2FsZS9pbXg4bXAuZHRzaQo+Pj4gaW5kZXggMWJiOTZlOTY2MzlmMi4uMmU5 Y2UwYzNhOTgxNSAxMDA2NDQKPj4+IC0tLSBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvZnJlZXNjYWxl L2lteDhtcC5kdHNpCj4+PiArKysgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL2ZyZWVzY2FsZS9pbXg4 bXAuZHRzaQo+Pj4gQEAgLTE3MDMsNyArMTcwMyw3IEBAIG1pcGlfY3NpXzE6IGNzaUAzMmU1MDAw MCB7Cj4+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg PCZjbGsgSU1YOE1QX0NMS19NRURJQV9NSVBJX1BIWTFfUkVGPjsKPj4+ICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBhc3NpZ25lZC1jbG9jay1wYXJlbnRzID0gPCZjbGsgSU1YOE1QX1NZ U19QTEwyXzEwMDBNPiwKPj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgPCZjbGsgSU1YOE1QX0NMS18yNE0+Owo+Pj4gLSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgYXNzaWduZWQtY2xvY2stcmF0ZXMgPSA8MjY2MDAwMDAwPjsKPj4+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGFzc2lnbmVkLWNsb2NrLXJhdGVzID0gPDUw MDAwMDAwMD47Cj4gCj4gSSBhbSB0cmF2ZWxpbmcsIHNvIEkgZG9uJ3QgaGF2ZSB0aGUgdGVjaG5p Y2FsIGRvY3VtZW50cyBpbiBmcm9udCBvZgo+IG1lLCBidXQgSSBiZWxlaXZlIHRoaXMgaXMgYW4g b3Zlci1kcml2ZSBzcGVlZCwgYW5kIDQwME1IeiB3b3VsZCBiZSB0aGUKPiBzaW5nbGUgY2xvY2ss IHN0YW5kYXJkIHJhdGUuICBJIGNyZWF0ZWQgYW4gaW14OG1tLW92ZXJkcml2ZSBhbmQKPiBpbXg4 bW4tb3ZlcmRyaXZlIGR0c2kgZmlsZSB0byBsZXQgdXNlcnMgd2hvIG9wZXJhdGUgaW4gb3ZlcmRy aXZlIG1vZGUKPiB0byB1cGRhdGUgdGhlaXIgY2xvY2tzIGluIG9uZSBwbGFjZS4KPiAKPiBJIGFs c28gdGhpbmsgdGhpcyBnb2VzIGRvd24gaWYgdGhlIHVzZXIgaXMgcnVubmluZyB0d28gY2FtZXJh cyBpbnN0ZWFkCj4gb2Ygb25lLiAgSSByZS1yZWFkIHRoZSBvbGQgdGhyZWFkLCBhbmQgaXQncyBj b21pbmcgYmFjayB0byBtZSwgYnV0Cj4gdW50aWwgSSBjYW4gZ2V0IHNldHRsZWQgaW50byBteSBo b3RlbCBpbiBHZXJtYW55LCBJIHdvbid0IGhhdmUgdGltZSB0bwo+IHJldmlldy4gIEkgdGhpbmsg dGhlIG9yaWdpbmFsIGlkZWEgd2FzIHRvIHVzZSB0aGUgbG93ZXN0LCBjb25zZXJ2YXRpdmUKPiB2 YWx1ZSB3aXRoIHRoZSBpZGVhIHRoYXQgcGVvcGxlIGNhbiB0d2VhayB0aGVpciBjbG9jayBzZXR0 aW5ncyBpZgo+IHRoZXkncmUgb25seSBydW5uaW5nIG9uZSBhbmQgaWYgdGhleSBhcmUgcnVubmlu ZyBpbiBvdmVyLWRyaXZlIG1vZGUuCgpNWDhNUENFQyBkb2VzIGluZGVlZCByZWFkIDQwMCBNSHog cmVndWxhciwgNTAwIE1IeiBvdmVyZHJpdmUuCgpTaGFsbCB3ZSBhbGlnbiBib3RoIENTSTIgcG9y dHMgdG8gNDAwIE1IeiA/IEN1cnJlbnRseSB0aGV5IGFyZSBvbmUgNTAwIApNSHogYW5kIHRoZSBv dGhlciAyNjYgTUh6IC4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LWFybS1rZXJuZWwK