From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5A8BC10F11 for ; Sat, 13 Apr 2019 17:28:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A8D602084D for ; Sat, 13 Apr 2019 17:28:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hUPB/lkE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727216AbfDMR2u (ORCPT ); Sat, 13 Apr 2019 13:28:50 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:33693 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727074AbfDMR2u (ORCPT ); Sat, 13 Apr 2019 13:28:50 -0400 Received: by mail-wr1-f67.google.com with SMTP id q1so16096032wrp.0 for ; Sat, 13 Apr 2019 10:28:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=slP/dBV1inDlJVZazbReux/TjhaE70dgEZJHFWyaBy4=; b=hUPB/lkEd/FEwgQJMEiXsC1GvdMUKdgAyxDP+VKxHJ5NpnFguf68XnvI3u+k5pT71r Jt99v8Q/zDoFZcM3dZ66TitJ5S2shAoHO98uXPC6bW+D5eA+9KGVbyEc5quRWt6GoURw 8Z5uJHfjQoVDVZBQRmjNwXsGRQuXjPBkjdgDactDfhe3GFXqu/E7D8dzZ7Y9f8C2qUxa hb8nRCyyC0DHwsoP5i5nN5DoDn4djwVzPcTqONvfYbVdD5vTs+UgtkYNuYo7ztzOpXJP YHbSlZXPrTMTZsAnT6xZnDNShBo4cH0/KEmxFmrpHX93Y3kI5HnCfPWy2h74/Jgx6q+0 9tuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=slP/dBV1inDlJVZazbReux/TjhaE70dgEZJHFWyaBy4=; b=D5hN2h0vovXJgTKy8Bkhn06cBEjvS5JAF616vju2rGjBiWqc25PhmdHsfSMQeI7ktI KShbkMIIyr5lOH4Yqvk4VLq4K/WN8mUSdWMCaCIC9ckcueXE46s+tq2OX/UBbtshxHMv etJU+FlMeAihbV1w+iaD0AJxJLnXL9L+LQzr2P4gwWbtqBGgGMNDIgRzv5l78LpWwgGW xRJc6PQQQ6B3mcacQQRviUuMVL5nfJPXDTmko8BI5Aa353kTXs2i+rmUfAIS6jCHp7cP g/dj8kH0jflDVo5IYWXBRzh+wKLNtKyYBW1S1ZGQDT9zebbFR6WxgyW6mqd6yVqNWdUn J9nw== X-Gm-Message-State: APjAAAX/5bkvLg6xF/AIvLK3NlqILg+8VTT+/qkAuFBCBQQtBveqYdqJ P5DVCqTKYX7Im1rxz8j2YoRztUVI X-Google-Smtp-Source: APXvYqzBvtPSgSH+PZa8Gp+OtKX1wW6Bt1HxLsyx+mcmc5f7sesD/9vfX7F5k0ykhaJpOx4ghGB5Aw== X-Received: by 2002:adf:f285:: with SMTP id k5mr26585054wro.110.1555176528419; Sat, 13 Apr 2019 10:28:48 -0700 (PDT) Received: from ?IPv6:2003:ea:8bd4:5700:55d5:e2ee:33f5:6950? (p200300EA8BD4570055D5E2EE33F56950.dip0.t-ipconnect.de. [2003:ea:8bd4:5700:55d5:e2ee:33f5:6950]) by smtp.googlemail.com with ESMTPSA id o5sm11467124wmc.16.2019.04.13.10.28.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 13 Apr 2019 10:28:47 -0700 (PDT) Subject: Re: [PATCH net-next 0/2] net: phy: shrink PHY settings array and add 200Gbps support To: Andrew Lunn Cc: Florian Fainelli , David Miller , "netdev@vger.kernel.org" References: <2ef3d8a7-3cff-cea6-646a-4b2ed0834398@gmail.com> <20190413170730.GL17901@lunn.ch> From: Heiner Kallweit Message-ID: <8c3f4be5-823a-5183-08ff-e34c3f91035d@gmail.com> Date: Sat, 13 Apr 2019 19:26:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190413170730.GL17901@lunn.ch> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 13.04.2019 19:07, Andrew Lunn wrote: > On Sat, Apr 13, 2019 at 06:51:16PM +0200, Heiner Kallweit wrote: >> The definition of array settings[] is quite lengthy meanwhile. Add a >> macro to shrink the definition. >> >> When doing this I saw that the new 200Gbps modes aren't supported >> in phylib yet. So add this. I think we need to document somewhere >> which places in phylib need to be touched if a new speed / mode is >> added. > > Yes, maybe something like > > BUILD_BUG_ON(__ETHTOOL_LINK_MODE_MASK_NBITS != 67); > > in drivers/net/phy/phy-core.c with a comment explaining what should be > done? > Yes, this sounds reasonable. We could use BUILD_BUG_ON_MSG to print this comment. > Andrew > Heiner