[Openvpn-devel] [L] Change in openvpn[master]: Implement support for larger packet counter sizes

["flichtenheld (Code Review)" <gerrit@...515...>]

[-- Attachment #1: Type: text/plain, Size: 3380 bytes --]

Attention is currently required from: plaisthos.

flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/507?usp=email )

Change subject: Implement support for larger packet counter sizes
......................................................................


Patch Set 2: Code-Review-1

(11 comments)

Commit Message:

http://gerrit.openvpn.net/c/openvpn/+/507/comment/9474d66b_41a49dc1 :
PS2, Line 27: larger packet counters in any scenario since the other scenarios
Maybe nicer "in any other scenario since those are all legacy"


http://gerrit.openvpn.net/c/openvpn/+/507/comment/c459f6e9_1c6a2ee5 :
PS2, Line 38: 2^32 packet ids) forward. But this is an obscure edge that we can
remove second "forward"


http://gerrit.openvpn.net/c/openvpn/+/507/comment/e22305ad_aea02a52 :
PS2, Line 41: Change-Id: I01e258e97351b5aa4b9e561f5b35ddc2318569e2
Missing sign-off


Patchset:

PS2:
Didn't get through the whole change, yet, but since I accumulated already a sizeable number of comments, here they are...


File src/openvpn/crypto.h:

http://gerrit.openvpn.net/c/openvpn/+/507/comment/f5a0f5fa_c7d56d07 :
PS2, Line 287:     /**< Bit-flag indicating that we should use a 64 bit (8 byte) packet
This needs WAY more explanation. What is the difference between CO_PACKET_ID_LONG_FORM and this? CO_PACKET_ID_LONG_FORM is only for non-AEAD data packets and this is only for AEAD packets, right? I think this should be mentioned here.


http://gerrit.openvpn.net/c/openvpn/+/507/comment/44aff7d2_675e1cf8 :
PS2, Line 288:      * counter instead of the 32 bit that we normally use.
"normally use" -> "use by default". 32bit will remain the default, but hopefully not the norm.


File src/openvpn/packet_id.h:

http://gerrit.openvpn.net/c/openvpn/+/507/comment/586075bf_d6c272af :
PS2, Line 250:  * Variant of packet_id_read that expect the timestamp first and packet
"expects"


http://gerrit.openvpn.net/c/openvpn/+/507/comment/01116f80_49cacdec :
PS2, Line 273:  * will always use a variant of the packet id that can just be seens as
"seen"


http://gerrit.openvpn.net/c/openvpn/+/507/comment/27267e93_2e924d4c :
PS2, Line 274:  * a flat 64 bit counter
add full stop at the end


http://gerrit.openvpn.net/c/openvpn/+/507/comment/a6ddc660_5b3f2b5e :
PS2, Line 277:  * @param buf           Buffer to write the packet ID too
"too" -> "to"


http://gerrit.openvpn.net/c/openvpn/+/507/comment/42ac15af_a6087522 :
PS2, Line 279:  * @param prepend       If true, prepend to buffer, otherwise append.
prepend parameter does not exist in this variant. Why is that? Is CO_AEAD_TAG_AT_THE_END now always true?



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/507?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I01e258e97351b5aa4b9e561f5b35ddc2318569e2
Gerrit-Change-Number: 507
Gerrit-PatchSet: 2
Gerrit-Owner: plaisthos <arne-openvpn@...1227...>
Gerrit-Reviewer: flichtenheld <frank@...2641...>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...1227...>
Gerrit-Comment-Date: Mon, 05 Feb 2024 11:24:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[-- Attachment #2: Type: text/html, Size: 6970 bytes --]