From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E604DC072B5 for ; Fri, 24 May 2019 20:18:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B04BB2133D for ; Fri, 24 May 2019 20:18:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="H7luySoA"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="H7luySoA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403785AbfEXUSS (ORCPT ); Fri, 24 May 2019 16:18:18 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:42766 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403773AbfEXUSS (ORCPT ); Fri, 24 May 2019 16:18:18 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id AD5BC60907; Fri, 24 May 2019 20:18:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1558729097; bh=nXPciAhWumJxn8iXyonu0dWDccJ+9SfgHSe1wd3MTyY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=H7luySoAkb5M6VH3+IXcn1QRi6gvP73vVrKZO+M7cSdSvk6N+md+fGbLnnK80cj5Y pLsT1OG3dDkUUsrhiVc3rUXxKp6mZlQ4Pyv+9UIbj6vO+oCF/QjgmRbTcBP+s02tPV NPv54za0+026YDGVwjBujDZlKnklUwTHPdwO0blA= Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id EECE960388; Fri, 24 May 2019 20:18:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1558729097; bh=nXPciAhWumJxn8iXyonu0dWDccJ+9SfgHSe1wd3MTyY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=H7luySoAkb5M6VH3+IXcn1QRi6gvP73vVrKZO+M7cSdSvk6N+md+fGbLnnK80cj5Y pLsT1OG3dDkUUsrhiVc3rUXxKp6mZlQ4Pyv+9UIbj6vO+oCF/QjgmRbTcBP+s02tPV NPv54za0+026YDGVwjBujDZlKnklUwTHPdwO0blA= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 24 May 2019 13:18:16 -0700 From: Abhinav Kumar To: Sean Paul Cc: dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Sean Paul , Stephen Boyd , Rob Clark , linux-arm-msm@vger.kernel.org, linux-arm-msm-owner@vger.kernel.org Subject: Re: [PATCH 2/2] drm/msm/dpu: Remove _dpu_debugfs_init In-Reply-To: <20190524173231.5040-2-sean@poorly.run> References: <20190524173231.5040-1-sean@poorly.run> <20190524173231.5040-2-sean@poorly.run> Message-ID: <8d0b87d94fd3fa4468965753e7c325c1@codeaurora.org> X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2019-05-24 10:32, Sean Paul wrote: > From: Sean Paul > > Fold it into dpu_debugfs_init. > > Cc: Stephen Boyd > Signed-off-by: Sean Paul Reviewed-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > index d77071965431..0a8c334c3a9f 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > @@ -231,8 +231,9 @@ void *dpu_debugfs_create_regset32(const char > *name, umode_t mode, > regset, &dpu_fops_regset32); > } > > -static int _dpu_debugfs_init(struct dpu_kms *dpu_kms, struct drm_minor > *minor) > +static int dpu_kms_debugfs_init(struct msm_kms *kms, struct drm_minor > *minor) > { > + struct dpu_kms *dpu_kms = to_dpu_kms(kms); > void *p = dpu_hw_util_get_log_mask_ptr(); > struct dentry *entry; > > @@ -578,13 +579,6 @@ static int _dpu_kms_drm_obj_init(struct dpu_kms > *dpu_kms) > return ret; > } > > -#ifdef CONFIG_DEBUG_FS > -static int dpu_kms_debugfs_init(struct msm_kms *kms, struct drm_minor > *minor) > -{ > - return _dpu_debugfs_init(to_dpu_kms(kms), minor); > -} > -#endif > - > static long dpu_kms_round_pixclk(struct msm_kms *kms, unsigned long > rate, > struct drm_encoder *encoder) > { From mboxrd@z Thu Jan 1 00:00:00 1970 From: Abhinav Kumar Subject: Re: [PATCH 2/2] drm/msm/dpu: Remove _dpu_debugfs_init Date: Fri, 24 May 2019 13:18:16 -0700 Message-ID: <8d0b87d94fd3fa4468965753e7c325c1@codeaurora.org> References: <20190524173231.5040-1-sean@poorly.run> <20190524173231.5040-2-sean@poorly.run> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190524173231.5040-2-sean@poorly.run> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sean Paul Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, Stephen Boyd , Sean Paul , freedreno@lists.freedesktop.org, linux-arm-msm-owner@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gMjAxOS0wNS0yNCAxMDozMiwgU2VhbiBQYXVsIHdyb3RlOgo+IEZyb206IFNlYW4gUGF1bCA8 c2VhbnBhdWxAY2hyb21pdW0ub3JnPgo+IAo+IEZvbGQgaXQgaW50byBkcHVfZGVidWdmc19pbml0 Lgo+IAo+IENjOiBTdGVwaGVuIEJveWQgPHN3Ym95ZEBjaHJvbWl1bS5vcmc+Cj4gU2lnbmVkLW9m Zi1ieTogU2VhbiBQYXVsIDxzZWFucGF1bEBjaHJvbWl1bS5vcmc+ClJldmlld2VkLWJ5OiBBYmhp bmF2IEt1bWFyIDxhYmhpbmF2a0Bjb2RlYXVyb3JhLm9yZz4KPiAtLS0KPiAgZHJpdmVycy9ncHUv ZHJtL21zbS9kaXNwL2RwdTEvZHB1X2ttcy5jIHwgMTAgKystLS0tLS0tLQo+ICAxIGZpbGUgY2hh bmdlZCwgMiBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfa21zLmMKPiBiL2RyaXZlcnMvZ3B1L2Ry bS9tc20vZGlzcC9kcHUxL2RwdV9rbXMuYwo+IGluZGV4IGQ3NzA3MTk2NTQzMS4uMGE4YzMzNGMz YTlmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9rbXMu Ywo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9rbXMuYwo+IEBAIC0y MzEsOCArMjMxLDkgQEAgdm9pZCAqZHB1X2RlYnVnZnNfY3JlYXRlX3JlZ3NldDMyKGNvbnN0IGNo YXIKPiAqbmFtZSwgdW1vZGVfdCBtb2RlLAo+ICAJCQlyZWdzZXQsICZkcHVfZm9wc19yZWdzZXQz Mik7Cj4gIH0KPiAKPiAtc3RhdGljIGludCBfZHB1X2RlYnVnZnNfaW5pdChzdHJ1Y3QgZHB1X2tt cyAqZHB1X2ttcywgc3RydWN0IGRybV9taW5vciAKPiAqbWlub3IpCj4gK3N0YXRpYyBpbnQgZHB1 X2ttc19kZWJ1Z2ZzX2luaXQoc3RydWN0IG1zbV9rbXMgKmttcywgc3RydWN0IGRybV9taW5vciAK PiAqbWlub3IpCj4gIHsKPiArCXN0cnVjdCBkcHVfa21zICpkcHVfa21zID0gdG9fZHB1X2ttcyhr bXMpOwo+ICAJdm9pZCAqcCA9IGRwdV9od191dGlsX2dldF9sb2dfbWFza19wdHIoKTsKPiAgCXN0 cnVjdCBkZW50cnkgKmVudHJ5Owo+IAo+IEBAIC01NzgsMTMgKzU3OSw2IEBAIHN0YXRpYyBpbnQg X2RwdV9rbXNfZHJtX29ial9pbml0KHN0cnVjdCBkcHVfa21zIAo+ICpkcHVfa21zKQo+ICAJcmV0 dXJuIHJldDsKPiAgfQo+IAo+IC0jaWZkZWYgQ09ORklHX0RFQlVHX0ZTCj4gLXN0YXRpYyBpbnQg ZHB1X2ttc19kZWJ1Z2ZzX2luaXQoc3RydWN0IG1zbV9rbXMgKmttcywgc3RydWN0IGRybV9taW5v ciAKPiAqbWlub3IpCj4gLXsKPiAtCXJldHVybiBfZHB1X2RlYnVnZnNfaW5pdCh0b19kcHVfa21z KGttcyksIG1pbm9yKTsKPiAtfQo+IC0jZW5kaWYKPiAtCj4gIHN0YXRpYyBsb25nIGRwdV9rbXNf cm91bmRfcGl4Y2xrKHN0cnVjdCBtc21fa21zICprbXMsIHVuc2lnbmVkIGxvbmcgCj4gcmF0ZSwK PiAgCQlzdHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29kZXIpCj4gIHsKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmkt ZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs