From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2069.outbound.protection.outlook.com [40.107.236.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 069135674E; Wed, 9 Oct 2024 01:57:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.69 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728439031; cv=fail; b=TL3ow6MaPgDMdE2PRqp6Lp7b6ZAJbBej0RPj8nylpGjZhDSY09qzw1euLQmfhhPR1RXugMANXaYXIpvYeVz3deZKWByyi9A98qIAR33fPRphoMJkzBFoKsSHK2ZHMBkxtrJAe7l1BPPAxP0Ef+nnM/WxRWWOlUjbylXSIjaR9zY= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728439031; c=relaxed/simple; bh=s10fPyzl5vv4LkJRQ9BKhcOojxcYNzfsZlsV23U4Rks=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=AnTRYeEQNZmuY+ZDP3ZHv/SD1QClEu3KMaqQ5chiXz5oE8xHdubn8JO/0GXQnWIkX28/FjHwpfHgjM5HCRCK9H6wzPcTKBA6jHg+YwltIQBXchkmlsl5GI12zy9u8260NCOOgRn+mHX6yt7TYN/aEFLZCUc0WaOCZvo7J6VUFO4= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=3NG0cfCd; arc=fail smtp.client-ip=40.107.236.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="3NG0cfCd" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FBSsEKzZ3IGnJhRR2hZDJZhpaCVwkphzTbvot4N0UvdW4ybQ3DPYhsb68nr6vZPmllxvkn0Y0ssdY/c8hJNvm/J2rJ818BYx5x7UdKQKubGdWgCPkMAjAhCSJq4/iNr42ADBZpkhZ8hqtGQWWDYcRpu6xzroEHm3xZBctoS3WRyRw33XxK5smq9TsFRrSCgzcQhW7bXcboAmIl+HmwjyKnNhDbjCcDUCksFgLtyezPh73HXkGsfYgwp9309AECnGU17ea+20110xpFkBmm+AkqD4OW3grwAIGK7u9YUz58Z3pmIiamuOClKCWd6Gh4Ml77n/mq2K8GT4sDfrZO7myA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j/tCEc7T5Ta1hhaaI0vA44Jh1ecyV/oPem67UavuVc0=; b=MshyL2Q8F94vi7IcjVeCY3DpuEwnCfZ1Y3ouNwU5thc873/hPjZyB/iqzbX2aNQe+E28sWfLP97hSq0IJ46X7Rim8soWDv0HNEI5u946G5lVs3p5uTs683U77YR8uLk1CpEJ4B28b2kOn7x8S5wYSacEnqPvra/lVP+bLMsrtG5NKskS5nk2znIMZWaNVLsGhkdQrENLAsKUxUoq/9Qtma72Kk0xjjeaOypoMeWl5kaxZi3tk6yTPST9OmMCfEnc0CyNPxZRhkIfG8pj6PkpAQGCp/x8QiE2voGBiY0xZDS8BEhis9EvnTFqGvQRteHAFIeA0LVUWM698bLc5n0BXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j/tCEc7T5Ta1hhaaI0vA44Jh1ecyV/oPem67UavuVc0=; b=3NG0cfCdO7PuFX/6lY8YIlC/lMa1TBbduH2EJzO/nTzVuZ2HUa2mIYRrjkNUQLyqSF+yeFE6tpAtFl/Z6aZ6XpDDnA/nm2Qe7UK3G8kzCFF6ycl61RNA9Dz6CoM50Taq21u5xyW1hyKJlwS3z5vUZAOdWvDuM9w1ramhAhC48zM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DS0PR12MB6608.namprd12.prod.outlook.com (2603:10b6:8:d0::10) by BY5PR12MB4099.namprd12.prod.outlook.com (2603:10b6:a03:20f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.16; Wed, 9 Oct 2024 01:57:06 +0000 Received: from DS0PR12MB6608.namprd12.prod.outlook.com ([fe80::b71d:8902:9ab3:f627]) by DS0PR12MB6608.namprd12.prod.outlook.com ([fe80::b71d:8902:9ab3:f627%3]) with mapi id 15.20.8026.020; Wed, 9 Oct 2024 01:57:06 +0000 Message-ID: <8d0f9d2c-0ae4-442c-9ee4-288fd014599f@amd.com> Date: Wed, 9 Oct 2024 07:26:55 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 01/14] x86/apic: Add new driver for Secure AVIC Content-Language: en-US To: Borislav Petkov Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, Thomas.Lendacky@amd.com, nikunj@amd.com, Santosh.Shukla@amd.com, Vasant.Hegde@amd.com, Suravee.Suthikulpanit@amd.com, David.Kaplan@amd.com, x86@kernel.org, hpa@zytor.com, peterz@infradead.org, seanjc@google.com, pbonzini@redhat.com, kvm@vger.kernel.org References: <20240913113705.419146-1-Neeraj.Upadhyay@amd.com> <20240913113705.419146-2-Neeraj.Upadhyay@amd.com> <20241008191556.GNZwWE7EsxceGh4HM4@fat_crate.local> From: Neeraj Upadhyay In-Reply-To: <20241008191556.GNZwWE7EsxceGh4HM4@fat_crate.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PNYP287CA0022.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:23d::26) To DS0PR12MB6608.namprd12.prod.outlook.com (2603:10b6:8:d0::10) Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6608:EE_|BY5PR12MB4099:EE_ X-MS-Office365-Filtering-Correlation-Id: 94817e99-8611-4211-b1e6-08dce805ad75 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SnB3TmdUZWp5eEI5M01wVWdMaEJBcEl1OU56WkNrWkduamJhc2h3OEJpQ3pN?= =?utf-8?B?dGJaQ045UlE2dVJDZVY0UlBMcXM1ZzhzQ3doSFIzQ1VFUDU2TEtUWmR0aFB4?= =?utf-8?B?NUJ4M3dic3I3ZGl3RUc2R3psNE9nZ0duVjVtS1hpWHdNcGZkNUQ5b1g4UGJF?= =?utf-8?B?azltNXlwTXJ6RVd0aklvS1BoZ2xBTEdiNlNadDI3MHpld2MySlhleFkzVkFw?= =?utf-8?B?TEh5Y05nb0RSTzJCKzA3MFF6a3dPWFdFQ0xEOTZJUEVVKzMvWUhXWXd1NXcv?= =?utf-8?B?L294UVc5OFlXMyt5TFVySk92OW1MZmJBamFSRmxmTGRsMWZqRW82b1FIa2F1?= =?utf-8?B?K005NFRpTW11NC9wd3dQa3ZLZ0JzYWpKdHBsMTZCajlQZ1BERXlmWS9HcjdK?= =?utf-8?B?emJlK2Z4OFVKOE1HamxJaVQrdzJQODVXT1dZczhtNG1VWFgxTWltTFc4Mi9x?= =?utf-8?B?ZUI4VTdUM05tU0JsL1JRZ3BucFBoZExNMVp0YThzVVY3dnY3ZjlHZFlaZkNR?= =?utf-8?B?cmVGdnBtK3dDVzJpOXZPQTRCY09XUUFQd2RqbXl4ZldRaGhTTVRSZWM4QzZs?= =?utf-8?B?V3I1NHg0czVzNFF2VXZSU0VzVS9nT2xjV3ZRSi9Sc0VIVTJVYkpkV0VvMFNh?= =?utf-8?B?bHUwT3gxaXVXMHhGdStJZFV1R0xJNmVGUS83WXhzSmNPWjY0Y0Q2eEpWZjd6?= =?utf-8?B?OE9ncG02NnRuVk56N3JySnREZzJaNnlnUWxTNG1rM2pGZWwvamhNT1cwY3Iv?= =?utf-8?B?NkZQMkYwUlRCcFpXUERXV3VydmsrRWpISyswNWsxcHI5bSt3WFpBSWVTWXQ4?= =?utf-8?B?Zk5Cd0dhYWl4OFpSbTFhVnVyckRRcHB4VlhoamExTnQ0NTRnTEJiS0JieWEx?= =?utf-8?B?WmQ2cjk2ckpMOHRYUkZhQ2tPWlc2Q3g0RHJleTRUUnFoMHJBVzdCVEtXRGJQ?= =?utf-8?B?aytkditSck03bW55K25zR0xrRkFtYmwrdkd6Zy9VdSt1Y25XRmdsVDVXWjlF?= =?utf-8?B?cVd2M01zR3k0VHg1NmhFYmFaczFFbEtJc1EyUCtpSktrcVhRMFRIazhxbWFG?= =?utf-8?B?OVVhWCtWbHBJdWV6RHp1MXE5bjcwcW51UFYxSGY0US9Wb1Q0aTZlVW11UzhK?= =?utf-8?B?ZjB1NEQ1Mm92VWtCMlFvWkRMWm1yU3A4RkVNZGNwMEdvdm5oTElSVUlWL3ZX?= =?utf-8?B?ZG8zSU1EMnJuTXZwSmVpN1VFK28wcjBRNVNiUE9SeEFXdC9QOURWaFp6R0w3?= =?utf-8?B?U3VSMVRITWZZSTFGRmdFTUhWYlRoTnBEYUlaTFFMTEFlVERTaFJGb2dhUFQy?= =?utf-8?B?bGNyOWltTVhoTTVXY012U3lEQWI5TWgyNHZET05YZk1IS05jUkNoUUhhSjBP?= =?utf-8?B?SnR6dEUzQ3d0RzI5WHJpZ2dLdFk4ME5PdDJVRk12Y1QvZTNFR29LTmY5SVB6?= =?utf-8?B?VmFjUlVkTEErL05jZjhQQjh5TmZObjMrajk2ckNLeHJ6UzlobE1pdWI5QVhB?= =?utf-8?B?cVY0VWx2a3JGQUxBZ2N1cWgyMXZzZWM0ZFI5bnE2Z295SHJOMyt4ZEZLUU5h?= =?utf-8?B?ak9LanJBVXVDR1ZuQk1tNkcvbWpkbjRXemkzRlhJZVRUQWV5TVZFQmFlNGxZ?= =?utf-8?B?SXR0TUtKbGMxZE96N1ZBK1JxRHl2WWYvaFRZNTdCUUZzeUNyRzFFWjJGQXZL?= =?utf-8?B?b3p0QmZvYUdlMzllUEoxaHJrbDJmZG0rLzkrOUN0RzBVSm44V3pDbWx3PT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6608.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bk5XQlhUbGVtckh1aU9BY1lDU0ZZUE4vWGlBVkhsVW5pdUlOaHZ1czhLQWxF?= =?utf-8?B?c2pmMDNZakRqcGxZcWZKbEQ5T1dHbkZOYStzSUxUMTlaa0FySUZVeVZTTFIy?= =?utf-8?B?YmtzRGZ1ZzBpV1Arb0RGcnA0cSt3Nmg1MTFSQ21xUVB6NUo2dFpMbncyNnRL?= =?utf-8?B?TE9xMEl4amJiazI4TjNXT1kxT0kxSVlMTE9aSnBGVXpmL1N0aHhFT1hYWGZG?= =?utf-8?B?L3VPREpMTVdTN0ZpU1VjOXNLa1YrZktkOEhpaWFyZDFnRVJtWlNmQXdOQ2g5?= =?utf-8?B?T3BjQVJLWmJnYUhDY0dsc0MyR3pPb0FSTVpibElKcFFTdllPNjJyWWlSK3du?= =?utf-8?B?aWtjYzZ1MWdMMGwzalFDTXIvdFRYdFcrRWlGOE9EcURjMDBkakcvT3A5WEd1?= =?utf-8?B?QWJ3NDExcTllV0JJamtiaFZoUnVWTXpiWVRrcklXMldJK2xURklPaE8xZ05T?= =?utf-8?B?ZUNMaUhnb1AxNG5DT0pjL24yV3laY1Awb0hKclJDaEtEbDBadmF0RjBjRTVm?= =?utf-8?B?R1YvR0VLbFhRV29NZ3FUY0FEdGNqZDJnR0IvQ0EyLzF0SE41SVU3YjFNQW5Q?= =?utf-8?B?M1hwQjFMam5IeEFZTkVrOEpBSGFZZXI2VUxFUExuWWE0aFdFV3pPZ2szTWQ5?= =?utf-8?B?SnA2N2RNY2gzcXdCaTcvbTNhWUZaRFQreWdNdmgrSkdZc05uRCtsZTBKTzgw?= =?utf-8?B?SHY1Zzl6T3FtemRjOWV3WEEwU0JOZDB6QUIwMlM4M0FxN3RJWWtDenB4Wi9w?= =?utf-8?B?bjVZdmh5ZTJIS08zZytzcW9nc1huQmZXeldySWxCMENIQm8ySFhQK3lWUzVY?= =?utf-8?B?RDV5ZVpHdldGamdVWW96MzZBK1hqTWZUT0RvcFA1Q2dvY0hUd0lSL2JQMFVO?= =?utf-8?B?aEVHZnE0Zm1LL0g3ZHhwcjQ5TGdYZHdmYmoyZDlHa2drQjF1NFlCYU91d1dT?= =?utf-8?B?bXFsUFdiOWRDNVVJN0pYZjIvelFqQWdFMVRGdjZic1I4OVFWQVhhN2ZJVUE3?= =?utf-8?B?NUN1QzdRZFlsR2pxV2dDZVBMMzkxR3ZyMUZ3U3I5d0Z1RmFxVHRWdjNsTk1J?= =?utf-8?B?UDFuVGJUOW1WSVg3S08wdWlLQVhGSTJPbVllblo0NE9MeFN3TkpmWUQwYjFS?= =?utf-8?B?dHRsTThlSENkRVd2bVRCZmlRVXpaM05OOGRnR1lRSHlEMEIyZW5Yb1ZMZDNx?= =?utf-8?B?VFVmTjNsNnR2VjVYdi9YN1FTdm0ydW5rQ1ZHNFBGMVA2M3FiZ2FNc2FhZ1dT?= =?utf-8?B?L1AzQkRUazg0eTV1bnZJZjEySzNabGhJT080M041Ykx4bHhwcCt3MVJpcCtR?= =?utf-8?B?cXFvRGgzMjBxODczZWF4SnNaY2tHTmtEd3lzamZ2enI2bko1djBMOGpKUzBz?= =?utf-8?B?U0ZjRDNUU0JhL3VTYnVmNzFBVmlaWHJDUU14ZUpUY0FXcW5MdVJxcUVzR1d4?= =?utf-8?B?Y1loTGtVcXZMWjc1UGJrT09VTWRoTEZoNmcvc0FVVlFET1BFUnRkOGZtQnFV?= =?utf-8?B?MkNBSWwxekxMWnpHdUR1ME5kaEtLSnAzOUwwWkhzak14L0YxVVVjSFR6d0xw?= =?utf-8?B?a3NDckNJRzAxMUZGU3p0UkUwRW02KzBWY1IxZjBzcE5oSlVrTUVQQmF2bmsy?= =?utf-8?B?Q0RoRlJoelBqUUFxNnpLclV2cHZ4R0ZUV0labGRSUUdhemp4dFUwQ1NzU2dJ?= =?utf-8?B?Z2VLZS96M0JoZGluZVFFT3NjY2xkR1lkYWhnSmR4c0ppRERzRHR6dUFWdW1V?= =?utf-8?B?NDFrUDJFaWtvZW1lb085QTBGUFRuT2xRamJKVzVQd21nK29qR1pUUmZPWTNU?= =?utf-8?B?L1RocWcxZDlKMzNsZXZHaTJ4UjBaNHdUU0FhNkQvRXdBa0JyUURwL25Pb0Ni?= =?utf-8?B?VVA1ZS9zWk91bkFBSW41N3ZHTnRpbCt5RmtYQkhoa1U1NDlCWkxieWVkZ1RL?= =?utf-8?B?TU1NR1R3M0RqUCtMZENVc2V5VEFuVi9STVVyYjBjK3RLckFMbEtYNE9PT0pJ?= =?utf-8?B?WUpmZHBleU9xU1hqUGl1ZWFvclRyYXNDaUw5YXJ6Vk13YW1Ga0NWWE1wczR1?= =?utf-8?B?NkpUbnV2RHRtSjVjOTNSQXpXaXZNbU9jYXcxRmhuVUUzeWNRS3BZV083ME1p?= =?utf-8?Q?GOOkiSnVgjevrQlkQuVcu0C7N?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 94817e99-8611-4211-b1e6-08dce805ad75 X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6608.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2024 01:57:06.5742 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: R8geJgt8TeUlzM+2bjpEDXgWg0PkVFQell5cePLOXZa/lROGLipath6VRSomsmwciC1ti3Kw+tt7IRh+/Z+emQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4099 On 10/9/2024 12:45 AM, Borislav Petkov wrote: > On Fri, Sep 13, 2024 at 05:06:52PM +0530, Neeraj Upadhyay wrote: >> diff --git a/arch/x86/boot/compressed/sev.c b/arch/x86/boot/compressed/sev.c >> index cd44e120fe53..ec038be0a048 100644 >> --- a/arch/x86/boot/compressed/sev.c >> +++ b/arch/x86/boot/compressed/sev.c >> @@ -394,6 +394,7 @@ void do_boot_stage2_vc(struct pt_regs *regs, unsigned long exit_code) >> MSR_AMD64_SNP_VMSA_REG_PROT | \ >> MSR_AMD64_SNP_RESERVED_BIT13 | \ >> MSR_AMD64_SNP_RESERVED_BIT15 | \ >> + MSR_AMD64_SNP_SECURE_AVIC_ENABLED | \ >> MSR_AMD64_SNP_RESERVED_MASK) >> >> /* > > Shouldn't this hunk be in the last patch of the series, after all the sAVIC > enablement has happened? > As SECURE_AVIC feature is not supported (as reported by snp_get_unsupported_features()) by guest at this patch in the series, it is added to SNP_FEATURES_IMPL_REQ here. The bit value within SNP_FEATURES_IMPL_REQ hasn't changed with this change as the same bit pos was part of MSR_AMD64_SNP_RESERVED_MASK before this patch. In patch 14 SECURE_AVIC guest support is indicated by guest. - Neeraj