Re: [yocto-patches] [PATCH meta-rockchip] orangepi-3b: add

[Michael Opdenacker <michael.opdenacker@rootcommit.com>]

Hi Quentin

Thanks a lot for the review!

On 11/20/25 11:35, Quentin Schulz via lists.yoctoproject.org wrote:
> Hi Michael,
>
> On 11/20/25 11:25 AM, Michael Opdenacker via lists.yoctoproject.org 
> wrote:
>>
>> +++ b/conf/machine/orangepi-3b.conf
>> @@ -0,0 +1,11 @@
>> +#@TYPE: Machine
>> +#@NAME: Orange Pi 3B v2.1
>> +#@DESCRIPTION: 3th generation SBC designed by Kunlong Co.,Limited.
>
> Not sure the board identifier number really is synonym of generation. 
> In any case, should be "3rd" I guess :)


Oops, indeed!
I just imitated the machine file for OrangePi 5 plus, which claimed it 
was 5th generation.
I'll remove this mention of a generation which is indeed dubious.

>
>> +#http://www.orangepi.org/html/hardWare/computerAndMicrocontrollers/details/Orange-Pi-3B.html 
>>
>> +
>> +require conf/machine/include/rk3566.inc
>> +
>> +KERNEL_DEVICETREE = "rockchip/rk3566-orangepi-3b-v2.1.dtb"
>
> There's also another device tree in the kernel tree for an earlier 
> version:
>
> rockchip/rk3566-orangepi-3b-v1.1.dtb
>
> I think we should probably also have it in KERNEL_DEVICETREE.
>
> Looking at the U-Boot code, the bootloader should be able to load the 
> proper DTB based on some runtime detection.

Very cool, done!
This looks like the best way to handle this.

>
> In which case, the NAME part at the top should simply say Orange Pi 3B.
>
Indeed, fixed too.
>
> Otherwise looks good to me!

Thanks again.

A V2 is coming soon once I'm done testing.
Cheers
Michael.

-- 
Michael Opdenacker
Root Commit
Yocto Project and OpenEmbedded Training course - Learn by doing:
https://rootcommit.com/training/yocto/