From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A9A6C433E0 for ; Fri, 5 Feb 2021 11:56:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C11F464DEB for ; Fri, 5 Feb 2021 11:56:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232046AbhBELzq (ORCPT ); Fri, 5 Feb 2021 06:55:46 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:39324 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231640AbhBELx1 (ORCPT ); Fri, 5 Feb 2021 06:53:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612525919; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mmCktuOnRm7rRjEffV558V46c1+z05lPxqdaC1i8oXk=; b=Yqdg6yQQYRSD/f5I0/ddr58ZA/cnZSYHZ6JXdwPcPOgiIzwpBDojtQRnqXhQibQHoVIO6e hMWk2Bu1F3s6cg8+GzLFXgrPah2k+3t07CYzylwBEgXEbLd3ck86zCQUnUfJSw/B4p6RFm /N2qIv9PmvuDPadLgFmtAxcttBliNsc= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-283-liI_NGT2ObuRRdvJVRIgog-1; Fri, 05 Feb 2021 06:51:55 -0500 X-MC-Unique: liI_NGT2ObuRRdvJVRIgog-1 Received: by mail-wr1-f71.google.com with SMTP id o17so5219336wrv.4 for ; Fri, 05 Feb 2021 03:51:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mmCktuOnRm7rRjEffV558V46c1+z05lPxqdaC1i8oXk=; b=H7n4k9h1sWVDQaeN1kyy4ccpGTpldTOwnIzqAYpUm5W9w2Yvkj6jbp4JOItAAxsgAF 5pay/ATGWmJV1+9yaz75xsO8JySYcHAJbrusv9idW6V3FIUjYAQk5gSIjIh2J4FeEHgh Rs1p1aqpwoT+qJJdZoLud51EAiRvLWoUNm01AI8PAKkK8LNAYFJK7kjxh4zmZe9QhiC4 eL4tOYTxZWup58T6efZP7CxMR7iJ94OLODeaRk57tIo/UV1IkxFCOcu8IYIAIwx80gUK 5zGL5z6l3z1kfeUopPo5KoyHp2OXsAckjH/d27wQ7Rnh/rUbKUrfUgj+XL5LKZ2y/MsD Ih1g== X-Gm-Message-State: AOAM532tAVMGzS5jKUL3ZINF5RLoXZsJLI85xLQTNz00oDnG9n3RM4gI jhrpNANbmKnA2sRtlG0pvauFzEnJN4yQgyOZ5INJBqD1wBQuM5wVmxc87xSXCcErw6Zn8axPdF3 QXZwLjnGkwlo9 X-Received: by 2002:a05:600c:4fce:: with SMTP id o14mr3263776wmq.140.1612525914673; Fri, 05 Feb 2021 03:51:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJw2gHg/2LaVDfOa4pIwMU2N3KtRRpiG6VEYIyPS0S37HVi+oNl+bw+W5N9Ew7QjDxE+m8sczQ== X-Received: by 2002:a05:600c:4fce:: with SMTP id o14mr3263752wmq.140.1612525914440; Fri, 05 Feb 2021 03:51:54 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id o18sm8586376wmh.20.2021.02.05.03.51.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Feb 2021 03:51:53 -0800 (PST) To: Thomas Gleixner , Borislav Petkov Cc: Chenyi Qiang , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Xiaoyao Li , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, "x86@kernel.org" , Andy Lutomirski References: <20210205083706.14146-1-chenyi.qiang@intel.com> <20210205083706.14146-3-chenyi.qiang@intel.com> <8768ad06-e051-250d-93ec-fa4d684bc7b0@redhat.com> <20210205095603.GB17488@zn.tnic> <87czxeah1z.fsf@nanos.tec.linutronix.de> From: Paolo Bonzini Subject: Re: [PATCH v4 2/5] KVM: X86: Expose PKS to guest Message-ID: <8da4bfbb-b2fc-968f-dfea-aa73f11c6405@redhat.com> Date: Fri, 5 Feb 2021 12:51:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <87czxeah1z.fsf@nanos.tec.linutronix.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 05/02/21 12:29, Thomas Gleixner wrote: > On Fri, Feb 05 2021 at 11:10, Paolo Bonzini wrote: >> On 05/02/21 10:56, Borislav Petkov wrote: >>>> This would need an ack from the x86 people. Andy, Boris? >>> >>> This looks like the PKS baremetal pile needs to be upstream first. >> >> Yes, it does. I would like to have an ack for including the above two >> hunks once PKS is upstream. >> >> I also have CET and bus lock #DB queued and waiting for the bare metal >> functionality, however they do not touch anything outside arch/x86/kvm. > > What's the exact point of queueing random stuff which lacks bare metal > support? The code is often completely independent of bare metal support even if it depends of it (CET and bus lock for example only share the #defines; for PKS this is not the case just because Intel decided not to use XSAVES *shrug*). I prefer to queue early, because it keeps my backlog small and because every resend comes with the risk of random changes sneaking in since the version that I reviewed. An early ack would also mean that I don't have to bug you in the middle of the merge window. But it's not a problem, I'll ask for acks again once PKS is merged into tip. Thanks, Paolo > Once PKS, CET or whatever is merged into tip then it's the point for > resending the KVM patches for inclusion and that's the point where it > gets acked and not $N month ahead when everything is still in flux.