From: Vasant Hegde via iommu <iommu@lists.linux-foundation.org>
To: iommu@lists.linux-foundation.org, joro@8bytes.org
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] iommu/amd: Remove redundant check
Date: Mon, 28 Mar 2022 14:58:29 +0530 [thread overview]
Message-ID: <8db6b69f-7a33-359c-db74-35df7c115010@amd.com> (raw)
In-Reply-To: <20220314070226.40641-1-vasant.hegde@amd.com>
Joerg,
Ping.
-Vasant
On 3/14/2022 12:32 PM, Vasant Hegde via iommu wrote:
> smatch static checker warning:
> drivers/iommu/amd/init.c:1989 amd_iommu_init_pci()
> warn: duplicate check 'ret' (previous on line 1978)
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Fixes: 06687a03805e ("iommu/amd: Improve error handling for amd_iommu_init_pci")
> Signed-off-by: Vasant Hegde <vasant.hegde@amd.com>
> ---
> drivers/iommu/amd/init.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c
> index 2586e589e54e..8ed1f86fe93d 100644
> --- a/drivers/iommu/amd/init.c
> +++ b/drivers/iommu/amd/init.c
> @@ -2137,8 +2137,7 @@ static int __init amd_iommu_init_pci(void)
> for_each_iommu(iommu)
> iommu_flush_all_caches(iommu);
>
> - if (!ret)
> - print_iommu_info();
> + print_iommu_info();
>
> out:
> return ret;
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2022-03-28 9:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 7:02 [PATCH] iommu/amd: Remove redundant check Vasant Hegde via iommu
2022-03-28 9:28 ` Vasant Hegde via iommu [this message]
2022-04-28 7:58 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8db6b69f-7a33-359c-db74-35df7c115010@amd.com \
--to=iommu@lists.linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=joro@8bytes.org \
--cc=vasant.hegde@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.