From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0CF8C2BA19 for ; Thu, 9 Apr 2020 18:24:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A36C12051A for ; Thu, 9 Apr 2020 18:24:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aMaO6MI5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726609AbgDISYh (ORCPT ); Thu, 9 Apr 2020 14:24:37 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:46532 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726582AbgDISYh (ORCPT ); Thu, 9 Apr 2020 14:24:37 -0400 Received: by mail-lf1-f68.google.com with SMTP id m19so353333lfq.13; Thu, 09 Apr 2020 11:24:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fa26jqPPtzIkc//RtMH6SVR58k747j0sywbqTRpv304=; b=aMaO6MI5RtYfDEKWn9t0hPBC+iiaGTHCKRHtqhDSpYRMdBINmseVb852oVgHht6hPG fd5K+uLll0UGAFw7Ko66nAjKVrlhMMp65nYW03VLlXPRaY5atpmWKGaXhAtAb6xCClV6 N47yqVKTXIOkz8e1N84nDPdfP9RrkXWPvqVNvtCeWnZrcO5m7hm7hcheYrI9c+na0Xow +vd9UPBZHs9OesASsdiq182qwSHO+rFmLE70XnZdIBKxF84e6TEcDUkS3c+EToF3JiTA dM95arlpy/Idu/NqW0rGgaHFtWN2RkP0URVjCMUNSOkAKTqoAPag5CwvxT/dKtmXCGUj A1qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fa26jqPPtzIkc//RtMH6SVR58k747j0sywbqTRpv304=; b=HMd8rcob4UOZc1YvQoIAVp7CeQRpiU+GGJ6uhs5QVcZhpw1Bjv7fT+mDNCd5Sx5hHr DANoKrDEUuSrclign39Y0mZeNy7+rQ+iziURyrSMB28VV562r9QQY+zfTKkFsKucrx2j ypj83eR2yckJhg36JYMhEnI+PKAUnZBfn3fmQn8vKk2EDdKCuPy3P0tcubfaYf4l9XXW 0twK24Ku28goqOSoyXs5qWyIaCN6HLG8CY5ScwZxtx7sTmKvG39eWd4zAYWeqis86qk0 eZ/7MhG2UdhDK28PsucYX3egdts1qy25HRUYMdA0tkfLbaxbSPEa+jg0EjWBbqYmkBCM V7wA== X-Gm-Message-State: AGi0PuZaFjWIe2LZboAmKYQh83LbwTHNKOSfOMRrJRtn6ff4vixYNuGC +xzOEuIeODaATzsXJt2X3As= X-Google-Smtp-Source: APiQypKBIIC1fFOKcSXJcsM3k16YK6Uo7dy37UIDlG+baWYmUXAJIkTaBwCpQaQHtwMdvrWhiCEcxg== X-Received: by 2002:a05:6512:443:: with SMTP id y3mr371032lfk.166.1586456673273; Thu, 09 Apr 2020 11:24:33 -0700 (PDT) Received: from [192.168.2.145] (ppp91-78-208-152.pppoe.mtu-net.ru. [91.78.208.152]) by smtp.googlemail.com with ESMTPSA id w7sm2108193lji.92.2020.04.09.11.24.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Apr 2020 11:24:32 -0700 (PDT) Subject: Re: [PATCH v6 07/14] clk: tegra: Implement Tegra210 EMC clock To: Thierry Reding , Rob Herring Cc: Jon Hunter , Michael Turquette , Stephen Boyd , Joseph Lo , linux-tegra@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20200409175238.3586487-1-thierry.reding@gmail.com> <20200409175238.3586487-8-thierry.reding@gmail.com> From: Dmitry Osipenko Message-ID: <8dc000fb-8867-cf8f-8204-a9e1e79a4811@gmail.com> Date: Thu, 9 Apr 2020 21:24:31 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200409175238.3586487-8-thierry.reding@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org 09.04.2020 20:52, Thierry Reding пишет: ... > +static long tegra210_clk_emc_round_rate(struct clk_hw *hw, unsigned long rate, > + unsigned long *prate) > +{ > + struct tegra210_clk_emc *emc = to_tegra210_clk_emc(hw); > + struct tegra210_clk_emc_provider *provider = emc->provider; > + unsigned int i; > + > + if (!provider || !provider->configs || provider->num_configs == 0) > + return clk_hw_get_rate(hw); This still looks wrong to me. Nobody should be able to get EMC clock until provider is registered. This is troublesome, especially given that you're allowing the EMC driver to be compiled as a loadable module. For example, this won't work with the current ACTMON driver because it builds OPP table based on the clk-rate rounding during the driver's probe, so it won't be able to do it properly if provider is "temporarily" missing. ... I think that in a longer run we should stop manually building the ACTMON's OPP table and instead define a proper OPP table (per-HW Speedo ID, with voltages) in a device-tree. But this is just a vague plans for the future for now. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH v6 07/14] clk: tegra: Implement Tegra210 EMC clock Date: Thu, 9 Apr 2020 21:24:31 +0300 Message-ID: <8dc000fb-8867-cf8f-8204-a9e1e79a4811@gmail.com> References: <20200409175238.3586487-1-thierry.reding@gmail.com> <20200409175238.3586487-8-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20200409175238.3586487-8-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Thierry Reding , Rob Herring Cc: Jon Hunter , Michael Turquette , Stephen Boyd , Joseph Lo , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-tegra@vger.kernel.org 09.04.2020 20:52, Thierry Reding пишет: ... > +static long tegra210_clk_emc_round_rate(struct clk_hw *hw, unsigned long rate, > + unsigned long *prate) > +{ > + struct tegra210_clk_emc *emc = to_tegra210_clk_emc(hw); > + struct tegra210_clk_emc_provider *provider = emc->provider; > + unsigned int i; > + > + if (!provider || !provider->configs || provider->num_configs == 0) > + return clk_hw_get_rate(hw); This still looks wrong to me. Nobody should be able to get EMC clock until provider is registered. This is troublesome, especially given that you're allowing the EMC driver to be compiled as a loadable module. For example, this won't work with the current ACTMON driver because it builds OPP table based on the clk-rate rounding during the driver's probe, so it won't be able to do it properly if provider is "temporarily" missing. ... I think that in a longer run we should stop manually building the ACTMON's OPP table and instead define a proper OPP table (per-HW Speedo ID, with voltages) in a device-tree. But this is just a vague plans for the future for now. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 320EAC2BB55 for ; Thu, 9 Apr 2020 18:24:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 078AB2051A for ; Thu, 9 Apr 2020 18:24:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="S1V96qvv"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aMaO6MI5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 078AB2051A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=n02yUMG3e4WnbkzaflZR5Bj8RioLDRsa863AS26Gzzw=; b=S1V96qvvGW1RxP pfJQzBPUOa4IVebSjgtcJFbK1xwizsaKjExz1a2KQzr3X6WVjtfWYDCrJFBUlWLun5HLhtLZQUHAE NQdoD/fiQQc+wOjKq/puZUow4RHWUN2C5F1b9NsSjyWzm8GUsN16Jy0sXZQl15xdRhpbNQ/bOZF6m 7jk1YTul0i0Umz4O6I6kMBe03xxO37cJXR0v2iLYoMFWYeRjhiW42Pbk83wow8NmgyEPsBrCxgyFh LFsTmC5PwluoLrV958flvXC1imHU2udCrdZ/bBAOpKUicnH66DdYqMiyVFSQ+N1vY5E6JAu9XUbdG TH3LCBSDU8uVLTYnauxA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jMbqz-0002ht-HU; Thu, 09 Apr 2020 18:24:41 +0000 Received: from mail-lf1-x142.google.com ([2a00:1450:4864:20::142]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jMbqw-0002hS-L9 for linux-arm-kernel@lists.infradead.org; Thu, 09 Apr 2020 18:24:40 +0000 Received: by mail-lf1-x142.google.com with SMTP id z23so376758lfh.8 for ; Thu, 09 Apr 2020 11:24:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fa26jqPPtzIkc//RtMH6SVR58k747j0sywbqTRpv304=; b=aMaO6MI5RtYfDEKWn9t0hPBC+iiaGTHCKRHtqhDSpYRMdBINmseVb852oVgHht6hPG fd5K+uLll0UGAFw7Ko66nAjKVrlhMMp65nYW03VLlXPRaY5atpmWKGaXhAtAb6xCClV6 N47yqVKTXIOkz8e1N84nDPdfP9RrkXWPvqVNvtCeWnZrcO5m7hm7hcheYrI9c+na0Xow +vd9UPBZHs9OesASsdiq182qwSHO+rFmLE70XnZdIBKxF84e6TEcDUkS3c+EToF3JiTA dM95arlpy/Idu/NqW0rGgaHFtWN2RkP0URVjCMUNSOkAKTqoAPag5CwvxT/dKtmXCGUj A1qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fa26jqPPtzIkc//RtMH6SVR58k747j0sywbqTRpv304=; b=YMMVIDKlAOpi2S5obmUpzzD+gN0uOr9RpEf9j+NMK+jS9a+WhOxYsg2VzUsQE5R9di Sxp/o68s/j+JCbgROuinDfB+qmniWZqgvU/QGo1vFdmc6TOsWnalOjO2dPJsmpwH0Mgh s7D3h9xZXsDhovW4CcD4uM4/fGJkDQsziOiTdQCdXzEh1rL/u4Njs/VaomcwsDamGruh wpGP0ZN2+qj+9m73Cm2wr9beTaX2G9zXjqaWRKKa1hatua0cgFcApS20/ounA+NInsTB BIilgsVbjUMQXjdcU5Wl8piG/1VxH4TVcc/cqhfH5HxO3kKXfgL+tyXqZk9bPi8xtaAe 21yg== X-Gm-Message-State: AGi0PuZvavAxZidiAGlqjJePGjt4xARXv6yH6XPZ87F2DibM8OGO5TJo TtIqj5K68dBLG0luG5I/tptBQgxF X-Google-Smtp-Source: APiQypKBIIC1fFOKcSXJcsM3k16YK6Uo7dy37UIDlG+baWYmUXAJIkTaBwCpQaQHtwMdvrWhiCEcxg== X-Received: by 2002:a05:6512:443:: with SMTP id y3mr371032lfk.166.1586456673273; Thu, 09 Apr 2020 11:24:33 -0700 (PDT) Received: from [192.168.2.145] (ppp91-78-208-152.pppoe.mtu-net.ru. [91.78.208.152]) by smtp.googlemail.com with ESMTPSA id w7sm2108193lji.92.2020.04.09.11.24.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Apr 2020 11:24:32 -0700 (PDT) Subject: Re: [PATCH v6 07/14] clk: tegra: Implement Tegra210 EMC clock To: Thierry Reding , Rob Herring References: <20200409175238.3586487-1-thierry.reding@gmail.com> <20200409175238.3586487-8-thierry.reding@gmail.com> From: Dmitry Osipenko Message-ID: <8dc000fb-8867-cf8f-8204-a9e1e79a4811@gmail.com> Date: Thu, 9 Apr 2020 21:24:31 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200409175238.3586487-8-thierry.reding@gmail.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200409_112438_717675_202758B1 X-CRM114-Status: GOOD ( 13.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Stephen Boyd , Michael Turquette , Jon Hunter , Joseph Lo , linux-tegra@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org MDkuMDQuMjAyMCAyMDo1MiwgVGhpZXJyeSBSZWRpbmcg0L/QuNGI0LXRgjoKLi4uCj4gK3N0YXRp YyBsb25nIHRlZ3JhMjEwX2Nsa19lbWNfcm91bmRfcmF0ZShzdHJ1Y3QgY2xrX2h3ICpodywgdW5z aWduZWQgbG9uZyByYXRlLAo+ICsJCQkJCXVuc2lnbmVkIGxvbmcgKnByYXRlKQo+ICt7Cj4gKwlz dHJ1Y3QgdGVncmEyMTBfY2xrX2VtYyAqZW1jID0gdG9fdGVncmEyMTBfY2xrX2VtYyhodyk7Cj4g KwlzdHJ1Y3QgdGVncmEyMTBfY2xrX2VtY19wcm92aWRlciAqcHJvdmlkZXIgPSBlbWMtPnByb3Zp ZGVyOwo+ICsJdW5zaWduZWQgaW50IGk7Cj4gKwo+ICsJaWYgKCFwcm92aWRlciB8fCAhcHJvdmlk ZXItPmNvbmZpZ3MgfHwgcHJvdmlkZXItPm51bV9jb25maWdzID09IDApCj4gKwkJcmV0dXJuIGNs a19od19nZXRfcmF0ZShodyk7CgpUaGlzIHN0aWxsIGxvb2tzIHdyb25nIHRvIG1lLiBOb2JvZHkg c2hvdWxkIGJlIGFibGUgdG8gZ2V0IEVNQyBjbG9jawp1bnRpbCBwcm92aWRlciBpcyByZWdpc3Rl cmVkLgoKVGhpcyBpcyB0cm91Ymxlc29tZSwgZXNwZWNpYWxseSBnaXZlbiB0aGF0IHlvdSdyZSBh bGxvd2luZyB0aGUgRU1DCmRyaXZlciB0byBiZSBjb21waWxlZCBhcyBhIGxvYWRhYmxlIG1vZHVs ZS4gRm9yIGV4YW1wbGUsIHRoaXMgd29uJ3Qgd29yawp3aXRoIHRoZSBjdXJyZW50IEFDVE1PTiBk cml2ZXIgYmVjYXVzZSBpdCBidWlsZHMgT1BQIHRhYmxlIGJhc2VkIG9uIHRoZQpjbGstcmF0ZSBy b3VuZGluZyBkdXJpbmcgdGhlIGRyaXZlcidzIHByb2JlLCBzbyBpdCB3b24ndCBiZSBhYmxlIHRv IGRvCml0IHByb3Blcmx5IGlmIHByb3ZpZGVyIGlzICJ0ZW1wb3JhcmlseSIgbWlzc2luZy4KCi4u LiBJIHRoaW5rIHRoYXQgaW4gYSBsb25nZXIgcnVuIHdlIHNob3VsZCBzdG9wIG1hbnVhbGx5IGJ1 aWxkaW5nIHRoZQpBQ1RNT04ncyBPUFAgdGFibGUgYW5kIGluc3RlYWQgZGVmaW5lIGEgcHJvcGVy IE9QUCB0YWJsZSAocGVyLUhXIFNwZWVkbwpJRCwgd2l0aCB2b2x0YWdlcykgaW4gYSBkZXZpY2Ut dHJlZS4gQnV0IHRoaXMgaXMganVzdCBhIHZhZ3VlIHBsYW5zIGZvcgp0aGUgZnV0dXJlIGZvciBu b3cuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51 eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1h cm0ta2VybmVsCg==