From: Philip Yang <yangp@amd.com>
To: "Xiaogang.Chen" <xiaogang.chen@amd.com>, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/amdkfd: Fix a race issue at svm_migrate_copy_to_ram() error path
Date: Wed, 18 Nov 2026 12:43:59 -0500 [thread overview]
Message-ID: <8dc2af18-5261-4949-9d85-cc869c13fc48@amd.com> (raw)
In-Reply-To: <20261118151045.134908-1-xiaogang.chen@amd.com>
[-- Attachment #1: Type: text/plain, Size: 2530 bytes --]
On 2026-11-18 10:10, Xiaogang.Chen wrote:
> From: Xiaogang Chen<xiaogang.chen@amd.com>
>
> The destination pages were freed while SDMA copies queued earlier
> could still be writing into them, and while they were still DMA
> mapped. The mappings were only removed later by the caller's
> svm_range_dma_unmap_dev().
>
> With swiotlb, the BIDIRECTIONAL unmap copies the bounce buffer back into
> a page that may already be reused.
>
> With an IOMM, the GPU still has a valid bus address that points at a page
> now maybe owned by another user. Any SDMA write still in flight, corrupts
> that page.
>
> So, wait on the fence first, then dma unmap before release buffer.
>
> svm_range_dma_unmap_dev() sets each entry to 0 after unmapping it,
> so the caller's later svm_range_dma_unmap_dev call skips them.
>
> Not drop the fence there. *mfence still belongs to the caller. Later
> svm_migrate_copy_done() puts it and second wait there returns immediately.
>
> Signed-off-by: Xiaogang Chen<xiaogang.chen@amd.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c b/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
> index 8b96e1fe741a..78a2aab81c17 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
> @@ -716,6 +716,18 @@ svm_migrate_copy_to_ram(struct amdgpu_device *adev, struct svm_range *prange,
> put_page(dpage);
> }
>
> + /*
> + * Copies queued before the failure may still be writing into
> + * the destination pages. Wait for the last SDMA fence (copies
> + * on the entity complete in order), then remove the device DMA
> + * mappings, before the pages go back to the allocator. The
> + * caller's svm_migrate_copy_done() still puts the fence, and
> + * its svm_range_dma_unmap_dev() skips the entries zeroed here.
> + */
> + if (*mfence)
> + dma_fence_wait(*mfence, false);
wait fence is good, but I perfer to add dma_fence_put() here to free the
fence, then in caller, only wait for fence if copy return 0.
if (!r)
svm_migrate_copy_done(adev, mfence);
> + svm_range_dma_unmap_dev(dev, dst, 0, npages);
> +
This is not needed, as the below loop unmap dma address and free sys pages.
And add this in caller
if (!r)
svm_range_dma_unmap_dev(adev->dev, scratch, 0, npages);
Regards,
Philip
> /* release previous allocated sys pages and unmap dma address */
> while (i--) {
>
[-- Attachment #2: Type: text/html, Size: 3522 bytes --]
prev parent reply other threads:[~2026-11-18 17:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 15:10 [PATCH 1/2] drm/amdkfd: Fix a race issue at svm_migrate_copy_to_ram() error path Xiaogang.Chen
2026-11-18 15:10 ` [PATCH 2/2] drm/amdkfd: Swap order of svm_range_dma_unmap_dev and migrate_vma_finalize Xiaogang.Chen
2026-11-18 15:25 ` sashiko-bot
2026-11-18 17:48 ` Philip Yang
2026-11-18 18:02 ` Chen, Xiaogang
2026-11-18 15:22 ` [PATCH 1/2] drm/amdkfd: Fix a race issue at svm_migrate_copy_to_ram() error path sashiko-bot
2026-11-18 17:43 ` Philip Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8dc2af18-5261-4949-9d85-cc869c13fc48@amd.com \
--to=yangp@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=xiaogang.chen@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.