From: Eric Sandeen <sandeen@redhat.com>
To: linux-fsdevel@vger.kernel.org, Christian Brauner <brauner@kernel.org>
Cc: autofs@vger.kernel.org, "Rafael J. Wysocki" <rafael@kernel.org>,
linux-efi@vger.kernel.org, Namjae Jeon <linkinjeon@kernel.org>,
linux-ext4@vger.kernel.org, Miklos Szeredi <miklos@szeredi.hu>,
linux-mm@kvack.org, Jan Kara <jack@suse.cz>,
ntfs3@lists.linux.dev, linux-mm@kvack.org,
linux-cifs@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
Hans Caniullan <hcaniull@redhat.com>
Subject: [PATCH 0/14] New uid & gid mount option parsing helpers
Date: Thu, 27 Jun 2024 19:24:59 -0500 [thread overview]
Message-ID: <8dca3c11-99f4-446d-a291-35c50ed2dc14@redhat.com> (raw)
Multiple filesystems take uid and gid as options, and the code to
create the ID from an integer and validate it is standard boilerplate
that can be moved into common helper functions, so do that for
consistency and less cut&paste.
This also helps avoid the buggy pattern noted by Seth Jenkins at
https://lore.kernel.org/lkml/CALxfFW4BXhEwxR0Q5LSkg-8Vb4r2MONKCcUCVioehXQKr35eHg@mail.gmail.com/
because uid/gid parsing will fail before any assignment in most
filesystems.
Net effect is a bit of code removal, as well.
Patch 1 is the infrastructure change, then per-fs conversions follow,
cc'd as appropriate.
This series is also at
https://git.kernel.org/pub/scm/linux/kernel/git/sandeen/linux.git/log/?h=mount-api-uid-helper
Thanks,
-Eric
Documentation/filesystems/mount_api.rst | 9 +++++++--
fs/autofs/inode.c | 16 ++++------------
fs/debugfs/inode.c | 16 ++++------------
fs/efivarfs/super.c | 12 ++++--------
fs/exfat/super.c | 8 ++++----
fs/ext4/super.c | 22 ++++------------------
fs/fs_parser.c | 34 ++++++++++++++++++++++++++++++++++
fs/fuse/inode.c | 12 ++++--------
fs/hugetlbfs/inode.c | 12 ++++--------
fs/isofs/inode.c | 16 ++++------------
fs/ntfs3/super.c | 12 ++++--------
fs/smb/client/fs_context.c | 39 ++++++++++++---------------------------
fs/tracefs/inode.c | 16 ++++------------
include/linux/fs_parser.h | 6 +++++-
mm/shmem.c | 12 ++++--------
15 files changed, 102 insertions(+), 140 deletions(-)
next reply other threads:[~2024-06-28 0:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-28 0:24 Eric Sandeen [this message]
2024-06-28 0:26 ` [PATCH 01/14] fs_parse: add uid & gid option option parsing helpers Eric Sandeen
2024-06-28 9:45 ` Jan Kara
2024-06-28 12:23 ` Christian Brauner
2024-07-01 9:34 ` Jan Kara
2024-06-28 13:44 ` Eric Sandeen
2024-06-28 0:27 ` [PATCH 02/14] autofs: Convert to new uid/gid " Eric Sandeen
2024-07-01 3:05 ` Ian Kent
2024-06-28 0:29 ` [PATCH 03/14] debugfs: " Eric Sandeen
2024-06-28 0:30 ` [PATCH 04/14] efivarfs: " Eric Sandeen
2024-06-28 0:31 ` [PATCH 05/14] exfat: " Eric Sandeen
2024-06-28 0:32 ` [PATCH 06/14] ext4: " Eric Sandeen
2024-06-28 0:33 ` [PATCH 07/14] fuse: " Eric Sandeen
2024-06-28 12:07 ` Christian Brauner
2024-06-28 13:41 ` Eric Sandeen
2024-06-28 0:35 ` [PATCH 08/14] hugetlbfs: " Eric Sandeen
2024-06-28 0:36 ` [PATCH 09/14] isofs: " Eric Sandeen
2024-06-28 0:37 ` [PATCH 10/14] ntfs3: " Eric Sandeen
2024-06-28 0:38 ` [PATCH 11/14] tmpfs: " Eric Sandeen
2024-06-28 0:39 ` [PATCH 12/14] smb: client: " Eric Sandeen
2024-06-28 0:40 ` [PATCH 13/14] tracefs: " Eric Sandeen
2024-06-28 12:35 ` Steven Rostedt
2024-06-28 0:42 ` [PATCH 14/14] vboxsf: " Eric Sandeen
2024-06-28 6:43 ` Hans de Goede
2024-06-28 11:51 ` [PATCH 0/14] New uid & gid mount " Christian Brauner
2024-07-02 4:25 ` (subset) " Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8dca3c11-99f4-446d-a291-35c50ed2dc14@redhat.com \
--to=sandeen@redhat.com \
--cc=autofs@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=hcaniull@redhat.com \
--cc=jack@suse.cz \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=ntfs3@lists.linux.dev \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.