From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:906:cf90:b0:9bd:85f7:2662 with SMTP id um16csp1265110ejb; Fri, 20 Oct 2023 07:23:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHwHWUJGhLrBXWLXlqR1wXwDwOZhB81Ucx+cwhYPeEV91mKAXCg28doc59IjMv598WLrjTs X-Received: by 2002:a05:620a:4606:b0:778:922e:fa7f with SMTP id br6-20020a05620a460600b00778922efa7fmr7366020qkb.28.1697811835735; Fri, 20 Oct 2023 07:23:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697811835; cv=none; d=google.com; s=arc-20160816; b=VoljqSoRxfh9fcjYECgOGHBsr9pTvPmRsbhZcHCOrOlKub1wJy6ioAhJY1c7wYgr5a lqRqVb503zOmCC2Hmcncml7x1i/kAwaIzrHOgKjw6VVf5I5kebjQq0C8pNJdlMReO14d NSqSMV5zPqPVZY4ztqylWLYanvanaF62Co2Su2D6vC9IjSzvR0dU7kDKoHDn/IT5OyDZ xtaUenQz26833kWg/QOPQxy8A339NduBhUOj8K9rjh9OWawHJpDPyRwQg9vD4Cicz3P3 wZ62gzhfjoQFCWh7v4sulM65ONGkT2lDCzFb33Aw4rTvQKT5hbh/bCoMcMzadjX3dFF5 LnOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :in-reply-to:autocrypt:from:references:cc:to:content-language :subject:user-agent:mime-version:date:message-id:dkim-signature; bh=piBLIjiK0PytzILGrC0The2dL5tib3qgXWjZn8o+loc=; fh=aaqPnSD6tstDYOi4iE3lVjgOjq/ySCPz+jgy9Piw17A=; b=ua+M8Ajca76SdNYK2wFUeHVEIOm05Vb1UPj5yS3Aoqu6Ko/kQD8kwD0CldegTOQAEm POg7vz+l3X+U9SGPckulnAa+Ar8bHsaby5f/7YFumbqXjfGxndTC6bUSEQIL8BwE2dea xiCseKHMzrjHq99H+7R3HRXqg1KAvwrH5MlQgBAjXW9QRQbvNQVA+QNwsmG783Y+KMzp w79Vis9Vq8n9uJQZO0fjCuyqdYq8ml5N7wKbpZtU8ofhwXoVkh9ilwFgTAzusTUFDFSf qWnzrcc/pn6tK+dv13+70zkB6Oal0GO6gLRt7Ev9/kws1QDAARe9KJy3GwvEQc1WyoXr bRiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=V4gTqzga; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 12-20020a05620a040c00b007726400ee6dsi1370978qkp.491.2023.10.20.07.23.55 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 20 Oct 2023 07:23:55 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=V4gTqzga; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qtqPD-0006ii-3A; Fri, 20 Oct 2023 10:23:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtqP7-0006hE-C4 for qemu-devel@nongnu.org; Fri, 20 Oct 2023 10:23:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtqP5-0004ng-93 for qemu-devel@nongnu.org; Fri, 20 Oct 2023 10:23:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697811785; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=piBLIjiK0PytzILGrC0The2dL5tib3qgXWjZn8o+loc=; b=V4gTqzgaAHSIEu8Y3uK2pnXdOBbOifwyemKlqnuSkwxLQCLc/SASraCcsXBMm5qVugyaT0 20gVzt62LsZ/6dOnnFDNuwuizxtysGwVba3g9baan/Ipsu5lANyrdVr543Q4WFEMn7/xjI ykoM/aeaSaDgAtXiVFbkjs4cYByurW0= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-368-iQbFBcENM_ycTLr-Wfuoag-1; Fri, 20 Oct 2023 10:22:58 -0400 X-MC-Unique: iQbFBcENM_ycTLr-Wfuoag-1 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-775869cf2f5so302785785a.1 for ; Fri, 20 Oct 2023 07:22:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697811778; x=1698416578; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=piBLIjiK0PytzILGrC0The2dL5tib3qgXWjZn8o+loc=; b=mhjsOxYbM3aFPgepU9EyWRBu+LNxXr8WtPdmeyhl3HZmwhkwZbfUioCA6kcNmDz5bz W8vCzixKLqN9iRwHcvIpIp4mj4DPSY/unZ/lmyA6W2NPrMbf5udS0XReoZBPPX+Dowvd ZNkejnfjBcRjEd03gFk5NzsuoZ8R7hcGbx425w80APfiayRASqQhSOJ1mXhyMyan1PJt KkQudY/2X9woUqV90SBl2GQmRdEnuE5ww77jgAWH9Dp8KHpUnCeLO3rtob1kAsJrt9KN xsXPC60a/KzchhfWR6wQG0XnnDudb8KKN78PXdt290KQ+Z5vY4wM8RR5Bi+/RqBSyeSH SMEg== X-Gm-Message-State: AOJu0Yw/ksSdDjnijYDnJxWGC97cdAa18shbFf/w0i2GCnCtVw/m2+nH 3MBkJS1nJ0o0dZEiZ1d/t/wf5+xJr6qpSZkGGV9kcNo8BPNkZR39i9paLlT/DMbBIBfp/jtCL96 nE6WukkHog8ea3KM= X-Received: by 2002:a05:620a:40c7:b0:775:cda7:88c with SMTP id g7-20020a05620a40c700b00775cda7088cmr6758589qko.38.1697811778281; Fri, 20 Oct 2023 07:22:58 -0700 (PDT) X-Received: by 2002:a05:620a:40c7:b0:775:cda7:88c with SMTP id g7-20020a05620a40c700b00775cda7088cmr6758572qko.38.1697811777999; Fri, 20 Oct 2023 07:22:57 -0700 (PDT) Received: from [192.168.0.5] (ip-109-43-176-141.web.vodafone.de. [109.43.176.141]) by smtp.gmail.com with ESMTPSA id pz6-20020ad45506000000b0065b24c08994sm710039qvb.128.2023.10.20.07.22.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Oct 2023 07:22:57 -0700 (PDT) Message-ID: <8ddbb054-efd3-4ac2-92f3-7c59df0e8617@redhat.com> Date: Fri, 20 Oct 2023 16:22:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 13/13] migration: Use vmstate_register_any() for vmware_vga Content-Language: en-US To: Juan Quintela , qemu-devel@nongnu.org Cc: Peter Maydell , Harsh Prateek Bora , David Hildenbrand , Samuel Thibault , Eric Farman , qemu-arm@nongnu.org, qemu-ppc@nongnu.org, Gerd Hoffmann , Fabiano Rosas , David Gibson , Corey Minyard , "Michael S. Tsirkin" , Peter Xu , Corey Minyard , Stefan Berger , Marcel Apfelbaum , =?UTF-8?Q?Marc-Andr=C3=A9_Lureau?= , Richard Henderson , Halil Pasic , Leonardo Bras , John Snow , Nicholas Piggin , Mark Cave-Ayland , Christian Borntraeger , Ilya Leoshkevich , Jason Wang , qemu-block@nongnu.org, qemu-s390x@nongnu.org, =?UTF-8?Q?C=C3=A9dric_Le_Goat?= =?UTF-8?Q?er?= , Daniel Henrique Barboza , Stefan Weil , Stefan Berger References: <20231020090731.28701-1-quintela@redhat.com> <20231020090731.28701-14-quintela@redhat.com> From: Thomas Huth Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20231020090731.28701-14-quintela@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: tuZqB5pbQKtj On 20/10/2023 11.07, Juan Quintela wrote: > I have no idea if we can have more than one vmware_vga device, so play > it safe. FWIW, it doesn't look like it's possible: $ ./qemu-system-x86_64 -device vmware-svga -device vmware-svga RAMBlock "vmsvga.fifo" already registered, abort! Aborted (core dumped) (NB: Aborting is very user-unfriendly here, but that's something for another patch...) > Reviewed-by: Stefan Berger > Signed-off-by: Juan Quintela > --- > hw/display/vmware_vga.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c > index 09591fbd39..7490d43881 100644 > --- a/hw/display/vmware_vga.c > +++ b/hw/display/vmware_vga.c > @@ -1264,7 +1264,7 @@ static void vmsvga_init(DeviceState *dev, struct vmsvga_state_s *s, > > vga_common_init(&s->vga, OBJECT(dev), &error_fatal); > vga_init(&s->vga, OBJECT(dev), address_space, io, true); > - vmstate_register(NULL, 0, &vmstate_vga_common, &s->vga); > + vmstate_register_any(NULL, &vmstate_vga_common, &s->vga); > s->new_depth = 32; > } Reviewed-by: Thomas Huth