From: Markus Elfring <Markus.Elfring@web.de>
To: Miaoqian Lin <linmq006@gmail.com>, dmaengine@vger.kernel.org
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Vinod Koul" <vkoul@kernel.org>,
"Viresh Kumar" <vireshk@kernel.org>
Subject: Re: [PATCH] dmaengine: dw: dmamux: Fix device reference leak in rzn1_dmamux_route_allocate
Date: Tue, 2 Sep 2025 11:24:29 +0200 [thread overview]
Message-ID: <8df346cf-bdc6-4701-b4e5-87bc55d30234@web.de> (raw)
In-Reply-To: <20250902090358.2423285-1-linmq006@gmail.com>
> The reference taken by of_find_device_by_node()
> must be released when not needed anymore.
> Add missing put_device() call to fix device reference leaks.
1. You may occasionally put more than 60 characters into text lines
of such a change description.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17-rc4#n638
2. Would you like to increase the application of scope-based resource management?
https://elixir.bootlin.com/linux/v6.17-rc4/source/include/linux/device.h#L1180
3. How do you think about to append parentheses to the function name
in the summary phrase?
Regards,
Markus
next prev parent reply other threads:[~2025-09-02 9:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-02 9:03 [PATCH] dmaengine: dw: dmamux: Fix device reference leak in rzn1_dmamux_route_allocate Miaoqian Lin
2025-09-02 9:18 ` Miquel Raynal
2025-09-02 9:24 ` Markus Elfring [this message]
2025-09-02 9:35 ` Vinod Koul
2025-09-02 9:37 ` Andy Shevchenko
2025-09-02 10:18 ` 林妙倩
2025-09-02 11:02 ` Andy Shevchenko
2025-09-02 13:12 ` 林妙倩
2025-09-02 13:30 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8df346cf-bdc6-4701-b4e5-87bc55d30234@web.de \
--to=markus.elfring@web.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linmq006@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=stable@vger.kernel.org \
--cc=vireshk@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.