From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [RFC PATCH 10/23] ALSA: usb/line6: remove 'defined but not used' warning
Date: Tue, 7 Jul 2020 10:49:52 -0500 [thread overview]
Message-ID: <8dfae7e1-9106-cd00-3fa2-401e941095e2@linux.intel.com> (raw)
In-Reply-To: <s5hblkreiy5.wl-tiwai@suse.de>
>> -static const int SYSEX_DATA_OFS = sizeof(line6_midi_id) + 3;
>> -static const int SYSEX_EXTRA_SIZE = sizeof(line6_midi_id) + 4;
>> +static __maybe_unused const int SYSEX_DATA_OFS = sizeof(line6_midi_id) + 3;
>> +static __maybe_unused const int SYSEX_EXTRA_SIZE = sizeof(line6_midi_id) + 4;
>
> IMO, this can be clearer to make them define.
> The static const doesn't look like a right usage in such a case in
> anyway...
Right, and the capital letters do hint at a define indeed. Will resend,
thanks Takashi for the review.
next prev parent reply other threads:[~2020-07-07 16:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 19:35 [RFC PATCH 00/23] ALSA: fix kernel-doc and W=1 warnings Pierre-Louis Bossart
2020-07-02 19:35 ` [RFC PATCH 01/23] ALSA: isa/gus: remove -Wmissing-prototypes warnings Pierre-Louis Bossart
2020-07-02 19:35 ` [RFC PATCH 02/23] ALSA: isa/gus: remove 'set but not used' warning Pierre-Louis Bossart
2020-07-02 19:35 ` [RFC PATCH 03/23] ALSA: pci/asihpi: remove 'set but not used' warnings Pierre-Louis Bossart
2020-07-02 19:35 ` [RFC PATCH 04/23] ALSA: pci/asihpi: fix kernel-doc Pierre-Louis Bossart
2020-07-02 19:35 ` [RFC PATCH 05/23] ALSA: pci/asihpi: remove 'set but not used' warning Pierre-Louis Bossart
2020-07-02 19:35 ` [RFC PATCH 06/23] ALSA: pci/echoaudio: " Pierre-Louis Bossart
2020-07-02 19:35 ` [RFC PATCH 07/23] ALSA: pci/aw2-saa7146: " Pierre-Louis Bossart
2020-07-02 19:35 ` [RFC PATCH 08/23] ALSA: pci/ctxfi/ctatc: fix kernel-doc Pierre-Louis Bossart
2020-07-02 19:35 ` [RFC PATCH 09/23] ALSA: pci/ctxfi: fix kernel-doc warnings Pierre-Louis Bossart
2020-07-02 19:35 ` [RFC PATCH 10/23] ALSA: usb/line6: remove 'defined but not used' warning Pierre-Louis Bossart
2020-07-07 10:08 ` Takashi Iwai
2020-07-07 15:49 ` Pierre-Louis Bossart [this message]
2020-07-02 19:35 ` [RFC PATCH 11/23] ASoC: pci/emu10k1: remove "set but not used' warnings Pierre-Louis Bossart
2020-07-02 19:35 ` [RFC PATCH 12/23] ALSA: firewire: fix kernel-doc Pierre-Louis Bossart
2020-07-03 0:56 ` Takashi Sakamoto
2020-07-02 19:35 ` [RFC PATCH 13/23] ALSA: pci/emu10k1: remove 'set but not used' warning Pierre-Louis Bossart
2020-07-02 19:35 ` [RFC PATCH 14/23] ALSA: pci/korg1212: remove 'set but not used' warnings Pierre-Louis Bossart
2020-07-02 19:35 ` [RFC PATCH 15/23] ALSA: pci/rme9652/hdspm: remove always true condition Pierre-Louis Bossart
2020-07-02 19:35 ` [RFC PATCH 16/23] ALSA: pci/oxygen/xonar_wm87x6: " Pierre-Louis Bossart
2020-07-02 19:35 ` [RFC PATCH 17/23] ALSA: xen: remove 'set but not used' warning Pierre-Louis Bossart
2020-07-02 19:35 ` [RFC PATCH 18/23] ALSA: pci/es1938: " Pierre-Louis Bossart
2020-07-02 19:36 ` [RFC PATCH 19/23] ALSA: pci/fm801: fix kernel-doc Pierre-Louis Bossart
2020-07-02 19:36 ` [RFC PATCH 20/23] ALSA: pci/via82xx: remove 'set but not used' warnings Pierre-Louis Bossart
2020-07-02 19:36 ` [RFC PATCH 21/23] ALSA: pcmcia/pdaudiocf: fix kernel-doc Pierre-Louis Bossart
2020-07-02 19:36 ` [RFC PATCH 22/23] ALSA: vx_core: remove warning for empty loop body Pierre-Louis Bossart
2020-07-02 19:36 ` [RFC PATCH 23/23] ALSA: pci/au88x0: remove "defined but not used" warnings Pierre-Louis Bossart
2020-07-07 10:21 ` [RFC PATCH 00/23] ALSA: fix kernel-doc and W=1 warnings Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8dfae7e1-9106-cd00-3fa2-401e941095e2@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.