All of lore.kernel.org
 help / color / mirror / Atom feed
From: stummala@codeaurora.org
To: Chao Yu <yuchao0@huawei.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] f2fs: cp_mutex starvation issue
Date: Wed, 18 Nov 2020 16:59:18 +0530	[thread overview]
Message-ID: <8e094021b958f9fe01df1183a2677882@codeaurora.org> (raw)
In-Reply-To: <46222a22-f42c-ef04-3707-8e0bc3fe76da@huawei.com>

Hi Chao,

On 2020-11-18 15:37, Chao Yu wrote:
> Hi Sahitya,
> 
> On 2020/11/18 17:47, stummala@codeaurora.org wrote:
>> Hi Chao,
>> 
>> Can we consider to move the sbi->cp_mutex as well to use rw_sem 
>> similar
>> to this patch of yours -
>> https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/fs/f2fs?id=fb24fea75ca5ceef59f753494b2efd453606e08a
>> 
>> We are observing issues where fsync() of a high priority task getting
>> starved when there is heavy IO from several low priority tasks.
>> I would like to know if this was considered before and if any issues 
>> in
>> doing so? Please share your inputs.
> 
> I missed to check cp_mutex lock, because I haven't been reported with
> starving issue on this lock, anyway, I agree to do the same change on
> cp_mutex lock, and I don't think there is any problem after change.
> 
> Could you please make one patch to fix this?

Thanks for the comments.
Sure, I will put up a patch for this.

Thanks,

> Thanks,
> 
>> 
>> Thanks,
>> Sahitya.
>> .
>> 


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

      reply	other threads:[~2020-11-18 11:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-18  9:47 [f2fs-dev] f2fs: cp_mutex starvation issue stummala
2020-11-18 10:07 ` Chao Yu
2020-11-18 11:29   ` stummala [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e094021b958f9fe01df1183a2677882@codeaurora.org \
    --to=stummala@codeaurora.org \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=yuchao0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.