Re: [PATCH net-next v2 1/2] net/ipv6: Remove expired routes with a separated list of routes.

[Kui-Feng Lee <sinquersw@gmail.com>]

On 7/20/23 02:18, Paolo Abeni wrote:
> On Tue, 2023-07-18 at 11:03 -0700, Kui-Feng Lee wrote:
>> FIB6 GC walks trees of fib6_tables to remove expired routes. Walking a tree
>> can be expensive if the number of routes in a table is big, even if most of
>> them are permanent. Checking routes in a separated list of routes having
>> expiration will avoid this potential issue.
>>
>> Signed-off-by: Kui-Feng Lee <kuifeng@meta.com>
> 
> There is a mismatch between the sender (Kui-Feng Lee
> <thinker.li@gmail.com>) and the SoB tag, please either change the sob
> or add a From: header tag to fix such mismatch.
> 
>> @@ -2312,6 +2323,40 @@ static int fib6_age(struct fib6_info *rt, void *arg)
>>   	return 0;
>>   }
>>   
>> +static void fib6_gc_table(struct net *net,
>> +			  struct fib6_table *tb6,
>> +			  void *arg)
> 
> Here 'arg' is actually 'struct fib6_gc_args *', you can/should update
> the type (and name) accordingly ...

Sure!

> 
>> +{
>> +	struct fib6_info *rt;
>> +	struct hlist_node *n;
>> +	struct nl_info info = {
>> +		.nl_net = net,
>> +		.skip_notify = false,
>> +	};
>> +
>> +	hlist_for_each_entry_safe(rt, n, &tb6->tb6_gc_hlist, gc_link)
>> +		if (fib6_age(rt, arg) == -1)
>> +			fib6_del(rt, &info);
>> +}
>> +
>> +static void fib6_gc_all(struct net *net, void *arg)
> 
> ... same here.
> 
> 
> Cheers,
> 
> Paolo
> 
>