From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25DFFC433F5 for ; Wed, 20 Oct 2021 06:35:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F0B26611C6 for ; Wed, 20 Oct 2021 06:35:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229691AbhJTGiI (ORCPT ); Wed, 20 Oct 2021 02:38:08 -0400 Received: from mga17.intel.com ([192.55.52.151]:28121 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229591AbhJTGiI (ORCPT ); Wed, 20 Oct 2021 02:38:08 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10142"; a="209500249" X-IronPort-AV: E=Sophos;i="5.87,166,1631602800"; d="scan'208";a="209500249" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2021 23:35:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,166,1631602800"; d="scan'208";a="483596514" Received: from dengjie-mobl1.ccr.corp.intel.com (HELO [10.239.154.68]) ([10.239.154.68]) by orsmga007.jf.intel.com with ESMTP; 19 Oct 2021 23:35:50 -0700 Subject: Re: [PATCH 1/2] i2c: virtio: disable timeout handling To: Greg KH Cc: Wolfram Sang , Viresh Kumar , Vincent Whitchurch , virtualization@lists.linux-foundation.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@axis.com References: <20211019074647.19061-1-vincent.whitchurch@axis.com> <20211019074647.19061-2-vincent.whitchurch@axis.com> <20211019080913.oajrvr2msz5enzvz@vireshk-i7> <20211019094203.3kjzch7ipbdv7peg@vireshk-i7> <20211019143748.wrpqopj2hmpvblh4@vireshk-i7> <94aa39ab-4ed6-daee-0402-f58bfed0cadd@intel.com> From: Jie Deng Message-ID: <8e182ea8-5016-fa78-3d77-eefba7d58612@intel.com> Date: Wed, 20 Oct 2021 14:35:49 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On 2021/10/20 13:36, Greg KH wrote: > On Wed, Oct 20, 2021 at 12:20:13PM +0800, Jie Deng wrote: >> On 2021/10/20 2:14, Wolfram Sang wrote: >>>> I think it is set to HZ currently, though I haven't tried big >>>> transfers but I still get into some issues with Qemu based stuff. >>>> Maybe we can bump it up to few seconds :) >>> If you use adapter->timeout, this can even be set at runtime using a >>> ioctl. So, it can adapt to use cases. Of course, the driver should >>> initialize it to a sane default if the automatic default (HZ) is not >>> suitable. >> >> I think a big value may solve most cases. but the driver never know how big >> is enough by static configuration. >> >> Can we make this value to be configurable, just let the other side provide >> this value ? > If an ioctl can change it, that would mean it is configurable, right? Yes, but we need to know what's the best value to be configured for a specific "other side". I think the "other side" should be more aware of what value is reasonable to be used. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C0ACC433EF for ; Wed, 20 Oct 2021 06:35:59 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 168F761260 for ; Wed, 20 Oct 2021 06:35:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 168F761260 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id C298260766; Wed, 20 Oct 2021 06:35:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id V7IdIbGb0DSE; Wed, 20 Oct 2021 06:35:58 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTPS id 785F0606FD; Wed, 20 Oct 2021 06:35:57 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 428DEC0011; Wed, 20 Oct 2021 06:35:57 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3C8C1C000D for ; Wed, 20 Oct 2021 06:35:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 1EBCC834BB for ; Wed, 20 Oct 2021 06:35:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DZ0JpXquFDFs for ; Wed, 20 Oct 2021 06:35:54 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by smtp1.osuosl.org (Postfix) with ESMTPS id 32613814A1 for ; Wed, 20 Oct 2021 06:35:54 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10142"; a="208807015" X-IronPort-AV: E=Sophos;i="5.87,166,1631602800"; d="scan'208";a="208807015" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2021 23:35:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,166,1631602800"; d="scan'208";a="483596514" Received: from dengjie-mobl1.ccr.corp.intel.com (HELO [10.239.154.68]) ([10.239.154.68]) by orsmga007.jf.intel.com with ESMTP; 19 Oct 2021 23:35:50 -0700 Subject: Re: [PATCH 1/2] i2c: virtio: disable timeout handling To: Greg KH References: <20211019074647.19061-1-vincent.whitchurch@axis.com> <20211019074647.19061-2-vincent.whitchurch@axis.com> <20211019080913.oajrvr2msz5enzvz@vireshk-i7> <20211019094203.3kjzch7ipbdv7peg@vireshk-i7> <20211019143748.wrpqopj2hmpvblh4@vireshk-i7> <94aa39ab-4ed6-daee-0402-f58bfed0cadd@intel.com> From: Jie Deng Message-ID: <8e182ea8-5016-fa78-3d77-eefba7d58612@intel.com> Date: Wed, 20 Oct 2021 14:35:49 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Cc: Viresh Kumar , Vincent Whitchurch , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Wolfram Sang , kernel@axis.com, linux-i2c@vger.kernel.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On 2021/10/20 13:36, Greg KH wrote: > On Wed, Oct 20, 2021 at 12:20:13PM +0800, Jie Deng wrote: >> On 2021/10/20 2:14, Wolfram Sang wrote: >>>> I think it is set to HZ currently, though I haven't tried big >>>> transfers but I still get into some issues with Qemu based stuff. >>>> Maybe we can bump it up to few seconds :) >>> If you use adapter->timeout, this can even be set at runtime using a >>> ioctl. So, it can adapt to use cases. Of course, the driver should >>> initialize it to a sane default if the automatic default (HZ) is not >>> suitable. >> >> I think a big value may solve most cases. but the driver never know how big >> is enough by static configuration. >> >> Can we make this value to be configurable, just let the other side provide >> this value ? > If an ioctl can change it, that would mean it is configurable, right? Yes, but we need to know what's the best value to be configured for a specific "other side". I think the "other side" should be more aware of what value is reasonable to be used. _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization