From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA10FEB64DA for ; Tue, 18 Jul 2023 08:55:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230260AbjGRIz2 (ORCPT ); Tue, 18 Jul 2023 04:55:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232049AbjGRIzY (ORCPT ); Tue, 18 Jul 2023 04:55:24 -0400 Received: from out30-112.freemail.mail.aliyun.com (out30-112.freemail.mail.aliyun.com [115.124.30.112]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 524E81982; Tue, 18 Jul 2023 01:55:00 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=guanghuifeng@linux.alibaba.com;NM=1;PH=DS;RN=12;SR=0;TI=SMTPD_---0Vnh4bmV_1689670476; Received: from 30.221.158.235(mailfrom:guanghuifeng@linux.alibaba.com fp:SMTPD_---0Vnh4bmV_1689670476) by smtp.aliyun-inc.com; Tue, 18 Jul 2023 16:54:50 +0800 Message-ID: <8e2cfde3-15fa-4e5a-02bf-0763abf10821@linux.alibaba.com> Date: Tue, 18 Jul 2023 16:54:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3] ACPI/IORT: Remove erroneous id_count check in iort_node_get_rmr_info() To: Lorenzo Pieralisi Cc: guohanjun@huawei.com, sudeep.holla@arm.com, rafael@kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, baolin.wang@linux.alibaba.com, alikernel-developer@linux.alibaba.com, will@kernel.org, catalin.marinas@arm.com, shameerali.kolothum.thodi@huawei.com References: <1689593625-45213-1-git-send-email-guanghuifeng@linux.alibaba.com> From: "guanghui.fgh" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org 在 2023/7/18 15:52, Lorenzo Pieralisi 写道: > [+Catalin, Will, Shameer] > > On Mon, Jul 17, 2023 at 07:33:45PM +0800, Guanghui Feng wrote: >> According to the ARM IORT specifications DEN 0049 issue E, >> the "Number of IDs" field in the ID mapping format reports >> the number of IDs in the mapping range minus one. >> >> In iort_node_get_rmr_info(), we erroneously skip ID mappings >> whose "Number of IDs" equal to 0, resulting in valid mapping >> nodes with a single ID to map being skipped, which is wrong. >> >> Fix iort_node_get_rmr_info() by removing the bogus id_count >> check. >> >> Fixes: 491cf4a6735a ("ACPI/IORT: Add support to retrieve IORT RMR reserved regions") >> Signed-off-by: Guanghui Feng >> --- >> drivers/acpi/arm64/iort.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c >> index 3631230..56d8873 100644 >> --- a/drivers/acpi/arm64/iort.c >> +++ b/drivers/acpi/arm64/iort.c >> @@ -1007,9 +1007,6 @@ static void iort_node_get_rmr_info(struct acpi_iort_node *node, >> for (i = 0; i < node->mapping_count; i++, map++) { >> struct acpi_iort_node *parent; >> >> - if (!map->id_count) >> - continue; >> - >> parent = ACPI_ADD_PTR(struct acpi_iort_node, iort_table, >> map->output_reference); >> if (parent != iommu) > > Shameer, I know this may look like overkill since the hunk we are > removing is buggy but can you please test this patch on platforms > with RMR to make sure we are not triggering regressions by removing > it (by the specs that's what should be done but current firmware > is always something to reckon with) ? > > Thanks, > Lorenzo Thanks for your response. Firstly, I have tested iort rmr with one ID mapping and works well. Secondly, When there is more than two id mappings, the buggly id_count check has no effect(for the id_count is larger than zero). From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B56CC001B0 for ; Wed, 19 Jul 2023 06:48:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4WNK0/lnwUcYe5nPDriGQ+K9M3MNBTFo6kMQTvRRR+o=; b=eUWnWZM/jX/7Ar H3n31Eckpo/AmOxpTwpAyCumXWld/PGErCxrSwL+TPhvrVLyU9YUXyT3LFnTtHyah0tKa3w3Bv+O+ kwiNJ8DHNA1DiFstN7puUBv+gqj/nIZ1SRZwAKG4oFOKOGcjgaNpYTJeBxLt0CLBHLYXtcXaX5/LQ KLNH4i7/AHuBvdJFsnhwY9nyXIt/7cS7sEAaI9DeoYb/e6x+gpi6cfnWrD868bKJ7PKu/P33Cwrhh i2Jt2wHa1CFN7d94GMY8EQcgLyqh3aHWkWLpS1klFiKOCL2KGSGD1Pv2FUKO31ag7fcRNrXeUvSww j4udCk2bOPXFEy+1pN2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qM0zG-005uMx-2X; Wed, 19 Jul 2023 06:48:38 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qM0zA-005uIr-2S for linux-arm-kernel@bombadil.infradead.org; Wed, 19 Jul 2023 06:48:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=EtSkvmzTHFScfg1YWyp+YWC72Q6D7i1SHdF0m5iPrp0=; b=Xaz+WFLo2MBfSdIH7ys7ir5FRW mrSCBPJyMnOgnnO8gNvI2VOvPBOaFXH9OBKvZteTeh0zuWmQZjJO1JICPRqjWotUwAUjdWVxKJ7DS 5GrWcnsa4BchyCF/DJoeVqNoLlbOBiEp3fIazKjLT+iiRnIeJ1+DR3VwuXagObLruuCm+qJUs8Lwf hUn/dQDgdbujY+gBKlqa30DGK4tZA3Cf5bAzRCfsIYMNgfzyyUOd9TsMsdSwJAP5qFR4t/uy+9Nlo pcGqQVLQcbn8svYI0bG8mxgN+a7l3pYvxY+O3LFXudxV3OSZlbVVCS3BOcHtE52YuFhMzt0nGZfMa 2BdatuKA==; Received: from out30-131.freemail.mail.aliyun.com ([115.124.30.131]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qLgUB-00BK8M-0P for linux-arm-kernel@lists.infradead.org; Tue, 18 Jul 2023 08:55:15 +0000 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=guanghuifeng@linux.alibaba.com;NM=1;PH=DS;RN=12;SR=0;TI=SMTPD_---0Vnh4bmV_1689670476; Received: from 30.221.158.235(mailfrom:guanghuifeng@linux.alibaba.com fp:SMTPD_---0Vnh4bmV_1689670476) by smtp.aliyun-inc.com; Tue, 18 Jul 2023 16:54:50 +0800 Message-ID: <8e2cfde3-15fa-4e5a-02bf-0763abf10821@linux.alibaba.com> Date: Tue, 18 Jul 2023 16:54:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3] ACPI/IORT: Remove erroneous id_count check in iort_node_get_rmr_info() To: Lorenzo Pieralisi Cc: guohanjun@huawei.com, sudeep.holla@arm.com, rafael@kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, baolin.wang@linux.alibaba.com, alikernel-developer@linux.alibaba.com, will@kernel.org, catalin.marinas@arm.com, shameerali.kolothum.thodi@huawei.com References: <1689593625-45213-1-git-send-email-guanghuifeng@linux.alibaba.com> From: "guanghui.fgh" In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230718_095511_859380_E42B0CFE X-CRM114-Status: GOOD ( 15.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgrlnKggMjAyMy83LzE4IDE1OjUyLCBMb3JlbnpvIFBpZXJhbGlzaSDlhpnpgZM6Cj4gWytDYXRh bGluLCBXaWxsLCBTaGFtZWVyXQo+IAo+IE9uIE1vbiwgSnVsIDE3LCAyMDIzIGF0IDA3OjMzOjQ1 UE0gKzA4MDAsIEd1YW5naHVpIEZlbmcgd3JvdGU6Cj4+IEFjY29yZGluZyB0byB0aGUgQVJNIElP UlQgc3BlY2lmaWNhdGlvbnMgREVOIDAwNDkgaXNzdWUgRSwKPj4gdGhlICJOdW1iZXIgb2YgSURz IiBmaWVsZCBpbiB0aGUgSUQgbWFwcGluZyBmb3JtYXQgcmVwb3J0cwo+PiB0aGUgbnVtYmVyIG9m IElEcyBpbiB0aGUgbWFwcGluZyByYW5nZSBtaW51cyBvbmUuCj4+Cj4+IEluIGlvcnRfbm9kZV9n ZXRfcm1yX2luZm8oKSwgd2UgZXJyb25lb3VzbHkgc2tpcCBJRCBtYXBwaW5ncwo+PiB3aG9zZSAi TnVtYmVyIG9mIElEcyIgZXF1YWwgdG8gMCwgcmVzdWx0aW5nIGluIHZhbGlkIG1hcHBpbmcKPj4g bm9kZXMgd2l0aCBhIHNpbmdsZSBJRCB0byBtYXAgYmVpbmcgc2tpcHBlZCwgd2hpY2ggaXMgd3Jv bmcuCj4+Cj4+IEZpeCBpb3J0X25vZGVfZ2V0X3Jtcl9pbmZvKCkgYnkgcmVtb3ZpbmcgdGhlIGJv Z3VzIGlkX2NvdW50Cj4+IGNoZWNrLgo+Pgo+PiBGaXhlczogNDkxY2Y0YTY3MzVhICgiQUNQSS9J T1JUOiBBZGQgc3VwcG9ydCB0byByZXRyaWV2ZSBJT1JUIFJNUiByZXNlcnZlZCByZWdpb25zIikK Pj4gU2lnbmVkLW9mZi1ieTogR3VhbmdodWkgRmVuZyA8Z3VhbmdodWlmZW5nQGxpbnV4LmFsaWJh YmEuY29tPgo+PiAtLS0KPj4gICBkcml2ZXJzL2FjcGkvYXJtNjQvaW9ydC5jIHwgMyAtLS0KPj4g ICAxIGZpbGUgY2hhbmdlZCwgMyBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvYWNwaS9hcm02NC9pb3J0LmMgYi9kcml2ZXJzL2FjcGkvYXJtNjQvaW9ydC5jCj4+IGluZGV4 IDM2MzEyMzAuLjU2ZDg4NzMgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvYWNwaS9hcm02NC9pb3J0 LmMKPj4gKysrIGIvZHJpdmVycy9hY3BpL2FybTY0L2lvcnQuYwo+PiBAQCAtMTAwNyw5ICsxMDA3 LDYgQEAgc3RhdGljIHZvaWQgaW9ydF9ub2RlX2dldF9ybXJfaW5mbyhzdHJ1Y3QgYWNwaV9pb3J0 X25vZGUgKm5vZGUsCj4+ICAgCWZvciAoaSA9IDA7IGkgPCBub2RlLT5tYXBwaW5nX2NvdW50OyBp KyssIG1hcCsrKSB7Cj4+ICAgCQlzdHJ1Y3QgYWNwaV9pb3J0X25vZGUgKnBhcmVudDsKPj4gICAK Pj4gLQkJaWYgKCFtYXAtPmlkX2NvdW50KQo+PiAtCQkJY29udGludWU7Cj4+IC0KPj4gICAJCXBh cmVudCA9IEFDUElfQUREX1BUUihzdHJ1Y3QgYWNwaV9pb3J0X25vZGUsIGlvcnRfdGFibGUsCj4+ ICAgCQkJCSAgICAgIG1hcC0+b3V0cHV0X3JlZmVyZW5jZSk7Cj4+ICAgCQlpZiAocGFyZW50ICE9 IGlvbW11KQo+IAo+IFNoYW1lZXIsIEkga25vdyB0aGlzIG1heSBsb29rIGxpa2Ugb3ZlcmtpbGwg c2luY2UgdGhlIGh1bmsgd2UgYXJlCj4gcmVtb3ZpbmcgaXMgYnVnZ3kgYnV0IGNhbiB5b3UgcGxl YXNlIHRlc3QgdGhpcyBwYXRjaCBvbiBwbGF0Zm9ybXMKPiB3aXRoIFJNUiB0byBtYWtlIHN1cmUg d2UgYXJlIG5vdCB0cmlnZ2VyaW5nIHJlZ3Jlc3Npb25zIGJ5IHJlbW92aW5nCj4gaXQgKGJ5IHRo ZSBzcGVjcyB0aGF0J3Mgd2hhdCBzaG91bGQgYmUgZG9uZSBidXQgY3VycmVudCBmaXJtd2FyZQo+ IGlzIGFsd2F5cyBzb21ldGhpbmcgdG8gcmVja29uIHdpdGgpID8KPiAKPiBUaGFua3MsCj4gTG9y ZW56bwpUaGFua3MgZm9yIHlvdXIgcmVzcG9uc2UuCgpGaXJzdGx5LCBJIGhhdmUgdGVzdGVkIGlv cnQgcm1yIHdpdGggb25lIElEIG1hcHBpbmcgYW5kIHdvcmtzIHdlbGwuCgpTZWNvbmRseSwgV2hl biB0aGVyZSBpcyBtb3JlIHRoYW4gdHdvIGlkIG1hcHBpbmdzLCB0aGUgYnVnZ2x5IGlkX2NvdW50 IApjaGVjayBoYXMgbm8gZWZmZWN0KGZvciB0aGUgaWRfY291bnQgaXMgbGFyZ2VyIHRoYW4gemVy bykuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51 eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1h cm0ta2VybmVsCg==