From: Ivan Safonov <insafonov@gmail.com>
To: Joe Perches <joe@perches.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Hans de Goede <hdegoede@redhat.com>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Nishka Dasgupta <nishkadg.linux@gmail.com>,
Lukasz Szczesny <luk@wybcz.pl>, R Veera Kumar <vkor@vkten.in>,
Hariprasad Kelam <hariprasad.kelam@gmail.com>,
YueHaibing <yuehaibing@huawei.com>,
Shobhit Kukreti <shobhitkukreti@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Pascal Terjan <pterjan@google.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging:r8723bs: remove wrappers around skb_clone()
Date: Sun, 31 May 2020 20:28:10 +0300 [thread overview]
Message-ID: <8e4df253-e021-6c29-96ab-24eed9b61eb2@gmail.com> (raw)
In-Reply-To: <7bf8612d3708b811e026daec5c7a1486c5954905.camel@perches.com>
On 5/31/20 7:15 PM, Joe Perches wrote:
> On Sun, 2020-05-31 at 19:08 +0300, Ivan Safonov wrote:
>> Wrappers around skb_clone() do not simplify the driver code.
> []
>> -inline struct sk_buff *_rtw_skb_clone(struct sk_buff *skb)
>> -{
>> - return skb_clone(skb, in_interrupt() ? GFP_ATOMIC : GFP_KERNEL);
>> -}
>> -
> []
>> diff --git a/drivers/staging/rtl8723bs/os_dep/recv_linux.c b/drivers/staging/rtl8723bs/os_dep/recv_linux.c
> []
>> @@ -110,7 +110,7 @@ void rtw_os_recv_indicate_pkt(struct adapter *padapter, _pkt *pkt, struct rx_pkt
>> if (memcmp(pattrib->dst, myid(&padapter->eeprompriv), ETH_ALEN)) {
>> if (bmcast) {
>> psta = rtw_get_bcmc_stainfo(padapter);
>> - pskb2 = rtw_skb_clone(pkt);
>> + pskb2 = skb_clone(pkt, GFP_ATOMIC);
>
> Why make every clone allocation GFP_ATOMIC ?
The rtw_os_recv_indicate_pkt() is always called from an interrupt handler.
next prev parent reply other threads:[~2020-05-31 17:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-31 16:08 [PATCH] staging:r8723bs: remove wrappers around skb_clone() Ivan Safonov
2020-05-31 16:15 ` Joe Perches
2020-05-31 17:28 ` Ivan Safonov [this message]
2020-05-31 17:36 ` Joe Perches
2020-05-31 17:49 ` Ivan Safonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e4df253-e021-6c29-96ab-24eed9b61eb2@gmail.com \
--to=insafonov@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hariprasad.kelam@gmail.com \
--cc=hdegoede@redhat.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=luk@wybcz.pl \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=nishkadg.linux@gmail.com \
--cc=pterjan@google.com \
--cc=shobhitkukreti@gmail.com \
--cc=vkor@vkten.in \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.