From: James Smart <jsmart2021@gmail.com>
To: Tong Zhang <ztong0001@gmail.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] scsi: lpfc: Add auto select on IRQ_POLL
Date: Tue, 26 Jan 2021 05:25:28 -0800 [thread overview]
Message-ID: <8e4e3e25-e69f-56ee-bff6-4fbf68262b38@gmail.com> (raw)
In-Reply-To: <20210126000554.309858-1-ztong0001@gmail.com>
On 1/25/2021 4:05 PM, Tong Zhang wrote:
> lpfc depends on irq_poll library, but it is not selected automatically.
> When irq_poll is not selected, compiling it can run into following error
>
> ERROR: modpost: "irq_poll_init" [drivers/scsi/lpfc/lpfc.ko] undefined!
> ERROR: modpost: "irq_poll_sched" [drivers/scsi/lpfc/lpfc.ko] undefined!
> ERROR: modpost: "irq_poll_complete" [drivers/scsi/lpfc/lpfc.ko] undefined!
>
> Signed-off-by: Tong Zhang <ztong0001@gmail.com>
> ---
> drivers/scsi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index 701b61ec76ee..c79ac0731b13 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -1159,6 +1159,7 @@ config SCSI_LPFC
> depends on NVME_TARGET_FC || NVME_TARGET_FC=n
> depends on NVME_FC || NVME_FC=n
> select CRC_T10DIF
> + select IRQ_POLL
> help
> This lpfc driver supports the Emulex LightPulse
> Family of Fibre Channel PCI host adapters.
Reviewed-by: James Smart <jsmart2021@gmail.com>
-- james
next prev parent reply other threads:[~2021-01-26 14:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 0:05 [PATCH v1] scsi: lpfc: Add auto select on IRQ_POLL Tong Zhang
2021-01-26 13:25 ` James Smart [this message]
2021-01-27 3:12 ` Martin K. Petersen
2021-01-29 19:01 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e4e3e25-e69f-56ee-bff6-4fbf68262b38@gmail.com \
--to=jsmart2021@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ztong0001@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.