All of lore.kernel.org
 help / color / mirror / Atom feed
From: "NG, ADRIAN HO YIN" <adrian.ho.yin.ng@altera.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Dinh Nguyen <dinguyen@kernel.org>,
	linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/4] arm64: dts: intel: agilex5: add USB3.1 controller node
Date: Fri, 11 Sep 2026 15:58:53 +0800	[thread overview]
Message-ID: <8e69bb7c-a98f-4a33-9e26-b6aa17f07ad6@altera.com> (raw)
In-Reply-To: <20260911-courageous-ninja-gibbon-9f8b0d@quoll>


On 9/11/2026 3:21 PM, Krzysztof Kozlowski wrote:
> On Wed, Sep 09, 2026 at 01:04:38AM +0800, Adrian Ng Ho Yin wrote:
>> Add a DTS node for the Synopsys DWC3 USB3.1 controller on the Agilex5 SoC.
>> Place it under a simple-bus with a 40-bit dma-ranges window (#address-cells
>> = 2) to match the USB DMA address width of the interconnect. Enable it in
>> host mode on the SoCDK board.
>>
>> ref and suspend both use AGILEX5_USB31_SUSPEND_CLK because they share the
>> same hardware clock source on this SoC.
>>
>> Signed-off-by: Adrian Ng Ho Yin <adrian.ho.yin.ng@altera.com>
> Same comments apply. From 5 revisions ago!

Hi Krzysztof

You are right! sorry for repeating this across revisions.

v1 feedback was that DTS must not be mixed into a USB-targeted series.
Splitting the USB3 add and USB0 removal into separate commits inside the
same USB series did not address that; both are still SoC/arm64 DTS and
belong outside the USB tree.

I will send v7 as two postings:
1) USB only: dt-bindings + dwc3-generic-plat
2) DTS only: Agilex5 USB3.1 node + SoCDK enable, and USB0 cleanup

Thanks for the patience.

Best regards,
Adrian
>
> Best regards,
> Krzysztof

  reply	other threads:[~2026-09-11  7:59 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-08 17:04 [PATCH v6 0/4] Add USB3.1 support for Agilex5 Adrian Ng Ho Yin
2026-09-08 17:04 ` [PATCH v6 1/4] dt-bindings: usb: add Altera Agilex5 DWC3 controller Adrian Ng Ho Yin
2026-09-08 17:24   ` sashiko-bot
2026-09-11  7:21   ` Krzysztof Kozlowski
2026-09-08 17:04 ` [PATCH v6 2/4] arm64: dts: intel: agilex5: add USB3.1 controller node Adrian Ng Ho Yin
2026-09-08 17:29   ` sashiko-bot
2026-09-11  7:21   ` Krzysztof Kozlowski
2026-09-11  7:58     ` NG, ADRIAN HO YIN [this message]
2026-09-08 17:04 ` [PATCH v6 3/4] arm64: dts: intel: agilex5: remove usb0 in Agilex5 SoCDK Adrian Ng Ho Yin
2026-09-11  7:22   ` Krzysztof Kozlowski
2026-09-11  7:59     ` NG, ADRIAN HO YIN
2026-09-08 17:04 ` [PATCH v6 4/4] usb: dwc3: add Altera Agilex5 support to generic platform driver Adrian Ng Ho Yin
2026-09-11  9:04 ` [PATCH v7 0/2] usb: dwc3: add Altera Agilex5 DWC3 support adrian.ho.yin.ng
2026-09-11  9:04   ` [PATCH v7 1/2] dt-bindings: usb: add Altera Agilex5 DWC3 controller adrian.ho.yin.ng
2026-09-11  9:13     ` sashiko-bot
2026-09-29 21:45       ` Rob Herring
2026-09-11  9:04   ` [PATCH v7 2/2] usb: dwc3: add Altera Agilex5 support to generic platform driver adrian.ho.yin.ng
2026-09-18 16:46   ` [PATCH v7 0/2] usb: dwc3: add Altera Agilex5 DWC3 support Ng, Adrian Ho Yin
2026-09-18 22:03     ` Thinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e69bb7c-a98f-4a33-9e26-b6aa17f07ad6@altera.com \
    --to=adrian.ho.yin.ng@altera.com \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dinguyen@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.